Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Era support for the BMTF Packer #32365

Merged
merged 7 commits into from
Dec 15, 2020
Merged

Era support for the BMTF Packer #32365

merged 7 commits into from
Dec 15, 2020

Conversation

panoskatsoulis
Copy link
Contributor

@panoskatsoulis panoskatsoulis commented Dec 2, 2020 •
edited
Loading

PR description:

  • Introduces support for the --era arguments in the BMTF Packer (and Unpacker)
    (The Kalman algorithm will be packed for the Run3 era, while the old one will remain for all Run2_... eras.)
  • Cleans up a little the BMTFSetup.cc file
  • Introduces some logging via the MessageLogger under the category "L1T"

PR validation:

Tested using 2 custom workflows with --era Run2_2018 and --era Run3 respectively
Steps of the workflows: -s DIGI2RAW,L1,RAW2DIGI

@rekovic please have a look into this

@cmsbuild cmsbuild added this to the CMSSW_11_3_X milestone Dec 2, 2020
@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2020

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32365/20211

  • This PR adds an extra 20KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32365/20212

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2020

A new Pull Request was created by @panoskatsoulis for master.

It involves the following packages:

EventFilter/L1TRawToDigi

@cmsbuild, @rekovic, @jmduarte can you please review it and eventually sign? Thanks.
@dinyar, @Martin-Grunewald, @thomreis this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@silviodonato
Copy link
Contributor

please test
@cms-sw/l1-l2

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2020 •
edited
Loading

The tests are being triggered in jenkins.

@panoskatsoulis panoskatsoulis mentioned this pull request Dec 2, 2020
Closed
@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2020

+1
Tested at: f24410f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4e87bc/11269/summary.html
CMSSW: CMSSW_11_3_X_2020-12-01-2300
SCRAM_ARCH: slc7_amd64_gcc900

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 2, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4e87bc/11269/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2529593
  • DQMHistoTests: Total failures: 607
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2528964
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 148 log files, 37 edm output root files, 35 DQM output files

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4e87bc/11536/summary.html
CMSSW: CMSSW_11_3_X_2020-12-10-2300/slc7_amd64_gcc900

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2747284
  • DQMHistoTests: Total failures: 259
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2747003
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 153 log files, 37 edm output root files, 36 DQM output files

@panoskatsoulis
Copy link
Contributor Author

@panoskatsoulis , can you please do the following

* create a new branch using `bmtf_eraconfig_packer_unpacker` e.g. `git push origin bmtf_eraconfig_packer_unpacker:bmtf_eraconfig_packer_unpacker-for112`

* For bmtf_eraconfig_packer_unpacker-for112 branch, force commit a change so that last commit is different than the one on `bmtf_eraconfig_packer_unpacker `

* use `bmtf_eraconfig_packer_unpacker-for112` branch to open a PR for 11.2.X.
  Thsi will allow bot to test your changes for 11.2.X. In current situation, as both PRs has the same commits , so when you start a test for #32367 then it also updates the results for #32365 and vice versa

thank you for the suggestion, I didn't know that the bot is working on commit basis.
I will update the backport PR asap

@panoskatsoulis panoskatsoulis mentioned this pull request Dec 11, 2020
Merged
@silviodonato silviodonato marked this pull request as ready for review December 14, 2020 14:14
@silviodonato
Copy link
Contributor

urgent

@silviodonato silviodonato mentioned this pull request Dec 14, 2020
Closed
@silviodonato
Copy link
Contributor

cc: @BenjaminRS @bundocka @cbotta

@silviodonato
Copy link
Contributor

@rekovic could you review and eventually sign this PR?
Tomorrow we are going to build 11_3_0_pre1 and 11_2_0, it would be very good to include a fix for #32467

@silviodonato
Copy link
Contributor

hold

@panoskatsoulis if you think this PR is ready, please type unhold

@panoskatsoulis
Copy link
Contributor Author

unhold
hi, yes it's ready, checked wf 11634.0 (era Run3) and 10824.0 (era Run2_2018) and seem to be as expected

@rekovic
Copy link
Contributor

rekovic commented Dec 15, 2020

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1
the differences are visible only in Run-3 workflows, and they affect only the L1T muon objects

@cmsbuild cmsbuild merged commit 77b393d into cms-sw:master Dec 15, 2020
@silviodonato
Copy link
Contributor

11_2_X backport : #32455

@smuzaffar smuzaffar mentioned this pull request Dec 15, 2020
Merged
This was referenced Dec 16, 2020
Merged
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rekovic rekovic rekovic left review comments

Assignees
No one assigned
Labels
code-checks-approved fully-signed l1-approved orp-approved tests-approved urgent
Projects
None yet
Milestone
CMSSW_11_3_X
Development

Successfully merging this pull request may close these issues.
5 participants
@panoskatsoulis @cmsbuild @silviodonato @rekovic @smuzaffar