-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Gen vertex time and position to NanoAOD #32008
Merged
+79
−14
Merged
Changes from 6 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
fc26fb3
Add gen vertex position
kdlong 33a7fea
Same precision as reco vertex
kdlong b67c109
Add t0
kdlong 9c738f9
Merge branch 'master' into Nano_GenVertex
kdlong 18db6ce
Only schedule for UL, add DQM
kdlong 24b8ea5
Adjust DQM binning
kdlong d3a7238
Don't rely on nanoAOD_step in nanogen config
kdlong 905471a
Exclude tables rather than sequence
kdlong f1d4ba0
Fix copy error in NanoGen for GenVertex
kdlong eb5aa85
Fix t0 dqm plot, tweak binning
kdlong 5a90327
Merge branch 'Nano_GenVertex' of https://github.com/kdlong/cmssw into…
kdlong 9af3039
Make t0 extension, add extension support to GlobalVariablesTableProducer
kdlong a101df8
Merge branch 'Nano_GenVertex' of https://github.com/kdlong/cmssw into…
kdlong 0afeac5
Remove GenVtx_t0 table from nanogenDQM
kdlong File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
import FWCore.ParameterSet.Config as cms | ||
from PhysicsTools.NanoAOD.common_cff import Var,ExtVar | ||
|
||
genVertexTable = cms.EDProducer("SimpleXYZPointFlatTableProducer", | ||
src = cms.InputTag("genParticles:xyz0"), | ||
cut = cms.string(""), | ||
name= cms.string("GenVtx"), | ||
doc = cms.string("Gen vertex"), | ||
singleton = cms.bool(True), | ||
extension = cms.bool(False), | ||
variables = cms.PSet( | ||
x = Var("X", float, doc="gen vertex x", precision=10), | ||
y = Var("Y", float, doc="gen vertex y", precision=10), | ||
z = Var("Z", float, doc="gen vertex z", precision=16), | ||
) | ||
) | ||
|
||
genVertexT0Table = cms.EDProducer("GlobalVariablesTableProducer", | ||
variables = cms.PSet( | ||
GenVtx_t0 = ExtVar( cms.InputTag("genParticles:t0"), "float", doc = "gen vertex t0", precision=12), | ||
) | ||
) | ||
|
||
genVertexTables = cms.Sequence(genVertexTable+genVertexT0Table) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
process.nanoAOD_step is still in lines
https://github.com/cms-sw/cmssw/pull/32008/files#diff-91cf6c8e867abd8533271bfe6e054ca16c4a1713cfab990d787a2771d32e773eR110-R112