Add Gen vertex time and position to NanoAOD #32008
Conversation
Would also add t0, but it's not straightforward in the current setup
|
The code-checks are being triggered in jenkins. |
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32008/19534
|
|
please test |
|
The tests are being triggered in jenkins.
|
|
A new Pull Request was created by @kdlong (Kenneth Long) for master. It involves the following packages: PhysicsTools/NanoAOD @cmsbuild, @santocch, @mariadalfonso, @gouskos, @fgolf can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
please test workflow 546,547,548 |
|
The tests are being triggered in jenkins.
|
@kdlong why don't you use |
|
@peruzzim the discussion we're having here is exactly the reason xyz and t0 are stored in separate branches in the AOD and MINIAOD in the first place. We can perhaps change that for future releases, but presumably we can just deal with this fact at the nanoaod level for the moment... |
|
@peruzzim I really don't think the current solution is less elegant than putting a gen object in a reco class, and given that it's working and I understood the deadline was today, I'd rather not revisit it. |
|
+1 |
|
Comparison job queued. |
|
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
|
With the last implementation the DQM is finally fixed. |
|
+xpog |
|
merge |
Backport #32008: GenVetex addition to Nano
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged. |
cmsbuild
added
analysis-approved
fully-signed
and removed
analysis-pending
pending-signatures
labels
PR description:
Adds the Gen vertex x,y,z position and time (t0) as a new table in the NanoAOD.
This is needed for an ongoing study in the W mass analysis to determine the rate at which the primary vertex is not correctly assigned with the sum pt^2 algorithm. t0 could be useful for exotics searches. According to @bendavid adding such info to the nano has been discussed briefly in the physics tools workshop planning.
PR validation:
I checked that the info gets added properly to a test MC sample. I just took the precision position from the reco vertex. For t0, I don't know what the needed precision would be.