Backport of UL (2017 and 2018) scale and smearing corrections in nanoAOD photons and electrons (106X)

[jainshilpi]

This is just a backport of #31974 - 2017 and 2018 UL scales and smearing in nanoAOD. Updated files are:
(1) nano_cff.py
(2) photon_cff.py
(3) electron_cff.py

@mariadalfonso

[cmsbuild]

A new Pull Request was created by @jainshilpi for CMSSW_10_6_X.

It involves the following packages:

PhysicsTools/NanoAOD

@cmsbuild, @santocch, @mariadalfonso, @gouskos, @fgolf can you please review it and eventually sign? Thanks.
@gpetruc, @peruzzim, @swertz this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[mariadalfonso]

please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_10_6_X_2020-11-02-1100/slc7_amd64_gcc700: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/10439/console Started: 2020/11/02 15:54

[cmsbuild]

-1

Tested at: f051220

CMSSW: CMSSW_10_6_X_2020-11-02-1100
SCRAM_ARCH: slc7_amd64_gcc700
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7aeeff/10439/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

• RelVals:

When I ran the RelVals I found an error in the following workflows:
10824.0 step6

runTheMatrix-results/10824.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+HARVESTFull_2018+ALCAFull_2018+NanoFull_2018/step6_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+HARVESTFull_2018+ALCAFull_2018+NanoFull_2018.log

[cmsbuild]

Comparison job queued.

[mariadalfonso]

seems that cannot find the
cms-data/EgammaAnalysis-ElectronTools#9

----- Begin Fatal Exception 02-Nov-2020 16:33:33 CET-----------------------
An exception of category 'FileInPathError' occurred while
[0] Constructing the EventProcessor
[1] Constructing module: class=CalibratedPatElectronProducer label='calibratedPatElectronsUL18'
Exception Message:
edm::FileInPath unable to find file EgammaAnalysis/ElectronTools/data/ScalesSmearings/Run2018_29Sep2020_RunFineEtaR9Gain_scales.dat anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_10_6_X_2020-11-02-1100/poison:/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_10_6_X_2020-11-02-1100/src:/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_10_6_X_2020-11-02-1100/external/slc7_amd64_gcc700/data:/cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc700/cms/cmssw-patch/CMSSW_10_6_X_2020-11-02-1100/poison:/cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc700/cms/cmssw-patch/CMSSW_10_6_X_2020-11-02-1100/src:/cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc700/cms/cmssw-patch/CMSSW_10_6_X_2020-11-02-1100/external/slc7_amd64_gcc700/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-tests/runTheMatrix-results/10824.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+HARVESTFull_2018+ALCAFull_2018+NanoFull_2018

[silviodonato]

please test with cms-data/EgammaAnalysis-ElectronTools#9

[cmsbuild]

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-data/EgammaAnalysis-ElectronTools#9

• CMSSW_10_6_X_2020-11-03-1100/slc7_amd64_gcc700: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/10476/console Started: 2020/11/03 16:37

[cmsbuild]

+1
Tested at: f051220
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-49b1d2/10476/summary.html
CMSSW: CMSSW_10_6_X_2020-11-03-1100
SCRAM_ARCH: slc7_amd64_gcc700

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-49b1d2/10476/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 79 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 3214664
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3214327
• DQMHistoTests: Total skipped: 334
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 140 log files, 14 edm output root files, 34 DQM output files

[santocch]

+1

[mariadalfonso]

+xpog
changes inline with master

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1