-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UL2018 scales and smearing correction files #9
Conversation
A new Pull Request was created by @jainshilpi for branch master. @cmsbuild, @smuzaffar, @santocch, @mrodozov can you please review it and eventually sign? Thanks. |
any cmssw PR to test with ? |
yes the PR is just created: |
The tests are being triggered in jenkins.
|
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
@slava77 there are 42 differences in comparison, would you check it please ? |
Differences are expected since these are new scale and smearing corrections. Validation plots can be seen here: https://shilpi-afs.web.cern.ch/shilpi-afs/13TeV/2020/SSvalidation/UL2018/19Oct/ |
+1 |
+externals |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
We would need a back-port for UL2018 as was done for UL2017 (#30199). If its agreed, then I can go ahead and do a back-port. |
The tests are being triggered in jenkins.
|
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
These are scales and smearing files for e/gamma for UL2018