-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PPS] 2021 conditions for timing detectors geometry (resubmission after DD4hep) #31484
Merged
cmsbuild
merged 70 commits into
cms-sw:master
from
forthommel:pps-timing_2021_geom-11_2_X
Dec 11, 2020
Merged
Changes from all commits
Commits
Show all changes
70 commits
Select commit
Hold shift + click to select a range
df2d44e
change the way CMSSW calculates diamond detectors
Vetchu c23cf87
correct diamond detector software
Vetchu 51cafa0
minor naming correction
Vetchu ae4d2cb
fix array
Vetchu da55fc0
CMS style
forthommel 3a43178
Sanity check on geometry hierarchy
forthommel 6150ff4
Generalised the tracks reconstruction algorithms multiplicity
forthommel 45eff0c
Added a hash function for CTPPSDetId objects
forthommel 47b2b9f
Code-format
forthommel b5645d8
One algo per station, not per channel
forthommel 02cb9db
Algorithm launched after all hits are fed
forthommel 518a250
Added 2021-like geometry.
jan-kaspar ed17cff
Indentation fix
forthommel f5e2148
Formatted XML files
forthommel efe2bec
Added eval=true to ConstantsSection of 2021 scenario DDLs
forthommel 065320a
Updated the paths in the DDL parser steering component
forthommel b2b5b0a
Dropped z sign mitigation for diamond in direct proton simulation
forthommel c1ac29c
Dropped z sign mitigation for diamond in proton reconstruction algori…
forthommel 87f2e74
Added copyNumber field to all PosPart
forthommel ce4dc3f
Dropped the CTPPS prefix for timing detectors assembly
forthommel 345acaf
Updated path to timing stations assembly files
forthommel e41c354
Swapped z sign in timing station assemblies
forthommel 6fd23e0
Merged pps-diam_geom_fixes-11_2_X from repository forthommel with cms…
ghugo83 6ca3437
Revert "Swapped z sign in timing station assemblies"
ghugo83 d4addbb
Revert "Updated path to timing stations assembly files"
ghugo83 cd4b027
Revert "Dropped the CTPPS prefix for timing detectors assembly"
ghugo83 858843c
Revert "Dropped z sign mitigation for diamond in proton reconstructio…
ghugo83 4de3ea8
Revert "Dropped z sign mitigation for diamond in direct proton simula…
ghugo83 4e0e871
Fix forgotten copyNumber in PosPart section, in 2021 XML file.
ghugo83 8ff7b07
Consistent naming of CTPPS_Timing_Stations_Assembly.xml among scenari…
ghugo83 43b521f
Merged parallel_oldDD_DD4hep from repository ghugo83 with cms-merge-t…
ghugo83 100b50d
Add 2021 scenario also for DD4hep, in parallel of old DD.
ghugo83 4a90808
Add 2021 bool and special DetId computation in the 2021 scenario case.
ghugo83 f4afe11
There should be no diff in old DD scenarios, remove change to Geometr…
ghugo83 dd09ff9
Merged parallel_oldDD_DD4hep from repository ghugo83 with cms-merge-t…
ghugo83 ff92f72
Remove printouts
ghugo83 b13fd32
scram build code-format
ghugo83 826deaa
Renamed legacy run 2 switch in DetGeomDesc
forthommel 0e77af5
Matched builder too
forthommel 26e0b8c
Adapted tag in PPS geometry builder
forthommel 9f767ff
Also adapted legacy ESModule
forthommel ec4875e
Introduced flag in eras for safety
forthommel 09867cc
Code-format/fixed comment method in ESModule PSet description filling
forthommel f831c50
Replace use of !is2021 by isRun2. isRun2 is set to true by default (t…
ghugo83 c302e5b
Replaced all remaining legacyRun2 mentions
forthommel 5936844
Also change variable name in function + safer to also treat DB writer.
ghugo83 43055e5
Merge branch 'from-CMSSW_11_2_X_2020-11-12-1100' into pps-timing_2021…
forthommel eef4883
Clearing the algorithm before filling the event
forthommel be54112
Only clearing algorithms once at new event
forthommel 6d265f4
Run2 tag now tracked
forthommel acf10f3
Updated versioning through xml file hierarchy
forthommel 7f7b1fd
Matched python file to new 2021 scenario file path
forthommel ff042c8
Forgot a few untracked here and there
forthommel dad5041
Reverted isRun2 keyword to untracked for CondTool utolitary as it doe…
forthommel a1e5486
Merge branch 'from-CMSSW_11_3_X_2020-11-30-1100' into pps-timing_2021…
forthommel 9b5a389
Specifying the isRun2 flag in ctppsGeometryESModule base object defin…
forthommel 548dbb4
Importing CTPPSGeometryESModule already defined from ESModule's fillD…
forthommel cba5238
Small aesthetic changes
forthommel 02dbab4
No spurious imports of ESProducer for the ctppsGeometryESModule defin…
forthommel 497ac85
Forgot one isRun2 for dd4hep configuration
forthommel d317b66
Explicit type of isRun2 for ESProducer definition
forthommel 695c0a6
Correcting all other ESProducer definitions
forthommel 3762cb0
Merge branch 'master' into pps-timing_2021_geom-11_2_X
forthommel 86e30ca
Added isRun2 private attribute to CTPPSCompositeESSource plugin
forthommel d1c66ae
Using the isRun2 flag when building geometry description from compact…
forthommel 4e20215
Added isRun2 attribute to PPS composite geometry source
forthommel 35a77e1
isRun2 is a bool and not an unsigned int
forthommel 033388d
Fixed wrong isRun2 value for 2021 geometry tests
forthommel cc64919
Picking up isRun2 flag from base ESModule
forthommel c0145c7
Individual imports instead as import-delete
forthommel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
36 changes: 36 additions & 0 deletions
36
Geometry/VeryForwardData/data/2021/v1/CTPPS_Timing_Stations_Assembly.xml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
<?xml version="1.0"?> | ||
<DDDefinition xmlns="http://www.cern.ch/cms/DDL" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://www.cern.ch/cms/DDL ../../../DetectorDescription/Schema/DDLSchema.xsd"> | ||
<ConstantsSection label="CTPPS_Timing_Stations_Assembly.xml" eval="true"> | ||
<!--positions of the stations from the IP5 to the first element of the station--> | ||
<Constant name="CTPPS_Timing_Negative_Station_Position_z_1" value="-215.078*m"/> | ||
<Constant name="CTPPS_Timing_Positive_Station_Position_z_1" value="215.078*m"/> | ||
<Constant name="CTPPS_Timing_Negative_Station_Position_z_2" value="-215.7*m"/> | ||
<Constant name="CTPPS_Timing_Positive_Station_Position_z_2" value="215.7*m"/> | ||
</ConstantsSection> | ||
<PosPartSection label="CTPPS_Timing_Stations_Assembly.xml"> | ||
<PosPart copyNumber="22"> | ||
<rParent name="cms:CMSE"/> | ||
<rChild name="CTPPS_Timing_Positive_Station:CTPPS_Timing_Positive_Station"/> | ||
<Translation x="0*mm" y="0*mm" z="[CTPPS_Timing_Positive_Station_Position_z_1]"/> | ||
<rRotation name="rotations:000D"/> | ||
</PosPart> | ||
<PosPart copyNumber="16"> | ||
<rParent name="cms:CMSE"/> | ||
<rChild name="CTPPS_Timing_Positive_Station:CTPPS_Timing_Positive_Station"/> | ||
<Translation x="0*mm" y="0*mm" z="[CTPPS_Timing_Positive_Station_Position_z_2]"/> | ||
<rRotation name="rotations:000D"/> | ||
</PosPart> | ||
<PosPart copyNumber="122"> | ||
<rParent name="cms:CMSE"/> | ||
<rChild name="CTPPS_Timing_Negative_Station:CTPPS_Timing_Negative_Station"/> | ||
<Translation x="0*mm" y="0*mm" z="[CTPPS_Timing_Negative_Station_Position_z_1]"/> | ||
<rRotation name="rotations:180R"/> | ||
</PosPart> | ||
<PosPart copyNumber="116"> | ||
<rParent name="cms:CMSE"/> | ||
<rChild name="CTPPS_Timing_Negative_Station:CTPPS_Timing_Negative_Station"/> | ||
<Translation x="0*mm" y="0*mm" z="[CTPPS_Timing_Negative_Station_Position_z_2]"/> | ||
<rRotation name="rotations:180R"/> | ||
</PosPart> | ||
</PosPartSection> | ||
</DDDefinition> |
154 changes: 154 additions & 0 deletions
154
Geometry/VeryForwardData/data/2021/v1/RP_220_Left_Station.xml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,154 @@ | ||
<?xml version="1.0" encoding="UTF-8"?> | ||
<DDDefinition xmlns="http://www.cern.ch/cms/DDL" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://www.cern.ch/cms/DDL ../../DDLSchema/DDLSchema.xsd"> | ||
<ConstantsSection label="RP_220_Left_Station.xml" eval="true"> | ||
<Constant name="RP_220_Left_Station_Length" value="6588*mm"/> | ||
<!--Positions calculated from the wall closer to IP point--> | ||
<Constant name="RP_220_Left_Prim_Vert_z" value="608*mm"/> | ||
<Constant name="RP_220_Left_Prim_Hor_z" value="1058*mm"/> | ||
<Constant name="RP_220_Left_Sec_Hor_z" value="5530*mm"/> | ||
<Constant name="RP_220_Left_Sec_Vert_z" value="5980*mm"/> | ||
<Constant name="RP_220_Left_Hor_Vac_Length" value="[RP_Device:RP_Device_Envelope_Radius]+[RP_Device:RP_Device_Length_y]/2-[RP_Horizontal_Device:RP_Device_Hor_Closed_Wall_Thick_Int]"/> | ||
</ConstantsSection> | ||
<SolidSection label="RP_220_Left_Station.xml"> | ||
<Tube rMin="0*mm" rMax="[RP_Device:RP_Device_Envelope_Radius]*1.1" dz="[RP_220_Left_Station_Length]/2" name="RP_220_Left_Station"/> | ||
<Tube rMin="[RP_Device:RP_Device_Beam_Hole_Diam]/2" rMax="[RP_Device:RP_Device_Beam_Hole_Diam]/2+[RP_Device:RP_Device_Wall_Thickness]" dz="([RP_220_Left_Prim_Vert_z]-[RP_Device:RP_Device_Length_z]/2)/2" name="RP_220_Left_Station_Tube_1"/> | ||
<Tube rMin="[RP_Device:RP_Device_Beam_Hole_Diam]/2" rMax="[RP_Device:RP_Device_Beam_Hole_Diam]/2+[RP_Device:RP_Device_Wall_Thickness]" dz="([RP_220_Left_Prim_Hor_z]-[RP_220_Left_Prim_Vert_z]-[RP_Device:RP_Device_Length_z])/2" name="RP_220_Left_Station_Tube_2"/> | ||
<Tube rMin="[RP_Device:RP_Device_Beam_Hole_Diam]/2" rMax="[RP_Device:RP_Device_Beam_Hole_Diam]/2+[RP_Device:RP_Device_Wall_Thickness]" dz="([RP_220_Left_Sec_Hor_z]-[RP_220_Left_Prim_Hor_z]-[RP_Device:RP_Device_Length_z])/2" name="RP_220_Left_Station_Tube_3"/> | ||
<Tube rMin="[RP_Device:RP_Device_Beam_Hole_Diam]/2" rMax="[RP_Device:RP_Device_Beam_Hole_Diam]/2+[RP_Device:RP_Device_Wall_Thickness]" dz="([RP_220_Left_Sec_Vert_z]-[RP_220_Left_Sec_Hor_z]-[RP_Device:RP_Device_Length_z])/2" name="RP_220_Left_Station_Tube_4"/> | ||
<Tube rMin="[RP_Device:RP_Device_Beam_Hole_Diam]/2" rMax="[RP_Device:RP_Device_Beam_Hole_Diam]/2+[RP_Device:RP_Device_Wall_Thickness]" dz="([RP_220_Left_Station_Length]-[RP_220_Left_Sec_Vert_z]-[RP_Device:RP_Device_Length_z]/2)/2" name="RP_220_Left_Station_Tube_5"/> | ||
<Tube rMin="0*mm" rMax="[RP_Device:RP_Device_Beam_Hole_Diam]/2" dz="[RP_220_Left_Station_Length]/2" name="RP_220_Left_Station_Vacuum_1"/> | ||
<Tube rMin="0*mm" rMax="[RP_Device:RP_Device_RP_Hole_Diam]/2" dz="[RP_Device:RP_Device_Envelope_Radius]" name="RP_220_Left_Station_Vert_Vacuum"/> | ||
<UnionSolid name="RP_220_Left_Station_Vacuum_2"> | ||
<rSolid name="RP_220_Left_Station_Vacuum_1"/> | ||
<rSolid name="RP_220_Left_Station_Vert_Vacuum"/> | ||
<rRotation name="RP_Transformations:RP_x_90_rot"/> | ||
<Translation x="0*mm" y="0*mm" z="-(-[RP_220_Left_Station_Length]/2+[RP_220_Left_Prim_Vert_z])"/> | ||
</UnionSolid> | ||
<UnionSolid name="RP_220_Left_Station_Vacuum_3"> | ||
<rSolid name="RP_220_Left_Station_Vacuum_2"/> | ||
<rSolid name="RP_220_Left_Station_Vert_Vacuum"/> | ||
<rRotation name="RP_Transformations:RP_x_90_rot"/> | ||
<Translation x="0*mm" y="0*mm" z="-(-[RP_220_Left_Station_Length]/2+[RP_220_Left_Sec_Vert_z])"/> | ||
</UnionSolid> | ||
<Tube rMin="0*mm" rMax="[RP_Device:RP_Device_RP_Hole_Diam]/2" dz="[RP_220_Left_Hor_Vac_Length]/2" name="RP_220_Left_Station_Hor_Vacuum"/> | ||
<UnionSolid name="RP_220_Left_Station_Vacuum_4"> | ||
<rSolid name="RP_220_Left_Station_Vacuum_3"/> | ||
<rSolid name="RP_220_Left_Station_Hor_Vacuum"/> | ||
<rRotation name="RP_Transformations:RP_y_90_rot"/> | ||
<Translation x="-(-[RP_220_Left_Hor_Vac_Length]/2+[RP_Device:RP_Device_Length_y]/2-[RP_Horizontal_Device:RP_Device_Hor_Closed_Wall_Thick_Int])" y="0*mm" z="-(-[RP_220_Left_Station_Length]/2+[RP_220_Left_Prim_Hor_z])"/> | ||
</UnionSolid> | ||
<UnionSolid name="RP_220_Left_Station_Vacuum_5"> | ||
<rSolid name="RP_220_Left_Station_Vacuum_4"/> | ||
<rSolid name="RP_220_Left_Station_Hor_Vacuum"/> | ||
<rRotation name="RP_Transformations:RP_y_90_rot"/> | ||
<Translation x="-(-[RP_220_Left_Hor_Vac_Length]/2+[RP_Device:RP_Device_Length_y]/2-[RP_Horizontal_Device:RP_Device_Hor_Closed_Wall_Thick_Int])" y="0*mm" z="-(-[RP_220_Left_Station_Length]/2+[RP_220_Left_Sec_Hor_z])"/> | ||
</UnionSolid> | ||
</SolidSection> | ||
<LogicalPartSection label="RP_220_Left_Station.xml"> | ||
<LogicalPart name="RP_220_Left_Station"> | ||
<rSolid name="RP_220_Left_Station"/> | ||
<rMaterial name="RP_Materials:Air"/> | ||
</LogicalPart> | ||
<LogicalPart name="RP_220_Left_Station_Tube_1"> | ||
<rSolid name="RP_220_Left_Station_Tube_1"/> | ||
<rMaterial name="RP_Materials:AISI-316L-Steel"/> | ||
</LogicalPart> | ||
<LogicalPart name="RP_220_Left_Station_Tube_2"> | ||
<rSolid name="RP_220_Left_Station_Tube_2"/> | ||
<rMaterial name="RP_Materials:AISI-316L-Steel"/> | ||
</LogicalPart> | ||
<LogicalPart name="RP_220_Left_Station_Tube_3"> | ||
<rSolid name="RP_220_Left_Station_Tube_3"/> | ||
<rMaterial name="RP_Materials:AISI-316L-Steel"/> | ||
</LogicalPart> | ||
<LogicalPart name="RP_220_Left_Station_Tube_4"> | ||
<rSolid name="RP_220_Left_Station_Tube_4"/> | ||
<rMaterial name="RP_Materials:AISI-316L-Steel"/> | ||
</LogicalPart> | ||
<LogicalPart name="RP_220_Left_Station_Tube_5"> | ||
<rSolid name="RP_220_Left_Station_Tube_5"/> | ||
<rMaterial name="RP_Materials:AISI-316L-Steel"/> | ||
</LogicalPart> | ||
<LogicalPart name="RP_220_Left_Station_Vacuum_5"> | ||
<rSolid name="RP_220_Left_Station_Vacuum_5"/> | ||
<rMaterial name="RP_Materials:RP_Primary_Vacuum"/> | ||
</LogicalPart> | ||
</LogicalPartSection> | ||
<PosPartSection label="RP_220_Left_Station.xml"> | ||
<PosPart copyNumber="1"> | ||
<rParent name="RP_220_Left_Station"/> | ||
<rChild name="RP_Vertical_Device:RP_Device_Vert_Corp_3"/> | ||
<Translation x="0*mm" y="0*mm" z="-(-[RP_220_Left_Station_Length]/2+[RP_220_Left_Prim_Vert_z])"/> | ||
</PosPart> | ||
<PosPart copyNumber="2"> | ||
<rParent name="RP_220_Left_Station"/> | ||
<rChild name="RP_Vertical_Device:RP_Device_Vert_Corp_3"/> | ||
<Translation x="0*mm" y="0*mm" z="-(-[RP_220_Left_Station_Length]/2+[RP_220_Left_Sec_Vert_z])"/> | ||
</PosPart> | ||
<PosPart copyNumber="1"> | ||
<rParent name="RP_220_Left_Station"/> | ||
<rChild name="RP_Horizontal_Device:RP_Device_Hor_Corp_3"/> | ||
<Translation x="0*mm" y="0*mm" z="-(-[RP_220_Left_Station_Length]/2+[RP_220_Left_Prim_Hor_z])"/> | ||
</PosPart> | ||
<PosPart copyNumber="2"> | ||
<rParent name="RP_220_Left_Station"/> | ||
<rChild name="RP_Horizontal_Device:RP_Device_Hor_Corp_3"/> | ||
<Translation x="0*mm" y="0*mm" z="-(-[RP_220_Left_Station_Length]/2+[RP_220_Left_Sec_Hor_z])"/> | ||
</PosPart> | ||
<PosPart copyNumber="1"> | ||
<rParent name="RP_220_Left_Station"/> | ||
<rChild name="RP_220_Left_Station_Tube_1"/> | ||
<Translation x="0*mm" y="0*mm" z="-(-[RP_220_Left_Station_Length]/2+([RP_220_Left_Prim_Vert_z]-[RP_Device:RP_Device_Length_z]/2)/2)"/> | ||
</PosPart> | ||
<PosPart copyNumber="1"> | ||
<rParent name="RP_220_Left_Station"/> | ||
<rChild name="RP_220_Left_Station_Tube_2"/> | ||
<Translation x="0*mm" y="0*mm" z="-(-[RP_220_Left_Station_Length]/2+([RP_220_Left_Prim_Vert_z]+[RP_220_Left_Prim_Hor_z])/2)"/> | ||
</PosPart> | ||
<PosPart copyNumber="1"> | ||
<rParent name="RP_220_Left_Station"/> | ||
<rChild name="RP_220_Left_Station_Tube_4"/> | ||
<Translation x="0*mm" y="0*mm" z="-(-[RP_220_Left_Station_Length]/2+([RP_220_Left_Sec_Hor_z]+[RP_220_Left_Sec_Vert_z])/2)"/> | ||
</PosPart> | ||
<PosPart copyNumber="1"> | ||
<rParent name="RP_220_Left_Station"/> | ||
<rChild name="RP_220_Left_Station_Tube_5"/> | ||
<Translation x="0*mm" y="0*mm" z="-([RP_220_Left_Station_Length]/2-([RP_220_Left_Station_Length]-[RP_220_Left_Sec_Vert_z]-[RP_Device:RP_Device_Length_z]/2)/2)"/> | ||
</PosPart> | ||
<PosPart copyNumber="1"> | ||
<rParent name="RP_220_Left_Station"/> | ||
<rChild name="RP_220_Left_Station_Vacuum_5"/> | ||
</PosPart> | ||
<PosPart copyNumber="20"> | ||
<rParent name="RP_220_Left_Station_Vacuum_5"/> | ||
<rChild name="RP_Box_020:RP_box_primary_vacuum"/> | ||
<rRotation name="RP_Transformations:RP_y_180_rot"/> | ||
<Translation x="0*mm" y="[RP_Dist_Beam_Cent:RP_220_Left_Det_Dist_0]+[RP_Box:RP_Box_primary_vacuum_y]/2" z="-([RP_220_Left_Prim_Vert_z]-[RP_220_Left_Station_Length]/2)"/> | ||
</PosPart> | ||
<PosPart copyNumber="21"> | ||
<rParent name="RP_220_Left_Station_Vacuum_5"/> | ||
<rChild name="RP_Box_021:RP_box_primary_vacuum"/> | ||
<rRotation name="RP_Transformations:RP_180_z_180_y_rot"/> | ||
<Translation x="0*mm" y="-[RP_Dist_Beam_Cent:RP_220_Left_Det_Dist_1]-[RP_Box:RP_Box_primary_vacuum_y]/2" z="-([RP_220_Left_Prim_Vert_z]-[RP_220_Left_Station_Length]/2)"/> | ||
</PosPart> | ||
<PosPart copyNumber="10023"> | ||
<!-- the offset 10^4 indicates pixel RP --> | ||
<rParent name="RP_220_Left_Station_Vacuum_5"/> | ||
<rChild name="RP_Box_023:RP_box_primary_vacuum"/> | ||
<rRotation name="RP_Transformations:RP_90_z_cw_180_y_rot"/> | ||
<Translation x="-(-[RP_Dist_Beam_Cent:RP_220_Left_Det_Dist_3]-[RP_Box:RP_Box_primary_vacuum_y]/2)" y="0*mm" z="-([RP_220_Left_Sec_Hor_z]-[RP_220_Left_Station_Length]/2)"/> | ||
</PosPart> | ||
<PosPart copyNumber="24"> | ||
<rParent name="RP_220_Left_Station_Vacuum_5"/> | ||
<rChild name="RP_Box_024:RP_box_primary_vacuum"/> | ||
<rRotation name="RP_Transformations:RP_y_180_rot"/> | ||
<Translation x="0*mm" y="[RP_Dist_Beam_Cent:RP_220_Left_Det_Dist_4]+[RP_Box:RP_Box_primary_vacuum_y]/2" z="-([RP_220_Left_Sec_Vert_z]-[RP_220_Left_Station_Length]/2)"/> | ||
</PosPart> | ||
<PosPart copyNumber="25"> | ||
<rParent name="RP_220_Left_Station_Vacuum_5"/> | ||
<rChild name="RP_Box_025:RP_box_primary_vacuum"/> | ||
<rRotation name="RP_Transformations:RP_180_z_180_y_rot"/> | ||
<Translation x="0*mm" y="-[RP_Dist_Beam_Cent:RP_220_Left_Det_Dist_5]-[RP_Box:RP_Box_primary_vacuum_y]/2" z="-([RP_220_Left_Sec_Vert_z]-[RP_220_Left_Station_Length]/2)"/> | ||
</PosPart> | ||
</PosPartSection> | ||
</DDDefinition> |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@forthommel - out of curiosity why cannot you rely on an iov to determine that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ianna, thanks for your post-review! Indeed an IOV could have worked too, but as there is only one algorithmic change (i.e. a few hardcoded values becoming "dynamic") a simple flag is probably more efficient. But this discussion is indeed quite dated (3-4 months), and I cannot fully remember the various arguments (if any).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was a long discussion. Eventually we decided to introduce this flag instead of re-uploading the Run2 geometry payloads.