[PPS] 2021 conditions for timing detectors geometry (resubmission after DD4hep)

[forthommel]

PR description:

This PR is a follow-up of #30252 after the merging of #31383 porting the PPS geometry into the DD4hep world. It includes a new set of DDLs for 2021 scenario (preparing for the addition of a new timing station), before integration onto the geometry DB payload.
The DetGeomDesc geometry parser is therefore modified to host this additional station, better exploiting the copy numbers in a modified hierarchy. As a result, this latter requires the addition of a "legacy" isRun2 flag to allow the previous DD/DB geometry format.

As a side development, the track reconstruction plugin is adapted to dynamically create a track fitting algorithm for each new pot/station observed in the rechits stream (i.e. timing pots are not hardcoded anymore in plugin implementation).
Algorithms being stored as an associative container (single pot detid → algorithm) of this latter, a hash function is defined for the CTPPSDetId object used as an indexing variable.

@fabferro @jan-kaspar @ghugo83

PR validation:

Same validation procedure as #30996. Observed no difference in run 2 CTPPSDiamond* objects with the definition of the new station.
Overlaps detected (using the g4OverlapCheck tool) equivalent to the ones already present in run 2 geometry (the current second station implementation is a naive copy-paste of this latter), and will be corrected in a follow-up PR. This PR being intended for an update of the reconstruction geometry payload (not the simulation one) it should not be problematic. Experts are warmly welcomed to comment.

if this PR is a backport please specify the original PR and why you need to backport that PR: N/A

Before submitting your pull requests, make sure you followed this checklist:

• verify that the PR is really intended for the chosen branch
• verify that changes follow CMS Naming, Coding, And Style Rules
• verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

[cmsbuild]

+1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d0bc69/11478/summary.html
CMSSW: CMSSW_11_3_X_2020-12-09-1100/slc7_amd64_gcc900

[cmsbuild]

Comparison results are now available
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d0bc69/11478/summary.html
CMSSW: CMSSW_11_3_X_2020-12-09-1100/slc7_amd64_gcc900

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 46 differences found in the comparisons
• DQMHistoTests: Total files compared: 36
• DQMHistoTests: Total histograms compared: 2747014
• DQMHistoTests: Total failures: 18
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2746973
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 35 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 153 log files, 37 edm output root files, 36 DQM output files

[forthommel]

Seems that the comparisons are compatible with #31484 (comment) (a few more WF seems to have appeared in the meantime though?)

[jfernan2]

+1

[perrotta]

+1

• Just rebased, and applied a few changes not reco related, since last reco signature in [PPS] 2021 conditions for timing detectors geometry (resubmission after DD4hep) #31484 (comment)
• In the whole PR the only change in reco is for the CTPPSDiamondLocalTrackFitter plugin, which now dynamically creates a track fitting algorithm for each new pot/station observed in the rechits stream (instead of hardcoding every time the two "45" and "56" ones, as it was done before): this will also allow dynamically taking into account of possible new ones
• Being they created dynamically, the size of those DiamondLocalTracks is now 0 when they are not present in the data or in the MC setup, as expected (with respect to the previous comparisons, there are a few more MC workflows, and therefore a larger number of workflows with differences are reported by the automatic comparison)
• Jenkins tests do not show other differences

[forthommel]

Many thanks, @cvuosalo, @jfernan2, @perrotta!
@christopheralanwest, @tlampen, @pohsun, @yuanchao, @ggovi, @mdhildreth, @civanch?

[forthommel]

@christopheralanwest, @tlampen, @pohsun, @yuanchao, @ggovi, @mdhildreth, @civanch, as usual, let me/us know if you need any help to ease your review.

[ggovi]

+1

[forthommel]

Many thanks, @ggovi !
@christopheralanwest, @tlampen, @pohsun, @yuanchao, @mdhildreth, @civanch, kindly reminder :)

[silviodonato]

merge
@cms-sw/simulation-l2 already signed before the last rebase
@cms-sw/alca-l2 had to review only a trivial change CalibPPS/ESProducers/plugins/CTPPSCompositeESSource.cc
(please let us know if you have any comments)

I've opened an issue for a small followup PR regarding @makortel 's comment
#32448

Even if Validation/CTPPS/python/simu_config/year_201*_cff.py are currently used for a private production, they should be safe (see #31484 (comment))

[forthommel]

Thanks a lot, @silviodonato ! Off for a few more PRs now!

[yuanchao]

+1