-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change Phase-2 geometry scenario from D41 to D49 in HBHE darkening analyzer #31412
Change Phase-2 geometry scenario from D41 to D49 in HBHE darkening analyzer #31412
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31412/18274
|
A new Pull Request was created by @christopheralanwest for master. It involves the following packages: CalibCalorimetry/HcalPlugins @cmsbuild, @pohsun, @christopheralanwest, @tocheng, @tlampen can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins.
|
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+alca |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR changes the phase 2 geometry from the deprecated
D41
scenario to theD49
scenario in the python configuration for the HBHE darkening analyzer. Only a single commented line is affected. The commented line has not been removed because one might wish to run the darkening analyzer on Phase-2 MC.This PR would resolve issue #31081 for AlCa.
PR validation:
Code compiles.
if this PR is a backport please specify the original PR and why you need to backport that PR:
This PR is not a backport and should not be backported.