Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extended 2026 D41 Reco scenario now deprecated #31081

Closed
vargasa opened this issue Aug 6, 2020 · 16 comments
Closed

Extended 2026 D41 Reco scenario now deprecated #31081

vargasa opened this issue Aug 6, 2020 · 16 comments

Comments

@vargasa
Copy link
Contributor

vargasa commented Aug 6, 2020

D41 is now deprecated, see 44ce8eb#diff-67340df274822cfd075708d5be080594

The following list of files:nLine:line still make reference to it

CalibCalorimetry/HcalPlugins/test/hbhedarkeninganalyzer_cfg.py:10:#process.load("Configuration.Geometry.GeometryExtended2026D41Reco_cff")
Geometry/HGCalGeometry/test/python/hgcGeomAnalyzer_cfg.py:17:    process.load('Configuration.Geometry.GeometryExtended2026D41Reco_cff')
Geometry/HGCalGeometry/test/python/testHGCalGeomLocator_cfg.py:6:process.load("Configuration.Geometry.GeometryExtended2026D41Reco_cff")
Geometry/HGCalGeometry/test/python/testHGCalGeometryCheck_cfg.py:11:process.load('Configuration.Geometry.GeometryExtended2026D41Reco_cff')
Geometry/HGCalGeometry/test/python/testHGCalGeometry_cfg.py:6:process.load("Configuration.Geometry.GeometryExtended2026D41Reco_cff")
Geometry/HGCalGeometry/test/python/testHGCalRecHitTool_cfg.py:8:#process.load("Configuration.Geometry.GeometryExtended2026D41Reco_cff")
Geometry/HcalCommonData/test/python/runHcalRecNumberingTester_cfg.py:4:process.load('Configuration.Geometry.GeometryExtended2026D41Reco_cff')
L1Trigger/DTTriggerPhase2/test/test_primitivesPhase2Prod_over_dTDigis_and_4Dsegments_cfg.py:5:process.load('Configuration.Geometry.GeometryExtended2026D41Reco_cff')
L1Trigger/L1THGCal/test/testHGCalL1TGeometryV10Imp1_cfg.py:13:process.load('Configuration.Geometry.GeometryExtended2026D41Reco_cff')
L1Trigger/L1THGCal/test/testHGCalL1TGeometryV10Imp2_cfg.py:13:process.load('Configuration.Geometry.GeometryExtended2026D41Reco_cff')
L1Trigger/L1THGCalUtilities/test/testHGCalL1T_RelValV10_cfg.py:12:process.load('Configuration.Geometry.GeometryExtended2026D41Reco_cff')
RecoTauTag/RecoTau/test/rerunMVAIsolationOnMiniAOD_Phase2.py:5:process.load('Configuration.Geometry.GeometryExtended2026D41Reco_cff')
SimCalorimetry/HGCalSimAlgos/test/hgchebacksignalscaler_cfg.py:16:process.load('Configuration.Geometry.GeometryExtended2026D41Reco_cff')
SimTracker/TrackerMaterialAnalysis/test/listGroups.py:20:    process.load('Configuration.Geometry.GeometryExtended2026D41Reco_cff')
SimTracker/TrackerMaterialAnalysis/test/listIds_PhaseII.py:10:  process.load('Configuration.Geometry.GeometryExtended2026D41Reco_cff')
Validation/HGCalValidation/test/python/runHGCGeomCheck_cfg.py:11:process.load('Configuration.Geometry.GeometryExtended2026D41Reco_cff')
Validation/HGCalValidation/test/python/runHGCHitAnalyzer_cfg.py:11:process.load('Configuration.Geometry.GeometryExtended2026D41Reco_cff')
Validation/HGCalValidation/test/python/runHGCalDigiStudy_cfg.py:11:process.load('Configuration.Geometry.GeometryExtended2026D41Reco_cff')
Validation/HGCalValidation/test/python/runHGCalHitCalibration_cfg.py:12:process.load('Configuration.Geometry.GeometryExtended2026D41Reco_cff')
Validation/HGCalValidation/test/python/runHGCalRecHitStudy_cfg.py:12:process.load('Configuration.Geometry.GeometryExtended2026D41Reco_cff')
Validation/HGCalValidation/test/python/runHGCalSimHitStudy_cfg.py:11:process.load('Configuration.Geometry.GeometryExtended2026D41Reco_cff')
Validation/HGCalValidation/test/python/runHGCalWaferStudy_cfg.py:11:process.load('Configuration.Geometry.GeometryExtended2026D41Reco_cff')
Validation/HGCalValidation/test/python/testHGCalBHValid_cfg.py:12:process.load('Configuration.Geometry.GeometryExtended2026D41Reco_cff')
Validation/HGCalValidation/test/python/testHGCalSimHitStudy_cfg.py:11:process.load('Configuration.Geometry.GeometryExtended2026D41Reco_cff')
Validation/HGCalValidation/test/python/testHGCalSimWatcherV10_cfg.py:12:process.load('Configuration.Geometry.GeometryExtended2026D41Reco_cff')

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 6, 2020

A new Issue was created by @vargasa Andrs Vargas.

@Dr15Jones, @dpiparo, @silviodonato, @smuzaffar, @makortel, @qliphy can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

@makortel
Copy link
Contributor

makortel commented Aug 6, 2020

assign geometry, upgrade, alca, l1, reconstruction, simulation, dqm

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 6, 2020

New categories assigned: upgrade,geometry,simulation,reconstruction,l1,dqm,alca

@Dr15Jones,@cvuosalo,@mdhildreth,@mdhildreth,@jfernan2,@slava77,@benkrikler,@christopheralanwest,@andrius-k,@fioriNTU,@tlampen,@pohsun,@rekovic,@perrotta,@makortel,@jpata,@tocheng,@kmaeshima,@ianna,@kpedro88,@civanch,@civanch you have been requested to review this Pull request/Issue and eventually sign? Thanks

@kpedro88
Copy link
Contributor

kpedro88 commented Aug 6, 2020

-1
test configs are not supported in general
if users/developers want them to be supported, they should make actual unit tests

@perrotta
Copy link
Contributor

perrotta commented Sep 3, 2020

@mbluj @swozniewski please notice that there is a Tau test config which still loads the deprecated Extended 2026 D41 scenario: RecoTauTag/RecoTau/test/rerunMVAIsolationOnMiniAOD_Phase2.py
Test configs will not be dealt with centrally by reco, but you are invited to either update or remove it

@mbluj
Copy link
Contributor

mbluj commented Sep 3, 2020

@mbluj @swozniewski please notice that there is a Tau test config which still loads the deprecated Extended 2026 D41 scenario: RecoTauTag/RecoTau/test/rerunMVAIsolationOnMiniAOD_Phase2.py
Test configs will not be dealt with centrally by reco, but you are invited to either update or remove it

Thank you for notifying us. We will update this test configuration to newer scenario. Tested tauID should be quite robust against changes of scenarios. Is there a recommended scenario to replace D41 one?

@perrotta
Copy link
Contributor

perrotta commented Sep 3, 2020

Thank you for notifying us. We will update this test configuration to newer scenario. Tested tauID should be quite robust against changes of scenarios. Is there a recommended scenario to replace D41 one?

Thank you @mbluj
D49 is the current "replacement" of D41

@christopheralanwest
Copy link
Contributor

@kpedro88 Among the list of affected files, the only one within the AlCa domain is a single commented line in your config CalibCalorimetry/HcalPlugins/test/hbhedarkeninganalyzer_cfg.py. Could you recommend whether the line should be updated or deleted?

@kpedro88
Copy link
Contributor

kpedro88 commented Sep 8, 2020

@christopheralanwest if you're going to make a PR, it would be better to update the commented line. However, as I remark roughly once/week, I strongly encourage everyone to ignore configs in test directories that aren't explicitly unit tested. (This even applies to configs that I created.)

@perrotta
Copy link
Contributor

perrotta commented Sep 8, 2020

+1

@christopheralanwest
Copy link
Contributor

+alca

@jfernan2
Copy link
Contributor

For DQM (Validation package) it has been removed for all Validation/HGCalValidation/test/python/* in merged PR
#31767
except
Validation/HGCalValidation/test/python/testHGCalSimWatcherV10_cfg.py
L11:process.load('Configuration.Geometry.GeometryExtended2026D41Reco_cff')
L12:process.load('Configuration.Geometry.GeometryExtended2026D41_cff')
FYI: @bsunanda

@civanch
Copy link
Contributor

civanch commented Jan 24, 2021

@vargasa , likely this PR should be closed?

@civanch
Copy link
Contributor

civanch commented Dec 5, 2021

+1

@civanch
Copy link
Contributor

civanch commented Dec 5, 2021

@qliphy, @perrotta , this issue is not relevant anymore, can you, please, close it?

@jfernan2
Copy link
Contributor

jfernan2 commented Dec 5, 2021

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants