Run3-hcx264 Try internal computation in double for DDHcalAngular for dd4hep

[bsunanda]

PR description:

Try internal computation in double for DDHcalAngular for dd4hep to avoid overlap

PR validation:

Standard tests done

if this PR is a backport please specify the original PR and why you need to backport that PR:

Nothing special

[cmsbuild]

The code-checks are being triggered in jenkins.

[bsunanda]

@slomeo Can you try the overlap issue in Muon area with this PR and see if the HO volumes still giving errors?

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31319/18072

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

Geometry/HcalAlgo

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks.
@fabiocos this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[bsunanda]

@cmsbuild Please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-09-01-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/9046/console Started: 2020/09/01 23:18

[cmsbuild]

+1
Tested at: 03d1a42
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4015b9/9046/summary.html
CMSSW: CMSSW_11_2_X_2020-09-01-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4015b9/9046/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 2609667
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2609644
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
• Checked 149 log files, 22 edm output root files, 35 DQM output files

[slomeo]

@slomeo Can you try the overlap issue in Muon area with this PR and see if the HO volumes still giving errors?

@bsunanda : Yes, your PR makes the right job! Please see the attached picture. The MBTail and MBBC volumes have not the overlaps (showed by cmsShow in my post of #31182 ) anymore.

Do you think that for MUONS (i.e lots of overlaps by g4OverlapCheckDD4Hep_cfg.py ) there is the same problem?

[bsunanda]

@slomeo Thanks for checking this. I shall check where else we call for rotation and the steps are done in double

[cvuosalo]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1