Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DD4hep] CMS Overlaps #31182

Closed
vargasa opened this issue Aug 19, 2020 · 17 comments
Closed

[DD4hep] CMS Overlaps #31182

vargasa opened this issue Aug 19, 2020 · 17 comments
Labels
fully-signed geometry-approved

Comments

@vargasa
Copy link
Contributor

vargasa commented Aug 19, 2020 •
edited
Loading

Overlaps currently present within OCMS_1

How to reproduce?

Check: #31181

Here's the full log: $grep detected /afs/cern.ch/user/s/slomeo/public/Overlaps/overlaps.out| sort --unique

Edit:
          Overlap is detected for volume Bottom_Wall_1:1 (G4SubtractionSolid)
          Overlap is detected for volume BumpBond_1:1 (G4Box)
          Overlap is detected for volume BumpBond_2:2 (G4Box)
          Overlap is detected for volume BumpBond_3:3 (G4Box)
          Overlap is detected for volume BumpBond_4:4 (G4Box)
          Overlap is detected for volume BumpBond_5:5 (G4Box)
          Overlap is detected for volume BumpBond_6:6 (G4Box)
          Overlap is detected for volume CTPPS_Diamond_Main_Box_1:1 (G4UnionSolid)
          Overlap is detected for volume CTPPS_Diamond_Plane_1:1 (G4Box)
          Overlap is detected for volume CTPPS_Diamond_Plane_2:2 (G4Box)
          Overlap is detected for volume CTPPS_Diamond_Plane_3:3 (G4Box)
          Overlap is detected for volume CTPPS_Diamond_Plane_4:4 (G4Box)
          Overlap is detected for volume ebalgo:ESPM_10:10 (G4SubtractionSolid)
          Overlap is detected for volume ebalgo:ESPM_11:11 (G4SubtractionSolid)
          Overlap is detected for volume ebalgo:ESPM_1:1 (G4SubtractionSolid)
          Overlap is detected for volume ebalgo:ESPM_12:12 (G4SubtractionSolid)
          Overlap is detected for volume ebalgo:ESPM_13:13 (G4SubtractionSolid)
          Overlap is detected for volume ebalgo:ESPM_14:14 (G4SubtractionSolid)
          Overlap is detected for volume ebalgo:ESPM_15:15 (G4SubtractionSolid)
          Overlap is detected for volume ebalgo:ESPM_16:16 (G4SubtractionSolid)
          Overlap is detected for volume ebalgo:ESPM_17:17 (G4SubtractionSolid)
          Overlap is detected for volume ebalgo:ESPM_18:18 (G4SubtractionSolid)
          Overlap is detected for volume ebalgo:ESPM_19:19 (G4SubtractionSolid)
          Overlap is detected for volume ebalgo:ESPM_20:20 (G4SubtractionSolid)
          Overlap is detected for volume ebalgo:ESPM_21:21 (G4SubtractionSolid)
          Overlap is detected for volume ebalgo:ESPM_22:22 (G4SubtractionSolid)
          Overlap is detected for volume ebalgo:ESPM_2:2 (G4SubtractionSolid)
          Overlap is detected for volume ebalgo:ESPM_23:23 (G4SubtractionSolid)
          Overlap is detected for volume ebalgo:ESPM_24:24 (G4SubtractionSolid)
          Overlap is detected for volume ebalgo:ESPM_25:25 (G4SubtractionSolid)
          Overlap is detected for volume ebalgo:ESPM_26:26 (G4SubtractionSolid)
          Overlap is detected for volume ebalgo:ESPM_27:27 (G4SubtractionSolid)
          Overlap is detected for volume ebalgo:ESPM_28:28 (G4SubtractionSolid)
          Overlap is detected for volume ebalgo:ESPM_29:29 (G4SubtractionSolid)
          Overlap is detected for volume ebalgo:ESPM_30:30 (G4SubtractionSolid)
          Overlap is detected for volume ebalgo:ESPM_31:31 (G4SubtractionSolid)
          Overlap is detected for volume ebalgo:ESPM_32:32 (G4SubtractionSolid)
          Overlap is detected for volume ebalgo:ESPM_33:33 (G4SubtractionSolid)
          Overlap is detected for volume ebalgo:ESPM_3:3 (G4SubtractionSolid)
          Overlap is detected for volume ebalgo:ESPM_34:34 (G4SubtractionSolid)
          Overlap is detected for volume ebalgo:ESPM_35:35 (G4SubtractionSolid)
          Overlap is detected for volume ebalgo:ESPM_36:36 (G4SubtractionSolid)
          Overlap is detected for volume ebalgo:ESPM_4:4 (G4SubtractionSolid)
          Overlap is detected for volume ebalgo:ESPM_5:5 (G4SubtractionSolid)
          Overlap is detected for volume ebalgo:ESPM_6:6 (G4SubtractionSolid)
          Overlap is detected for volume ebalgo:ESPM_7:7 (G4SubtractionSolid)
          Overlap is detected for volume ebalgo:ESPM_8:8 (G4SubtractionSolid)
          Overlap is detected for volume ebalgo:ESPM_9:9 (G4SubtractionSolid)
          Overlap is detected for volume EHAWR_1:1 (G4SubtractionSolid)
          Overlap is detected for volume EHAWR_2:2 (G4SubtractionSolid)
          Overlap is detected for volume esalgo:SFAbs1PbLinPb_1:1 (G4SubtractionSolid)
          Overlap is detected for volume esalgo:SFAbs1PbLOutAl_1:1 (G4SubtractionSolid)
          Overlap is detected for volume esalgo:SFAbs2PbLinPb_1:1 (G4SubtractionSolid)
          Overlap is detected for volume esalgo:SFAbs2PbLOutAl_1:1 (G4SubtractionSolid)
          Overlap is detected for volume RP_210_Left_Station_1:1 (G4Tubs)
          Overlap is detected for volume RP_210_Right_Station_1:1 (G4Tubs)
          Overlap is detected for volume RP_220_Left_Station_1:1 (G4Tubs)
          Overlap is detected for volume RP_220_Right_Station_1:1 (G4Tubs)

@civanch given #31143 (comment) can you tell us which ones can be ignored?
@cmsbuild
Copy link
Contributor

A new Issue was created by @vargasa Andres Vargas.

@Dr15Jones, @dpiparo, @silviodonato, @smuzaffar, @makortel, @qliphy can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

@civanch
Copy link
Contributor

civanch commented Aug 19, 2020

@vargasa , this likely problem of DD4Hep. In DDD we have overlaps but they do not make real problem for simulation.

@makortel
Copy link
Contributor

assign geometry

@cmsbuild
Copy link
Contributor

New categories assigned: geometry

@Dr15Jones,@cvuosalo,@mdhildreth,@makortel,@ianna,@civanch you have been requested to review this Pull request/Issue and eventually sign? Thanks

@vargasa vargasa mentioned this issue Aug 19, 2020
Merged
@vargasa
Copy link
Contributor Author

vargasa commented Aug 28, 2020

@cvuosalo, @slomeo, @bsunanda. FYI: YB* volumes are part of the muon system and EHAWR* are part of ecal

@slomeo
Copy link
Contributor

slomeo commented Aug 28, 2020

@vargasa I'll check them, following the commands present in #31181, after that PR #31043 will be merged. @cvuosalo @bsunanda @ianna @civanch : Last year I fixed all YB* (i.e not active volumes) overlaps seen by "cmsShow -c overlaps.fwc --sim-geom-file cmsSimGeom.root" (i.e not dd4hep version) so I think that these overlaps are related to dd4hep position alghorithms (i.e not xml code) as @vargasa has found in #31181 for Tracker

@vargasa
Copy link
Contributor Author

vargasa commented Aug 28, 2020

Here's the full log: https://drive.google.com/file/d/1DY_tK7z_cCNuDVK_ynMiSt67fn5sFMkA/view

@slomeo
Copy link
Contributor

slomeo commented Sep 1, 2020 •
edited
Loading

@bsunanda : I followed what @vargas made in #31181 to search overlaps:

  1. In CMSSW_11_2_X_2020-08-31-2300 I run "cmsRun DetectorDescription/DDCMS/test/python/testGeometry2021.py " that has created cmsDD4HepGeom.root
  2. Then I run "cmsShow.exe -c overlaps.fwc --sim-geom-file cmsDD4HepGeom.root --tgeo-name=CMS"

I found 100 overlaps.
Then I looked into the MUON system and you can see the results in the attached picture.

MBTail and MBBC are defined in https://cmssdt.cern.ch/lxr/source/Geometry/HcalCommonData/data/hcalouteralgo.xml and not in muon xml files. Am I correct?

Now I'll use SimG4Core/PrintGeomInfo/test/python/g4OverlapCheckDD4Hep_cfg.py script to see YB* overlaps because as @vargasa said cmsShow is not able to find them.

Schermata 2020-09-01 alle 13 37 47

@bsunanda
Copy link
Contributor

bsunanda commented Sep 1, 2020 via email

@bsunanda
Copy link
Contributor

bsunanda commented Sep 1, 2020

@slomeo @ianna @cvuosalo There is a difference between DDD and DD4Hep is the use of double vs float. This might cause overlap for rotation matrix. Is there a double version of rotation matrix in dd4hep? I am making a PR and see if it helps. But if dd4hep does not have a version with double we may not get a solution

@cvuosalo
Copy link
Contributor

cvuosalo commented Sep 1, 2020

@bsunanda Which rotation matrices are you referring to?

@bsunanda
Copy link
Contributor

bsunanda commented Sep 1, 2020 via email

@slomeo slomeo mentioned this issue Sep 2, 2020
Merged
@slomeo slomeo mentioned this issue Sep 11, 2020
Merged
@slomeo
Copy link
Contributor

slomeo commented Sep 11, 2020

@vargasa @cvuosalo @civanch @bsunanda : please take a look to #31434

@slomeo
Copy link
Contributor

slomeo commented Sep 14, 2020 •
edited
Loading

@vargasa @cvuosalo @civanch @kpedro88 @bsunanda : the updated list of the Overlaps for DD4HEP Scenario 2021 is present in a comment of the PR #31434

@vargasa
Copy link
Contributor Author

vargasa commented Sep 14, 2020

Thank you @slomeo I updated the list in the issue description

@civanch
Copy link
Contributor

civanch commented Jun 9, 2021

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2021

This issue is fully signed and ready to be closed.

@qliphy qliphy closed this as completed Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fully-signed geometry-approved
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@makortel @cmsbuild @civanch @bsunanda @qliphy @cvuosalo @vargasa @slomeo