Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate ECF variables (fix old eras) #31303

Merged
merged 1 commit into from
Sep 1, 2020

Conversation

ahinzmann
Copy link
Contributor

PR description:

Make #31213 run for era 'run2_miniAOD_80XLegacy' (for which the ECFs do not exist in NanoAOD).
Reordering the modifiers to make this work.

PR validation:

runTheMatrix.py -l 136.7722,1329.1

if this PR is a backport please specify the original PR and why you need to backport that PR:

no

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31303/18037

  • This PR adds an extra 20KB to repository

  • There are other open Pull requests which might conflict with changes you have proposed:

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ahinzmann for master.

It involves the following packages:

PhysicsTools/NanoAOD

@gouskos, @cmsbuild, @fgolf, @mariadalfonso, @santocch, @peruzzim can you please review it and eventually sign? Thanks.
@gpetruc this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@slava77
Copy link
Contributor

slava77 commented Aug 31, 2020

@cmsbuild please test workflow 136.7722,1329.1

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 31, 2020

The tests are being triggered in jenkins.
Test Parameters:

@cmsbuild
Copy link
Contributor

+1
Tested at: e4648d2
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-186c07/9021/summary.html
CMSSW: CMSSW_11_2_X_2020-08-31-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-186c07/9021/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2609667
  • DQMHistoTests: Total failures: 11
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2609633
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 34 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 149 log files, 22 edm output root files, 35 DQM output files

@mariadalfonso
Copy link
Contributor

+xpog

@qliphy
Copy link
Contributor

qliphy commented Sep 1, 2020

urgent
would like to include this in next IB to fix #31213

@cmsbuild cmsbuild added the urgent label Sep 1, 2020
@mariadalfonso
Copy link
Contributor

type bug-fix

@qliphy
Copy link
Contributor

qliphy commented Sep 1, 2020

+1

@santocch
Copy link

santocch commented Sep 2, 2020

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2020

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants