GE21 fix nstrips for 16 eta partition option #31225
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| <?xml version="1.0"?> | ||
| <DDDefinition xmlns="http://www.cern.ch/cms/DDL" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://www.cern.ch/cms/DDL ../../../DetectorDescription/Schema/DDLSchema.xsd"> | ||
| <SpecParSection label="GEMSpecs.xml"> | ||
| <SpecPar name="nStripsME0" eval="true"> | ||
| <PartSelector path="//GHA0.."/> | ||
| <Parameter name="nStrips" value="384"/> | ||
| </SpecPar> | ||
| <SpecPar name="nStripsGE11" eval="true"> | ||
| <PartSelector path="//GHA1.."/> | ||
| <Parameter name="nStrips" value="384"/> | ||
| </SpecPar> | ||
| <SpecPar name="nStripsGE21" eval="true"> | ||
| <PartSelector path="//GHA2.."/> | ||
| <Parameter name="nStrips" value="384"/> | ||
| </SpecPar> | ||
| <SpecPar name="nPadsME0" eval="true"> | ||
| <PartSelector path="//GHA0.."/> | ||
| <Parameter name="nPads" value="192"/> | ||
| </SpecPar> | ||
| <SpecPar name="nPadsGE11" eval="true"> | ||
| <PartSelector path="//GHA1.."/> | ||
| <Parameter name="nPads" value="192"/> | ||
| </SpecPar> | ||
| <SpecPar name="nPadsGE21" eval="true"> | ||
| <PartSelector path="//GHA2.."/> | ||
| <Parameter name="nPads" value="384"/> | ||
| </SpecPar> | ||
| </SpecParSection> | ||
| </DDDefinition> | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,22 @@ | ||||||
| <?xml version="1.0"?> | ||||||
| <DDDefinition xmlns="http://www.cern.ch/cms/DDL" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://www.cern.ch/cms/DDL ../../../DetectorDescription/Schema/DDLSchema.xsd"> | ||||||
|
There was a problem hiding this comment.
Suggested change
|
||||||
| <SpecParSection label="GEMSpecsFilter.xml"> | ||||||
| <SpecPar name="MuonME0Tree"> | ||||||
| <PartSelector path="//ME0Box"/> | ||||||
| <PartSelector path="//ME0L"/> | ||||||
| <PartSelector path="//GHA0..*"/> | ||||||
| <Parameter name="MuStructure" value="MuonEndCapME0"/> | ||||||
| </SpecPar> | ||||||
| <SpecPar name="MuonGEMTree"> | ||||||
| <PartSelector path="//GEMBox11L"/> | ||||||
| <PartSelector path="//GSAX11L"/> | ||||||
| <PartSelector path="//GEMBox11S"/> | ||||||
| <PartSelector path="//GSAX11S"/> | ||||||
| <PartSelector path="//GHA1..*"/> | ||||||
| <PartSelector path="//GEMBox21.*"/> | ||||||
| <PartSelector path="//GSAX21.*"/> | ||||||
| <PartSelector path="//GHA2..*"/> | ||||||
| <Parameter name="MuStructure" value="MuonEndCapGEM"/> | ||||||
| </SpecPar> | ||||||
| </SpecParSection> | ||||||
| </DDDefinition> | ||||||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ianna Please confirm the long DDDefinition lines are not needed anymore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall I make this change?
Also, I copied and modified this from another version of the GEMSpecs, should we also update these to remove the schemas?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@watson-ij I think these schemas are obsolete and no longer needed. Please change them in this PR or a later one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I'll make the changes in a new PR