GE21 fix nstrips for 16 eta partition option #31225

watson-ij · 2020-08-25T03:34:33Z

PR description:

New version of GEMSpecs which contains the right number of strips for the 16 eta partition option of GE2/1 (half compared to 8 eta partition, same number of pads as they combine strips from adjacent eta partitions). Update the test geometry to build with the new GEMSpecs version.

@bsunanda @dildick

PR validation:

Checked the geometry still builds and looks correct with a modified Geometry/GEMGeometry/test/testGEMGeometry_cfg.py

if this PR is a backport please specify the original PR and why you need to backport that PR:

Before submitting your pull requests, make sure you followed this checklist:

verify that the PR is really intended for the chosen branch
verify that changes follow CMS Naming, Coding, And Style Rules
verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

compared to the 8 eta partition version.

pads are to be built out of strips from adjacent eta partitions.

cmsbuild · 2020-08-25T03:34:51Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-08-25T03:41:36Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31225/17886

This PR adds an extra 16KB to repository

cmsbuild · 2020-08-25T03:41:57Z

A new Pull Request was created by @watson-ij (Ian J. Watson) for master.

It involves the following packages:

Geometry/GEMGeometryBuilder
Geometry/MuonCommonData

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks.
@jshlee, @ptcox, @dildick, @fabiocos, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

cvuosalo · 2020-08-25T16:22:41Z

@cmsbuild please test

cmsbuild · 2020-08-25T16:23:04Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-08-25-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/8916/console Started: 2020/08/25 18:23

cmsbuild · 2020-08-25T17:31:51Z

+1
Tested at: 61e04a8
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-110016/8916/summary.html
CMSSW: CMSSW_11_2_X_2020-08-25-1100
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-08-25T17:31:53Z

Comparison job queued.

cmsbuild · 2020-08-25T19:01:18Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-110016/8916/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 35
DQMHistoTests: Total histograms compared: 2609656
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2609633
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
Checked 149 log files, 22 edm output root files, 35 DQM output files

cvuosalo · 2020-08-25T19:17:42Z

Geometry/GEMGeometryBuilder/data/v11/GEMSpecs.xml

@@ -0,0 +1,29 @@
+<?xml version="1.0"?>
+<DDDefinition xmlns="http://www.cern.ch/cms/DDL" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://www.cern.ch/cms/DDL ../../../DetectorDescription/Schema/DDLSchema.xsd">


Suggested change

<DDDefinition xmlns="http://www.cern.ch/cms/DDL" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://www.cern.ch/cms/DDL ../../../DetectorDescription/Schema/DDLSchema.xsd">

<DDDefinition>

@ianna Please confirm the long DDDefinition lines are not needed anymore.

Shall I make this change?
Also, I copied and modified this from another version of the GEMSpecs, should we also update these to remove the schemas?

@watson-ij I think these schemas are obsolete and no longer needed. Please change them in this PR or a later one.

Thanks, I'll make the changes in a new PR

cvuosalo · 2020-08-25T19:19:02Z

Geometry/GEMGeometryBuilder/data/v11/GEMSpecsFilter.xml

@@ -0,0 +1,22 @@
+<?xml version="1.0"?>
+<DDDefinition xmlns="http://www.cern.ch/cms/DDL" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://www.cern.ch/cms/DDL ../../../DetectorDescription/Schema/DDLSchema.xsd">


Suggested change

<DDDefinition xmlns="http://www.cern.ch/cms/DDL" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://www.cern.ch/cms/DDL ../../../DetectorDescription/Schema/DDLSchema.xsd">

<DDDefinition>

kpedro88 · 2020-08-27T15:20:37Z

Geometry/MuonCommonData/python/testExtendedGeometry2026D54XML_cfi.py

@@ -111,8 +111,8 @@
        'Geometry/CSCGeometryBuilder/data/cscSpecsFilter.xml',
        'Geometry/CSCGeometryBuilder/data/cscSpecs.xml',
        'Geometry/RPCGeometryBuilder/data/2026/v1/RPCSpecs.xml',
-        'Geometry/GEMGeometryBuilder/data/v7/GEMSpecsFilter.xml',
-        'Geometry/GEMGeometryBuilder/data/v7/GEMSpecs.xml',
+        'Geometry/GEMGeometryBuilder/data/v11/GEMSpecsFilter.xml',


Right now this change is only put in this test file. Will this be propagated to any official detector configurations?

Yes, Sundanda will make a workflow for the 16-partition GE2/1 geometry. But before he can do that, I need to update the GEM-CSC trigger, EMTF and GEM validation modules to temporarily reject those 16-partition GE2/1 trigger pads until the code is updated.

bsunanda · 2020-09-01T15:23:13Z

@cvuosalo Can you please approve this? One can clean up the header later on

cvuosalo · 2020-09-01T19:26:19Z

+1

kpedro88 · 2020-09-03T14:35:30Z

+upgrade

cmsbuild · 2020-09-03T14:35:48Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

qliphy · 2020-09-03T14:46:31Z

+1

watson-ij added 2 commits August 24, 2020 15:50

The 16 eta partition GE2/1 should have half the strips/pads

92d120d

compared to the 8 eta partition version.

Same number of pads and strips in GE2/1 16 eta-partition,

61e04a8

pads are to be built out of strips from adjacent eta partitions.

cmsbuild added this to the CMSSW_11_2_X milestone Aug 25, 2020

cmsbuild added code-checks-pending comparison-pending geometry-pending orp-pending pending-signatures tests-pending upgrade-pending labels Aug 25, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Aug 25, 2020

cmsbuild added tests-started and removed tests-pending labels Aug 25, 2020

cmsbuild added tests-approved and removed tests-started labels Aug 25, 2020

cmsbuild added comparison-available and removed comparison-pending labels Aug 25, 2020

cvuosalo reviewed Aug 25, 2020

View reviewed changes

kpedro88 reviewed Aug 27, 2020

View reviewed changes

cmsbuild added geometry-approved and removed geometry-pending labels Sep 1, 2020

cmsbuild added fully-signed upgrade-approved and removed pending-signatures upgrade-pending labels Sep 3, 2020

cmsbuild added orp-approved and removed orp-pending labels Sep 3, 2020

cmsbuild merged commit 84e158c into cms-sw:master Sep 3, 2020

cmsbuild mentioned this pull request Sep 3, 2020

to make static analyzer happy in RunningAverage #31352

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GE21 fix nstrips for 16 eta partition option #31225

GE21 fix nstrips for 16 eta partition option #31225

watson-ij commented Aug 25, 2020

cmsbuild commented Aug 25, 2020

cmsbuild commented Aug 25, 2020

cmsbuild commented Aug 25, 2020

cvuosalo commented Aug 25, 2020

cmsbuild commented Aug 25, 2020 •

edited

Loading

cmsbuild commented Aug 25, 2020

cmsbuild commented Aug 25, 2020

cmsbuild commented Aug 25, 2020

cvuosalo Aug 25, 2020

cvuosalo Aug 25, 2020

watson-ij Sep 1, 2020

cvuosalo Sep 1, 2020

watson-ij Sep 2, 2020

cvuosalo Aug 25, 2020

kpedro88 Aug 27, 2020

dildick Aug 27, 2020

bsunanda commented Sep 1, 2020

cvuosalo commented Sep 1, 2020

kpedro88 commented Sep 3, 2020

cmsbuild commented Sep 3, 2020

qliphy commented Sep 3, 2020

		@@ -0,0 +1,29 @@
		<?xml version="1.0"?>
		<DDDefinition xmlns="http://www.cern.ch/cms/DDL" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://www.cern.ch/cms/DDL ../../../DetectorDescription/Schema/DDLSchema.xsd">

	<DDDefinition xmlns="http://www.cern.ch/cms/DDL" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://www.cern.ch/cms/DDL ../../../DetectorDescription/Schema/DDLSchema.xsd">
	<DDDefinition>

		@@ -0,0 +1,22 @@
		<?xml version="1.0"?>
		<DDDefinition xmlns="http://www.cern.ch/cms/DDL" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://www.cern.ch/cms/DDL ../../../DetectorDescription/Schema/DDLSchema.xsd">

GE21 fix nstrips for 16 eta partition option #31225

GE21 fix nstrips for 16 eta partition option #31225

Conversation

watson-ij commented Aug 25, 2020

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented Aug 25, 2020

cmsbuild commented Aug 25, 2020

cmsbuild commented Aug 25, 2020

cvuosalo commented Aug 25, 2020

cmsbuild commented Aug 25, 2020 • edited Loading

cmsbuild commented Aug 25, 2020

cmsbuild commented Aug 25, 2020

cmsbuild commented Aug 25, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bsunanda commented Sep 1, 2020

cvuosalo commented Sep 1, 2020

kpedro88 commented Sep 3, 2020

cmsbuild commented Sep 3, 2020

qliphy commented Sep 3, 2020

cmsbuild commented Aug 25, 2020 •

edited

Loading