-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean-up of Tracker conditions for Phase-2 #30695
Clean-up of Tracker conditions for Phase-2 #30695
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30695/16996
|
A new Pull Request was created by @mmusich (Marco Musich) for master. It involves the following packages: Configuration/AlCa @pgunnell, @civanch, @Dr15Jones, @chayanit, @cvuosalo, @wajidalikhan, @christopheralanwest, @ianna, @mdhildreth, @cmsbuild, @makortel, @tocheng, @tlampen, @pohsun, @kpedro88 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
The tests are being triggered in jenkins.
|
+1 |
Comparison job queued. |
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
+upgrade |
+1 |
+1 |
@civanch,@christopheralanwest, @tocheng, @tlampen, @pohsun can you please have a look and comment at earliest convenience? We have more PRs that need to build up on this one. |
+1 |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Follow-up of #30645 and pursuant of #30512.
As Tracker geometries
T6
andT14
have been removed from the release, the corresponding symbolic Global Tags can go as well.For the remaining geometries (
T15
,T17
,T19
,T20
) for the sake of clarity new symbolic Global Tags are introduced (even if they employ the same tags as forT15
, excepted the Pixel 3D geomery oneT19
) and are deployed in the correspondingrunTheMatrix
workflows.Moreoever there is no need for the
SLHCUpgradeSimulations/Geometry/python/fakeConditions_phase2TkT*_cff.py
files either because the corresponding geometry has been removed, or because they don't serve any purpose aymore; the dictionary atdict2026Geometry.py
is changed accordingly.Finally the Global Tag used in the test
SLHCUpgradeSimulations/Geometry/test/phase2_reco_pixelntuple_cfg.py
is bumped up, accordingly to migration toT15
performed in #30645.PR validation:
Branch passes:
and
if this PR is a backport please specify the original PR and why you need to backport that PR:
This PR is not a backport, and no backport is needed.