Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

baseline workflows for UL reminiAOD #30352

Conversation

slava77
Copy link
Contributor

@slava77 slava77 commented Jun 24, 2020

backport of #29526
backport of #30351

Only the process modifier run2_miniAOD_UL and the UL matrix workflows are defined
136.72411,136.76111,136.77211,136.83111,136.88811,1325.516,1325.5161,1325.517,1325.518

After this PR is merged I will make a migration PR to move many (all) run2_miniAOD_devel to use run2_miniAOD_UL.
The staged approach will allow to see the differences in the next step.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 24, 2020

A new Pull Request was created by @slava77 (Slava Krutelyov) for CMSSW_10_6_X.

It involves the following packages:

Configuration/ProcessModifiers
Configuration/PyReleaseValidation

@pgunnell, @chayanit, @wajidalikhan, @kpedro88, @cmsbuild, @silviodonato, @franzoni, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @fabiocos, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@slava77
Copy link
Contributor Author

slava77 commented Jun 24, 2020

@cmsbuild please test workflow 136.72411,136.76111,136.77211,136.83111,136.88811,1325.516,1325.5161,1325.517,1325.518

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 24, 2020

The tests are being triggered in jenkins.
Test Parameters:

@cmsbuild
Copy link
Contributor

+1
Tested at: 64689fa
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-db13b5/7303/summary.html
CMSSW: CMSSW_10_6_X_2020-06-23-2300
SCRAM_ARCH: slc7_amd64_gcc700

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-db13b5/7303/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-db13b5/136.72411_RunJetHT2016B_reminiaodUL+RunJetHT2016B_reminiaodUL+REMINIAOD_data2016UL_HIPM+HARVESTDR2_REMINIAOD_data2016UL_HIPM

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3212264
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3211928
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@slava77
Copy link
Contributor Author

slava77 commented Jun 24, 2020

the workflows passed as expected.
I hope this can be signed and merged in the next couple of days.

@kpedro88
Copy link
Contributor

+upgrade

@slava77
Copy link
Contributor Author

slava77 commented Jun 25, 2020

it would be nice to get this checked by PDMV soon.
We are fairly close to the deadlines for the UL remini.

@chayanit
Copy link

+1

@slava77
Copy link
Contributor Author

slava77 commented Jun 26, 2020

@silviodonato
may I ask you to check this some time soon, so that we can have a reference in jenkins tests ready for the follow up update which would enable the UL modifier (instead of what's now _devel) for the UL remini workflow(s).
Thank you.

@silviodonato
Copy link
Contributor

+1
@slava77 probably I misunderstood. This PR does not seem to include anything from the backport of #29526. Please double check and possibly update the PR description.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_2_X is complete. This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit 390a684 into cms-sw:CMSSW_10_6_X Jun 26, 2020
@slava77
Copy link
Contributor Author

slava77 commented Jun 26, 2020

@slava77 probably I misunderstood. This PR does not seem to include anything from the backport of #29526. Please double check and possibly update the PR description.

In the original PR description:

Only the process modifier run2_miniAOD_UL and the UL matrix workflows are defined
After this PR is merged I will make a migration PR to move many (all) run2_miniAOD_devel to use run2_miniAOD_UL.

I'm not sure what needs to be edited.
Please clarify.
Thank you.

@slava77 slava77 mentioned this pull request Jul 10, 2020
41 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants