-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RecoEgamma/EgammaTools] Updates to EnergyScaleCorrection class for scales and smearings in UL #29526
Conversation
The code-checks are being triggered in jenkins. |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29526/14792
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29526/14793
|
A new Pull Request was created by @jainshilpi for master. It involves the following packages: RecoEgamma/EgammaTools @perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
The tests are being triggered in jenkins. |
-1 Tested at: 755d702 CMSSW: CMSSW_11_1_X_2020-04-20-1100 I found follow errors while testing this PR Failed tests: ClangBuild
I found compilation warning while trying to compile with clang. Command used:
See details on the summary page. |
Comparison not run due to Build errors/Fireworks only changes/No short matrix requested (RelVals and Igprof tests were also skipped) |
Comparison job queued. |
These new UL corrections should be applied by default if not in those two eras. Just to mention that in EGM, we have already validated these corrections and can be found here (using EgammaPostRecoTools): https://shilpi-afs.web.cern.ch/shilpi-afs/13TeV/2020/SSvalidation/UL2017/30marchV2/ |
there were no changes in comparisons, which suggests to me (also based on git grep of configs in the release) that only the two eras have the calibrated photons/electrons. So, it looks like there is no default running. |
Comparison is ready Comparison Summary:
|
@jainshilpi please note Slava's comment |
Hi Silvio, yes this was discussed in the PPD meetings and I discussed iwth Slava separately. I think Slava already is working on it and may have the workflow soon. So once it is done, I will proceed accordingly. |
this requires a PR/update in https://github.com/cms-data/EgammaAnalysis-ElectronTools |
I had forgotten to do that, sorry. Just did it. |
+1
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
This PR takes care of the updated txt file format which stores the scales and smearing corrections.
Updates to following codes have been done:
(1) EnergyScaleCorrection.cc/h - As Sam suggested, the code can now determine the txt file format and reads accordingly
(2) calibratedEgammas_cff.py - now the default txt file to be read is the UL one. For the last re-reco of 2017, run2_miniAOD_94XFall17 is used
(3) Small change to PhotonEnergyCalibrator/ElectronEnergyCalibrator have been done to avoid problems at the boundary.
The related txt files can be found here: https://github.com/jainshilpi/EgammaAnalysis-ElectronTools/tree/UL2017SSV2/ScalesSmearings (24Feb)
runMatrix passed all the tests.