Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GEN-only NanoAOD configs (NanoGEN) and cmsDriver support #30306

Merged
merged 5 commits into from
Sep 7, 2020

Conversation

kdlong
Copy link
Contributor

@kdlong kdlong commented Jun 19, 2020

PR description:

Configuration files to produce only the GEN branches of NanoAOD for a convenient and standardized ntuple format for gen analysis. cmsDriver support to produce directly from a gridpack, or from a MiniAOD file, or anything in between.

PR validation:

Has been tested by generating quite a few samples privately. Some configs and cmsDriver commands tested here: https://github.com/kdlong/WMassNanoGen

Additionally configurability is still a work in progress. Small amount of restructuring of configs should be approved by NanoAOD experts

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@kdlong
Copy link
Contributor Author

kdlong commented Jun 19, 2020

@agrohsje @peruzzim @menglu21

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30306/16272

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @kdlong (Kenneth Long) for master.

It involves the following packages:

Configuration/Applications
PhysicsTools/NanoAOD

@silviodonato, @peruzzim, @cmsbuild, @franzoni, @fgolf, @santocch, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @gpetruc, @fabiocos, @Martin-Grunewald this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@kdlong
Copy link
Contributor Author

kdlong commented Jun 22, 2020

If the ultra legacy GEN is going to run in CMSSW 10_6, then we could have a consistent setup to do central production of NanoGEN through a similar campaign. How hard would this be to support in McM and DAS?

@silviodonato
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 22, 2020

The tests are being triggered in jenkins.

@silviodonato
Copy link
Contributor

@kdlong let me forward your question to @chayanit @pgunnell @wajidalikhan

@cmsbuild
Copy link
Contributor

+1
Tested at: 8192918
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a6b6fe/7253/summary.html
CMSSW: CMSSW_11_2_X_2020-06-22-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a6b6fe/7253/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2778811
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2778760
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 152 log files, 16 edm output root files, 36 DQM output files

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 1, 2020

New categories assigned: generators

@alberto-sanchez,@SiewYan,@qliphy,@GurpreetSinghChahal,@mkirsano,@agrohsje you have been requested to review this Pull request/Issue and eventually sign? Thanks

@silviodonato
Copy link
Contributor

@cms-sw/generators-l2 could you tell us what is the status of this PR? Is it ready to go?

@agrohsje
Copy link

agrohsje commented Sep 4, 2020

i tested this pr a while ago and it looks quite good to me. i have one question about the preferred pdfs. for ul the last list is this one for 5 FS:
https://github.com/cms-sw/genproductions/blob/master/MetaData/pdflist_5f_2017.dat
but 325300 doesn't appear in the preferred list. @kdlong should we extend it/adjust?

@mariadalfonso
Copy link
Contributor

mariadalfonso commented Sep 4, 2020

@agrohsje
let's keep this long standing PR limited to the first set of changes for the GENnano.

Based on the discussion on the xPOG 25aug, we indeed need to update the PDF also for central nano UL.
Among other things I would like to understand which precision we need for these weights and understand the size change, update the nanoDQM for pdf ...

and If you agree, you can sign this PR with the caveat to do the PDF update separately

@agrohsje
Copy link

agrohsje commented Sep 4, 2020

Thanks @mariadalfonso. Doing this in another PR is also fine with me. I just spotted and wanted to make sure we don't forget.
+1

@agrohsje
Copy link

agrohsje commented Sep 4, 2020

+1

@santocch
Copy link

santocch commented Sep 5, 2020

+1

@silviodonato
Copy link
Contributor

+operations

@silviodonato silviodonato changed the title [WIP] GEN-only NanoAOD configs (NanoGEN) and cmsDriver support GEN-only NanoAOD configs (NanoGEN) and cmsDriver support Sep 7, 2020
@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 7, 2020

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants