-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GEN-only NanoAOD configs (NanoGEN) and cmsDriver support #30306
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30306/16272
|
A new Pull Request was created by @kdlong (Kenneth Long) for master. It involves the following packages: Configuration/Applications @silviodonato, @peruzzim, @cmsbuild, @franzoni, @fgolf, @santocch, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
If the ultra legacy GEN is going to run in CMSSW 10_6, then we could have a consistent setup to do central production of NanoGEN through a similar campaign. How hard would this be to support in McM and DAS? |
please test |
The tests are being triggered in jenkins.
|
@kdlong let me forward your question to @chayanit @pgunnell @wajidalikhan |
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
New categories assigned: generators @alberto-sanchez,@SiewYan,@qliphy,@GurpreetSinghChahal,@mkirsano,@agrohsje you have been requested to review this Pull request/Issue and eventually sign? Thanks |
@cms-sw/generators-l2 could you tell us what is the status of this PR? Is it ready to go? |
i tested this pr a while ago and it looks quite good to me. i have one question about the preferred pdfs. for ul the last list is this one for 5 FS: |
@agrohsje Based on the discussion on the xPOG 25aug, we indeed need to update the PDF also for central nano UL. and If you agree, you can sign this PR with the caveat to do the PDF update separately |
Thanks @mariadalfonso. Doing this in another PR is also fine with me. I just spotted and wanted to make sure we don't forget. |
+1 |
+1 |
+operations |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Configuration files to produce only the GEN branches of NanoAOD for a convenient and standardized ntuple format for gen analysis. cmsDriver support to produce directly from a gridpack, or from a MiniAOD file, or anything in between.
PR validation:
Has been tested by generating quite a few samples privately. Some configs and cmsDriver commands tested here: https://github.com/kdlong/WMassNanoGen
Additionally configurability is still a work in progress. Small amount of restructuring of configs should be approved by NanoAOD experts