-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DeepMET into NanoAOD #30291
Add DeepMET into NanoAOD #30291
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30291/16242
|
A new Pull Request was created by @yongbinfeng (Yongbin Feng) for master. It involves the following packages: PhysicsTools/NanoAOD @perrotta, @cmsbuild, @fgolf, @slava77, @santocch, @peruzzim can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
The tests are being triggered in jenkins.
|
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
@yongbinfeng |
The tests are being triggered in jenkins.
|
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
unhold |
merge |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged. |
PR description:
The PR is to add DeepMETs into NanoAOD, following the DeepMET integration into MiniAOD here: #29764.
(And more information about DeepMET could be found from presentations in the JMET group:
https://indico.cern.ch/event/912067/contributions/3835851/ (most recent update)
https://indico.cern.ch/event/883809/contributions/3733818/ (CMS week JetMET meeting)
https://indico.cern.ch/event/854654/contributions/3594579/ (first presentation in MET meeting)
)
The PR will add 4 more variables in NanoAOD (pt and phi of DeepMETResolutionTune and DeepMETResponseTune).
If running with the past Run2 eras where DeepMETs are not saved in MiniAOD, the DeepMET producer is called and DeepMETs will be computed on the fly and saved into Nano. For the future we expect them to be already computed and saved in MiniAOD, so we use the extractions instead, in a similar way as
patCaloMet
.The PR was initially made towards cms-nanoAOD. Then Andreas suggests making one here since cms-nanoAOD is out of sync.
@steggema @intrepid42
@ahinzmann @lathomas
PR validation:
test on a small sample and it works as expected. Also passed unit tests and the runTheMatrix tests.
if this PR is a backport please specify the original PR and why you need to backport that PR: