-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run4-hgx248 Add ERA corresponding to V12 Geometry #30305
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30305/16270
|
A new Pull Request was created by @bsunanda for master. It involves the following packages: Configuration/Eras @pgunnell, @civanch, @Dr15Jones, @chayanit, @cvuosalo, @wajidalikhan, @ianna, @mdhildreth, @cmsbuild, @makortel, @franzoni, @silviodonato, @kpedro88, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild Please test |
The tests are being triggered in jenkins.
|
-1 Tested at: 54a7c0e CMSSW: CMSSW_11_2_X_2020-06-21-0000 I found follow errors while testing this PR Failed tests: UnitTests
I found errors in the following unit tests: ---> test testDD4hepFilteredView had ERRORS |
Comparison job queued. |
@bsunanda i think those tests are failing in the IB |
Comparison is ready Comparison Summary:
|
@cmsbuild Please test |
#30292 is supposed to fix the unit tests, but it doesn't seem to be working. |
+1 |
@bsunanda how is phase2_hgcalV12 expected to be used? |
@kpedro88 This is the version to be used with v11 geometry of HGCal and the corresponding HFNose version |
+upgrade |
+1 |
+operations |
This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
merge |
PR description:
Add ERA corresponding to V12 Geometry of the HGCal
PR validation:
Tested using runTheMatrix.py for workflow 27034.0
if this PR is a backport please specify the original PR and why you need to backport that PR:
Nothing special