Adding eval=true in ConstantsSection in all PPS xml files #30292

mundim · 2020-06-18T14:54:03Z

PR description:

Adding eval="true" in the PPS xml files, as requested in

cms-sw/cmsdist#5954 (comment)

PR validation:

Tests passed and the new files were tested again in the PPS simulation, producing properly the hits as expected.

cmsbuild · 2020-06-18T14:54:39Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-06-18T15:01:36Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30292/16244

This PR adds an extra 36KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File Geometry/VeryForwardData/data/CTPPS_Timing_Stations_Assembly.xml modified in PR(s): [PPS] Timing detector preparation for 2021 conditions #30252

cmsbuild · 2020-06-18T15:02:04Z

A new Pull Request was created by @mundim for master.

It involves the following packages:

Geometry/VeryForwardData

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks.
@forthommel, @jan-kaspar, @fabiocos this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

cvuosalo · 2020-06-18T18:54:06Z

@cmsbuild please test

cmsbuild · 2020-06-18T18:54:28Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-06-18-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/7189/console Started: 2020/06/18 21:02
CMSSW_11_2_X_2020-06-18-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/7200/console Started: 2020/06/19 13:58

cmsbuild · 2020-06-18T20:14:51Z

+1
Tested at: bb06069
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f9f499/7189/summary.html
CMSSW: CMSSW_11_2_X_2020-06-18-1100
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-06-18T20:14:54Z

Comparison job queued.

cmsbuild · 2020-06-18T22:00:55Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f9f499/7189/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 36
DQMHistoTests: Total histograms compared: 2778811
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2778760
DQMHistoTests: Total skipped: 50
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
Checked 152 log files, 16 edm output root files, 36 DQM output files

smuzaffar · 2020-06-19T12:41:32Z

I have restart the test with DetectorDescription/DDCMS Geometry/DTGeometryBuilder SimG4Core/DD4hepGeometry extra package to be build along with this PR. Looks like this did not fix the unit test issue. Test still fail with error

===== Test "testDD4hepCompactView" ====
Running .Info in <TGeoManager::TGeoManager>: Geometry DUMMY, Detector Geometry created
PersistencyIO    INFO  +++ Set Streamer to dd4hep::OpaqueDataBlock
CompactLoader    INFO  +++ Processing compact file: /cvmfs/cms-ib.cern.ch/nweek-02633/slc7_amd64_gcc820/cms/cmssw-patch/CMSSW_11_2_X_2020-06-18-2300/src/Geometry/CMSCommonData/data/dd4hep/cmsExtendedGeometry2021.xml with flag (null)
DD4CMS           INFO  +++ Processing the CMS detector description file:///cvmfs/cms-ib.cern.ch/nweek-02633/slc7_amd64_gcc820/cms/cmssw-patch/CMSSW_11_2_X_2020-06-18-2300/src/Geometry/CMSCommonData/data/dd4hep/cmsExtendedGeometry2021.xml
Info in <TGeoManager::SetTopVolume>: Top volume is world_volume. Master volume is world_volume
Info in <TGeoNavigator::BuildCache>: --- Maximum geometry depth set to 100
Detector         INFO  *********** Created World volume with size: 10100 10100 45000
DD4CMS           ERROR Exception while processing xml source:file:///data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-06-18-2300/src/Geometry/VeryForwardData/data/RP_Hybrid.xml
DD4CMS           ERROR ----> Cannot find a material referenced by name:RP_Materials:CE7
dd4hep: Error interpreting XML nodes of type <LogicalPart/>
dd4hep: Error interpreting XML nodes of type <LogicalPartSection/>
E

##Failure Location unknown## : Error
Test name: testDDCompactView::checkCompactView
uncaught exception of type std::exception (or derived).
- Cannot find a material referenced by name:RP_Materials:CE7
dd4hep: Error interpreting XML nodes of type <LogicalPart/>
dd4hep: Error interpreting XML nodes of type <LogicalPartSection/>
dd4hep: while parsing /cvmfs/cms-ib.cern.ch/nweek-02633/slc7_amd64_gcc820/cms/c
mssw-patch/CMSSW_11_2_X_2020-06-18-2300/src/Geometry/CMSCommonData/data/dd4hep/
cmsExtendedGeometry2021.xml
dd4hep: with plugin:DD4hep_CompactLoader

Failures !!!
Run: 1   Failure total: 1   Failures: 0   Errors: 1

---> test testDD4hepCompactView had ERRORS

smuzaffar · 2020-06-19T12:42:29Z

@mundim, did you actuall checkout DetectorDescription/DDCMS Geometry/DTGeometryBuilder SimG4Core/DD4hepGeometry while testing locally?

cmsbuild · 2020-06-24T09:50:20Z

The tests are being triggered in jenkins.
Test Parameters:

EXTRA_CMSSW_PACKAGES = Geometry/DTGeometryBuilder,DetectorDescription/DDCMS,SimG4Core/DD4hepGeometry
CMSSW_11_2_X_2020-06-23-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/7313/console Started: 2020/06/24 11:50

cmsbuild · 2020-06-24T10:42:17Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f9f499/7306/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 36
DQMHistoTests: Total histograms compared: 2778811
DQMHistoTests: Total failures: 4
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2778757
DQMHistoTests: Total skipped: 50
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
Checked 152 log files, 16 edm output root files, 36 DQM output files

mundim · 2020-06-24T10:47:44Z

The tests are being triggered in jenkins.
Test Parameters:

* **EXTRA_CMSSW_PACKAGES** = Geometry/DTGeometryBuilder,DetectorDescription/DDCMS,SimG4Core/DD4hepGeometry

* CMSSW_11_2_X_2020-06-23-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/7313/console Started: 2020/06/24 11:50

Sorry, it was not my intention to include these packages in the branch. Is it a problem?

smuzaffar · 2020-06-24T10:54:37Z

No it is not a problem, you did the right thing.
As we know that the unit tests of these 3 cmssw packages depend on the changes of this PR, so we wanted to make sure that PR test actually checkout these packages and run tests. That is why I added the extra test parameter here.

smuzaffar · 2020-06-24T10:55:05Z

by the way, looks like your latest changes have fixed the issue.

cmsbuild · 2020-06-24T11:05:37Z

+1
Tested at: ab431ab
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f9f499/7313/summary.html
CMSSW: CMSSW_11_2_X_2020-06-23-2300
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-06-24T11:05:40Z

Comparison job queued.

ianna · 2020-06-24T11:09:46Z

+1

cmsbuild · 2020-06-24T11:10:09Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

silviodonato · 2020-06-24T11:45:57Z

+1

cmsbuild · 2020-06-24T13:03:37Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f9f499/7313/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 36
DQMHistoTests: Total histograms compared: 2778811
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2778760
DQMHistoTests: Total skipped: 50
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
Checked 152 log files, 16 edm output root files, 36 DQM output files

mundim · 2020-06-24T15:34:59Z

Thanks a lot to everyone who helped on this.

Adding eval=true in ConstantsSection in all PPS xml files

bb06069

cmsbuild added this to the CMSSW_11_2_X milestone Jun 18, 2020

cmsbuild added code-checks-pending comparison-pending geometry-pending orp-pending pending-signatures tests-pending labels Jun 18, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 18, 2020

mundim mentioned this pull request Jun 18, 2020

Including PPS into cmsExtended 2021 #30268

Merged

makortel mentioned this pull request Jun 18, 2020

Several DD4HEP -related unit tests are failing #30298

Closed

cmsbuild added tests-started and removed tests-pending labels Jun 18, 2020

cmsbuild added tests-approved and removed tests-started labels Jun 18, 2020

cvuosalo mentioned this pull request Jun 18, 2020

DD4Hep migration (SolidShapes) for TrackerNumberingBuilder (+TkAl & related CondTool/Geometry plugins) #29905

Merged

cmsbuild added comparison-available and removed comparison-pending labels Jun 18, 2020

cmsbuild mentioned this pull request Jun 19, 2020

[PPS] Timing detector preparation for 2021 conditions #30252

Closed

3 tasks

cmsbuild added the tests-pending label Jun 24, 2020

cmsbuild added tests-started and removed tests-pending labels Jun 24, 2020

cmsbuild added comparison-available and removed comparison-pending labels Jun 24, 2020

cmsbuild added comparison-pending tests-approved and removed comparison-available tests-started labels Jun 24, 2020

cmsbuild added fully-signed geometry-approved and removed geometry-pending pending-signatures labels Jun 24, 2020

cmsbuild added orp-approved and removed orp-pending labels Jun 24, 2020

cmsbuild merged commit f18f5a7 into cms-sw:master Jun 24, 2020

cmsbuild added comparison-available and removed comparison-pending labels Jun 24, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding eval=true in ConstantsSection in all PPS xml files #30292

Adding eval=true in ConstantsSection in all PPS xml files #30292

mundim commented Jun 18, 2020

cmsbuild commented Jun 18, 2020

cmsbuild commented Jun 18, 2020

cmsbuild commented Jun 18, 2020

cvuosalo commented Jun 18, 2020

cmsbuild commented Jun 18, 2020 •

edited

Loading

cmsbuild commented Jun 18, 2020

cmsbuild commented Jun 18, 2020

cmsbuild commented Jun 18, 2020

smuzaffar commented Jun 19, 2020

smuzaffar commented Jun 19, 2020

cmsbuild commented Jun 24, 2020 •

edited

Loading

cmsbuild commented Jun 24, 2020

mundim commented Jun 24, 2020

smuzaffar commented Jun 24, 2020

smuzaffar commented Jun 24, 2020 •

edited

Loading

cmsbuild commented Jun 24, 2020

cmsbuild commented Jun 24, 2020

ianna commented Jun 24, 2020

cmsbuild commented Jun 24, 2020

silviodonato commented Jun 24, 2020

cmsbuild commented Jun 24, 2020

mundim commented Jun 24, 2020

Adding eval=true in ConstantsSection in all PPS xml files #30292

Adding eval=true in ConstantsSection in all PPS xml files #30292

Conversation

mundim commented Jun 18, 2020

PR description:

PR validation:

cmsbuild commented Jun 18, 2020

cmsbuild commented Jun 18, 2020

cmsbuild commented Jun 18, 2020

cvuosalo commented Jun 18, 2020

cmsbuild commented Jun 18, 2020 • edited Loading

cmsbuild commented Jun 18, 2020

cmsbuild commented Jun 18, 2020

cmsbuild commented Jun 18, 2020

smuzaffar commented Jun 19, 2020

smuzaffar commented Jun 19, 2020

cmsbuild commented Jun 24, 2020 • edited Loading

cmsbuild commented Jun 24, 2020

mundim commented Jun 24, 2020

smuzaffar commented Jun 24, 2020

smuzaffar commented Jun 24, 2020 • edited Loading

cmsbuild commented Jun 24, 2020

cmsbuild commented Jun 24, 2020

ianna commented Jun 24, 2020

cmsbuild commented Jun 24, 2020

silviodonato commented Jun 24, 2020

cmsbuild commented Jun 24, 2020

mundim commented Jun 24, 2020

cmsbuild commented Jun 18, 2020 •

edited

Loading

cmsbuild commented Jun 24, 2020 •

edited

Loading

smuzaffar commented Jun 24, 2020 •

edited

Loading