change EcalTPGScale to use esConsumes #30264

JamminJones · 2020-06-16T19:09:04Z

PR description:

changed all modules that used EcalTPGScale to also use esConsumes.

PR validation:

the code compiles

cmsbuild · 2020-06-16T19:09:29Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-06-16T19:15:07Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30264/16186

This PR adds an extra 56KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File CalibCalorimetry/EcalTPGTools/src/EcalTPGScale.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-use-auto #29936
- File L1Trigger/RegionalCaloTrigger/plugins/L1RCTLutWriter.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-use-auto #29936
- File RecoLocalCalo/EcalRecProducers/plugins/EcalRecHitWorkerRecover.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935
- File RecoMET/METFilters/plugins/EcalDeadCellTriggerPrimitiveFilter.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935
- File SimCalorimetry/EcalEBTrigPrimProducers/plugins/EcalEBTrigPrimAnalyzer.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-emplace #29937
- File SimCalorimetry/EcalEBTrigPrimProducers/plugins/EcalEBTrigPrimProducer.cc modified in PR(s): added esConsumes to modules in SimCalorimetry/ EcalEBTrigPrimProducers #30216, [RFC] Test clang-tidy --checks modernize-make-unique #29934
- File SimCalorimetry/EcalEBTrigPrimProducers/plugins/EcalEBTrigPrimProducer.h modified in PR(s): added esConsumes to modules in SimCalorimetry/ EcalEBTrigPrimProducers #30216
- File SimCalorimetry/EcalTrigPrimProducers/plugins/EcalTrigPrimAnalyzer.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-emplace #29937

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30264/16186/code-format.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30264/16186/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2020-06-16T20:15:30Z

The code-checks are being triggered in jenkins.

Dr15Jones · 2020-06-16T20:19:56Z

This change was made under my supervision

cmsbuild · 2020-06-16T20:22:58Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30264/16187

This PR adds an extra 60KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File CalibCalorimetry/EcalTPGTools/src/EcalTPGScale.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-use-auto #29936
- File L1Trigger/RegionalCaloTrigger/plugins/L1RCTLutWriter.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-use-auto #29936
- File RecoLocalCalo/EcalRecProducers/plugins/EcalRecHitWorkerRecover.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935
- File RecoMET/METFilters/plugins/EcalDeadCellTriggerPrimitiveFilter.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935
- File SimCalorimetry/EcalEBTrigPrimProducers/plugins/EcalEBTrigPrimAnalyzer.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-emplace #29937
- File SimCalorimetry/EcalEBTrigPrimProducers/plugins/EcalEBTrigPrimProducer.cc modified in PR(s): added esConsumes to modules in SimCalorimetry/ EcalEBTrigPrimProducers #30216, [RFC] Test clang-tidy --checks modernize-make-unique #29934
- File SimCalorimetry/EcalEBTrigPrimProducers/plugins/EcalEBTrigPrimProducer.h modified in PR(s): added esConsumes to modules in SimCalorimetry/ EcalEBTrigPrimProducers #30216
- File SimCalorimetry/EcalTrigPrimProducers/plugins/EcalTrigPrimAnalyzer.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-emplace #29937

cmsbuild · 2020-06-16T20:23:21Z

A new Pull Request was created by @JamminJones for master.

It involves the following packages:

CalibCalorimetry/EcalTPGTools
L1Trigger/RegionalCaloTrigger
L1TriggerConfig/L1ScalesProducers
RecoLocalCalo/EcalRecProducers
RecoMET/METFilters
SimCalorimetry/EcalEBTrigPrimProducers
SimCalorimetry/EcalTrigPrimProducers

@perrotta, @benkrikler, @slava77, @christopheralanwest, @tocheng, @cmsbuild, @rekovic, @kpedro88, @tlampen, @pohsun, @santocch can you please review it and eventually sign? Thanks.
@jdamgov, @mmarionncern, @gouskos, @jdolen, @rchatter, @apsallid, @rovere, @argiro, @Martin-Grunewald, @ahinzmann, @nhanvtran, @gkasieczka, @tocheng, @thomreis, @schoef, @mmusich, @mariadalfonso, @seemasharmafnal, @clelange this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

Dr15Jones · 2020-06-16T20:25:04Z

please test

cmsbuild · 2020-06-16T20:25:28Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-06-16-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/7115/console Started: 2020/06/16 22:40

cmsbuild · 2020-06-16T21:32:51Z

-1

Tested at: c45c01c

CMSSW: CMSSW_11_2_X_2020-06-16-1100
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-aa0ef7/7115/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

RelVals:

When I ran the RelVals I found an error in the following workflows:
136.8311 step2

runTheMatrix-results/136.8311_RunJetHT2017F_reminiaod+RunJetHT2017F_reminiaod+REMINIAOD_data2017+HARVEST2017_REMINIAOD_data2017/step2_RunJetHT2017F_reminiaod+RunJetHT2017F_reminiaod+REMINIAOD_data2017+HARVEST2017_REMINIAOD_data2017.log

136.88811 step2

runTheMatrix-results/136.88811_RunJetHT2018D_reminiaodUL+RunJetHT2018D_reminiaodUL+REMINIAOD_data2018UL+HARVEST2018_REMINIAOD_data2018UL/step2_RunJetHT2018D_reminiaodUL+RunJetHT2018D_reminiaodUL+REMINIAOD_data2018UL+HARVEST2018_REMINIAOD_data2018UL.log

136.7611 step2

runTheMatrix-results/136.7611_RunJetHT2016E_reminiaod+RunJetHT2016E_reminiaod+REMINIAOD_data2016_HIPM+HARVESTDR2_REMINIAOD_data2016_HIPM/step2_RunJetHT2016E_reminiaod+RunJetHT2016E_reminiaod+REMINIAOD_data2016_HIPM+HARVESTDR2_REMINIAOD_data2016_HIPM.log

4.53 step3

runTheMatrix-results/4.53_RunPhoton2012B+RunPhoton2012B+HLTD+RECODR1reHLT+HARVESTDR1reHLT/step3_RunPhoton2012B+RunPhoton2012B+HLTD+RECODR1reHLT+HARVESTDR1reHLT.log

135.4 step3

runTheMatrix-results/135.4_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS/step3_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS.log

140.56 step2

runTheMatrix-results/140.56_RunHI2018+RunHI2018+RECOHID18+HARVESTDHI18/step2_RunHI2018+RunHI2018+RECOHID18+HARVESTDHI18.log

136.731 step3

runTheMatrix-results/136.731_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT_skimSinglePh_HIPM+HARVESTDR2/step3_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT_skimSinglePh_HIPM+HARVESTDR2.log

136.793 step3

runTheMatrix-results/136.793_RunDoubleEG2017C+RunDoubleEG2017C+HLTDR2_2017+RECODR2_2017reHLT_skimDoubleEG_Prompt+HARVEST2017/step3_RunDoubleEG2017C+RunDoubleEG2017C+HLTDR2_2017+RECODR2_2017reHLT_skimDoubleEG_Prompt+HARVEST2017.log

136.874 step3

runTheMatrix-results/136.874_RunEGamma2018C+RunEGamma2018C+HLTDR2_2018+RECODR2_2018reHLT_skimEGamma_Offline_L1TEgDQM+HARVEST2018_L1TEgDQM/step3_RunEGamma2018C+RunEGamma2018C+HLTDR2_2018+RECODR2_2018reHLT_skimEGamma_Offline_L1TEgDQM+HARVEST2018_L1TEgDQM.log

1001.0 step2

runTheMatrix-results/1001.0_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVDSIPIXELCALRUN1+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4+ALCAHARVD5/step2_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVDSIPIXELCALRUN1+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4+ALCAHARVD5.log

1000.0 step2

runTheMatrix-results/1000.0_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT/step2_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT.log

9.0 step3

runTheMatrix-results/9.0_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST/step3_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST.log

1306.0 step3

runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15/step3_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15.log

25.0 step3

runTheMatrix-results/25.0_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT/step3_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT.log

1330.0 step3

runTheMatrix-results/1330.0_ZMM_13+ZMM_13+DIGIUP15+RECOUP15_L1TMuDQM+HARVESTUP15_L1TMuDQM+NANOUP15/step3_ZMM_13+ZMM_13+DIGIUP15+RECOUP15_L1TMuDQM+HARVESTUP15_L1TMuDQM+NANOUP15.log

10042.0 step3

runTheMatrix-results/10042.0_ZMM_13+ZMM_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017+ALCAFull_2017+NanoFull_2017/step3_ZMM_13+ZMM_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017+ALCAFull_2017+NanoFull_2017.log

158.0 step3

runTheMatrix-results/158.0_HydjetQ_B12_5020GeV_2018_ppReco+HydjetQ_B12_5020GeV_2018_ppReco+DIGIHI2018PPRECO+RECOHI2018PPRECO+ALCARECOHI2018PPRECO+HARVESTHI2018PPRECO/step3_HydjetQ_B12_5020GeV_2018_ppReco+HydjetQ_B12_5020GeV_2018_ppReco+DIGIHI2018PPRECO+RECOHI2018PPRECO+ALCARECOHI2018PPRECO+HARVESTHI2018PPRECO.log

23234.1001 step1

runTheMatrix-results/23234.1001_TTbar_14TeV+RecoFullGlobal_TestOldDigi_2026D49+HARVESTFullGlobal_2026D49/step1_TTbar_14TeV+RecoFullGlobal_TestOldDigi_2026D49+HARVESTFullGlobal_2026D49.log

10024.0 step3

runTheMatrix-results/10024.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017+ALCAFull_2017+NanoFull_2017/step3_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017+ALCAFull_2017+NanoFull_2017.log

10824.0 step3

runTheMatrix-results/10824.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+HARVESTFull_2018+ALCAFull_2018+NanoFull_2018/step3_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+HARVESTFull_2018+ALCAFull_2018+NanoFull_2018.log

25202.0 step3

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25+NANOUP15_PU25/step3_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25+NANOUP15_PU25.log

12434.0 step3

runTheMatrix-results/12434.0_TTbar_14TeV+TTbar_14TeV_TuneCP5_2023_GenSimFull+DigiFull_2023+RecoFull_2023+HARVESTFull_2023+ALCAFull_2023/step3_TTbar_14TeV+TTbar_14TeV_TuneCP5_2023_GenSimFull+DigiFull_2023+RecoFull_2023+HARVESTFull_2023+ALCAFull_2023.log

11634.0 step3

runTheMatrix-results/11634.0_TTbar_14TeV+TTbar_14TeV_TuneCP5_2021_GenSimFull+DigiFull_2021+RecoFull_2021+HARVESTFull_2021+ALCAFull_2021/step3_TTbar_14TeV+TTbar_14TeV_TuneCP5_2021_GenSimFull+DigiFull_2021+RecoFull_2021+HARVESTFull_2021+ALCAFull_2021.log

10224.0 step3

runTheMatrix-results/10224.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017PU_GenSimFull+DigiFullPU_2017PU+RecoFullPU_2017PU+HARVESTFullPU_2017PU+NanoFull_2017PU/step3_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017PU_GenSimFull+DigiFullPU_2017PU+RecoFullPU_2017PU+HARVESTFullPU_2017PU+NanoFull_2017PU.log

20034.0 step3

runTheMatrix-results/20034.0_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D35_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D35+RecoFullGlobal_2026D35+HARVESTFullGlobal_2026D35/step3_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D35_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D35+RecoFullGlobal_2026D35+HARVESTFullGlobal_2026D35.log

20434.0 step3

runTheMatrix-results/20434.0_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D41_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D41+RecoFullGlobal_2026D41+HARVESTFullGlobal_2026D41/step3_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D41_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D41+RecoFullGlobal_2026D41+HARVESTFullGlobal_2026D41.log

23234.0 step3

runTheMatrix-results/23234.0_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D49_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D49+RecoFullGlobal_2026D49+HARVESTFullGlobal_2026D49/step3_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D49_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D49+RecoFullGlobal_2026D49+HARVESTFullGlobal_2026D49.log

21234.0 step3

runTheMatrix-results/21234.0_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D44_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D44+RecoFullGlobal_2026D44+HARVESTFullGlobal_2026D44/step3_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D44_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D44+RecoFullGlobal_2026D44+HARVESTFullGlobal_2026D44.log

250202.181 step4

runTheMatrix-results/250202.181_TTbar_13UP18+TTbar_13UP18+PREMIXUP18_PU25+DIGIPRMXLOCALUP18_PU25+RECOPRMXUP18_PU25+HARVESTUP18_PU25/step4_TTbar_13UP18+TTbar_13UP18+PREMIXUP18_PU25+DIGIPRMXLOCALUP18_PU25+RECOPRMXUP18_PU25+HARVESTUP18_PU25.log

cmsbuild · 2020-06-16T21:32:53Z

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

cmsbuild · 2020-06-18T23:33:47Z

-1

Tested at: 6724f8c

CMSSW: CMSSW_11_2_X_2020-06-18-1100
SCRAM_ARCH: slc7_amd64_gcc820

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

added esConsumes to modules in L1Trigger/CSCTrackFinder #30149 @JamminJones: added esConsumes to modules in L1Trigger/CSCTrackFinder
added esConsumes to modules in L1Trigger/CSCTriggerPrimitives #30148 @JamminJones: added esConsumes to modules in L1Trigger/CSCTriggerPrimitives
added esConsumes to modules in SimCalorimetry/ EcalEBTrigPrimProducers #30216 @JamminJones: added esConsumes to modules in SimCalorimetry/ EcalEBTrigPrimProducers
add phase2_ecal to internalUseMods #30265 @kpedro88: add phase2_ecal to internalUseMods
added esConsumes to modules in EventFIlter/GEMRawToDigi #30279 @JamminJones: added esConsumes to modules in EventFIlter/GEMRawToDigi
Add SA checker to report calls to edm::eventsetup::EventSetupRecord::<>get() function template instantiations. #30285 @gartung: Add SA checker to report calls to edm::eventsetup::EventSetupRecord::<>get() function template instantiations.
Correct 2018 HEfail GT and correct GT naming #30286 @christopheralanwest: Correct 2018 HEfail GT and correct GT naming

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-aa0ef7/7194/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-aa0ef7/7194/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-aa0ef7/7194/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

Unit Tests:

I found errors in the following unit tests:

---> test testDD4hepFilteredView had ERRORS
---> test testDD4hepCompactView had ERRORS
---> test testDD4hepExpandedView had ERRORS
---> test DetectorDescriptionDDCMSTestDriver had ERRORS

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

added esConsumes to modules in L1Trigger/CSCTrackFinder #30149 @JamminJones: added esConsumes to modules in L1Trigger/CSCTrackFinder
added esConsumes to modules in L1Trigger/CSCTriggerPrimitives #30148 @JamminJones: added esConsumes to modules in L1Trigger/CSCTriggerPrimitives
added esConsumes to modules in SimCalorimetry/ EcalEBTrigPrimProducers #30216 @JamminJones: added esConsumes to modules in SimCalorimetry/ EcalEBTrigPrimProducers
add phase2_ecal to internalUseMods #30265 @kpedro88: add phase2_ecal to internalUseMods
added esConsumes to modules in EventFIlter/GEMRawToDigi #30279 @JamminJones: added esConsumes to modules in EventFIlter/GEMRawToDigi
Add SA checker to report calls to edm::eventsetup::EventSetupRecord::<>get() function template instantiations. #30285 @gartung: Add SA checker to report calls to edm::eventsetup::EventSetupRecord::<>get() function template instantiations.
Correct 2018 HEfail GT and correct GT naming #30286 @christopheralanwest: Correct 2018 HEfail GT and correct GT naming

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-aa0ef7/7194/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-aa0ef7/7194/git-merge-result

cmsbuild · 2020-06-18T23:33:50Z

Comparison job queued.

cmsbuild · 2020-06-19T04:46:24Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-aa0ef7/7194/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 36
DQMHistoTests: Total histograms compared: 2778811
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2778760
DQMHistoTests: Total skipped: 50
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
Checked 152 log files, 16 edm output root files, 36 DQM output files

Dr15Jones · 2020-06-19T11:52:42Z

The unit test failures are unrelated to this pull request because the same failures are happening in the IBs.

slava77 · 2020-06-21T19:16:56Z

+1

for #30264 6724f8c

technical; after some discussion, the suboptimal update in EcalRecHitWorkerRecover::run was considered acceptable
jenkins tests pass for what's related to this PR updates

kpedro88 · 2020-06-22T13:18:14Z

+upgrade

Dr15Jones · 2020-06-22T14:53:09Z

ping

silviodonato · 2020-06-26T12:50:15Z

merge
alca: @pohsun @tlampen @tocheng @christopheralanwest
l1: @benkrikler @rekovic
analysis: @santocch
please have a look

santocch · 2020-06-27T06:27:15Z

+1

tlampen · 2020-06-29T09:49:28Z

+1

cmsbuild added this to the CMSSW_11_2_X milestone Jun 16, 2020

cmsbuild added alca-pending analysis-pending code-checks-pending comparison-pending l1-pending orp-pending pending-signatures reconstruction-pending tests-pending upgrade-pending labels Jun 16, 2020

cmsbuild added code-checks-rejected code-checks-pending and removed code-checks-pending code-checks-rejected labels Jun 16, 2020

cmsbuild removed the code-checks-pending label Jun 16, 2020

cmsbuild added the code-checks-approved label Jun 16, 2020

cmsbuild added tests-started and removed tests-pending labels Jun 16, 2020

cmsbuild removed the comparison-pending label Jun 16, 2020

cmsbuild added tests-started and removed tests-pending labels Jun 18, 2020

cmsbuild added tests-rejected and removed tests-started labels Jun 18, 2020

cmsbuild added comparison-available and removed comparison-pending labels Jun 19, 2020

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Jun 21, 2020

cmsbuild added upgrade-approved and removed upgrade-pending labels Jun 22, 2020

cmsbuild added orp-approved and removed orp-pending labels Jun 26, 2020

cmsbuild merged commit 30055ab into cms-sw:master Jun 26, 2020

This was referenced Jun 27, 2020

[NanoAOD] Don't handle column types redundantly anymore #30436

Merged

RecoVertex/PrimaryVertexProducer: Attempt auto-vectorization of additional loops in DAClusterizerInZ_vect.cc and DAClusterizerInZT_vect.cc #30437

Merged

cmsbuild added analysis-approved and removed analysis-pending labels Jun 27, 2020

cmsbuild added alca-approved and removed alca-pending labels Jun 29, 2020

JamminJones deleted the EcalTPGScaleReform branch July 27, 2020 19:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

change EcalTPGScale to use esConsumes #30264

change EcalTPGScale to use esConsumes #30264

JamminJones commented Jun 16, 2020

cmsbuild commented Jun 16, 2020

cmsbuild commented Jun 16, 2020

cmsbuild commented Jun 16, 2020

Dr15Jones commented Jun 16, 2020

cmsbuild commented Jun 16, 2020

cmsbuild commented Jun 16, 2020

Dr15Jones commented Jun 16, 2020

cmsbuild commented Jun 16, 2020 •

edited

Loading

cmsbuild commented Jun 16, 2020

cmsbuild commented Jun 16, 2020

cmsbuild commented Jun 18, 2020

cmsbuild commented Jun 18, 2020

cmsbuild commented Jun 19, 2020

Dr15Jones commented Jun 19, 2020

slava77 commented Jun 21, 2020

kpedro88 commented Jun 22, 2020

Dr15Jones commented Jun 22, 2020

silviodonato commented Jun 26, 2020

santocch commented Jun 27, 2020

tlampen commented Jun 29, 2020

change EcalTPGScale to use esConsumes #30264

change EcalTPGScale to use esConsumes #30264

Conversation

JamminJones commented Jun 16, 2020

PR description:

PR validation:

cmsbuild commented Jun 16, 2020

cmsbuild commented Jun 16, 2020

cmsbuild commented Jun 16, 2020

Dr15Jones commented Jun 16, 2020

cmsbuild commented Jun 16, 2020

cmsbuild commented Jun 16, 2020

Dr15Jones commented Jun 16, 2020

cmsbuild commented Jun 16, 2020 • edited Loading

cmsbuild commented Jun 16, 2020

cmsbuild commented Jun 16, 2020

cmsbuild commented Jun 18, 2020

cmsbuild commented Jun 18, 2020

cmsbuild commented Jun 19, 2020

Dr15Jones commented Jun 19, 2020

slava77 commented Jun 21, 2020

kpedro88 commented Jun 22, 2020

Dr15Jones commented Jun 22, 2020

silviodonato commented Jun 26, 2020

santocch commented Jun 27, 2020

tlampen commented Jun 29, 2020

cmsbuild commented Jun 16, 2020 •

edited

Loading