Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added esConsumes to modules in L1Trigger/CSCTriggerPrimitives #30148

Merged

Conversation

JamminJones
Copy link
Contributor

PR description:

added esConsumes to 3 modules

PR validation:

the code compiles

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2020

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30148/15932

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2020

A new Pull Request was created by @JamminJones for master.

It involves the following packages:

L1Trigger/CSCTriggerPrimitives

@cmsbuild, @rekovic, @benkrikler can you please review it and eventually sign? Thanks.
@valuev, @Martin-Grunewald, @ptcox, @dildick this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor

This was done under my supervision.

@Dr15Jones
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6882/console Started: 2020/06/08 17:31

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2020

+1
Tested at: 164281d
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1fa1bc/6882/summary.html
CMSSW: CMSSW_11_2_X_2020-06-08-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1fa1bc/6882/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2780497
  • DQMHistoTests: Total failures: 42
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2780405
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 152 log files, 16 edm output root files, 36 DQM output files

@silviodonato
Copy link
Contributor

kind reminder @rekovic

@silviodonato
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 077fe0c into cms-sw:master Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants