Reduce boost dependency in Utilities/XrdAdaptor

[camolezi]

PR description:

Removed the boost::noncopyable inheritance, and deleted copy constructor and copy operation instead.
The code should have the same behavior.

PR validation:

Passed on basic runTheMatrix test.

if this PR is a backport please specify the original PR and why you need to backport that PR:

@vgvassilev @davidlange6

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30262/16183

• This PR adds an extra 36KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Utilities/XrdAdaptor/src/XrdRequest.h modified in PR(s): [RFC] Test clang-tidy --checks performance-unnecessary-value-param #29933
  • File Utilities/XrdAdaptor/src/XrdRequestManager.cc modified in PR(s): [RFC] Test clang-tidy --checks performance-faster-string-find #29926, [RFC] Test clang-tidy --checks performance-move-const-arg #29931, [RFC] Test clang-tidy --checks performance-unnecessary-value-param #29933, [RFC] Test clang-tidy --checks modernize-make-unique #29934
  • File Utilities/XrdAdaptor/src/XrdRequestManager.h modified in PR(s): [RFC] Test clang-tidy --checks performance-unnecessary-value-param #29933
  • File Utilities/XrdAdaptor/src/XrdSource.cc modified in PR(s): [RFC] Test clang-tidy --checks performance-faster-string-find #29926, [RFC] Test clang-tidy --checks performance-unnecessary-value-param #29933, [RFC] Test clang-tidy --checks modernize-make-unique #29934
  • File Utilities/XrdAdaptor/src/XrdSource.h modified in PR(s): [RFC] Test clang-tidy --checks performance-unnecessary-value-param #29933

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30262/16183/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30262/16183/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30262/16184

• This PR adds an extra 36KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Utilities/XrdAdaptor/src/XrdRequest.h modified in PR(s): [RFC] Test clang-tidy --checks performance-unnecessary-value-param #29933
  • File Utilities/XrdAdaptor/src/XrdRequestManager.cc modified in PR(s): [RFC] Test clang-tidy --checks performance-faster-string-find #29926, [RFC] Test clang-tidy --checks performance-move-const-arg #29931, [RFC] Test clang-tidy --checks performance-unnecessary-value-param #29933, [RFC] Test clang-tidy --checks modernize-make-unique #29934
  • File Utilities/XrdAdaptor/src/XrdRequestManager.h modified in PR(s): [RFC] Test clang-tidy --checks performance-unnecessary-value-param #29933
  • File Utilities/XrdAdaptor/src/XrdSource.cc modified in PR(s): [RFC] Test clang-tidy --checks performance-faster-string-find #29926, [RFC] Test clang-tidy --checks performance-unnecessary-value-param #29933, [RFC] Test clang-tidy --checks modernize-make-unique #29934
  • File Utilities/XrdAdaptor/src/XrdSource.h modified in PR(s): [RFC] Test clang-tidy --checks performance-unnecessary-value-param #29933

[cmsbuild]

A new Pull Request was created by @camolezi (Lucas Camolezi) for master.

It involves the following packages:

Utilities/XrdAdaptor

@makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please review it and eventually sign? Thanks.
@makortel, @wddgit this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

[makortel]

@cmsbuild, please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-06-16-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/7112/console Started: 2020/06/16 20:04

[cmsbuild]

+1
Tested at: 578e66d
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d4fe17/7112/summary.html
CMSSW: CMSSW_11_2_X_2020-06-16-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d4fe17/7112/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 36
• DQMHistoTests: Total histograms compared: 2778811
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2778754
• DQMHistoTests: Total skipped: 50
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
• Checked 152 log files, 16 edm output root files, 36 DQM output files

[silviodonato]

kind reminder

[makortel]

+1

Apologies, somehow fell under the radar...

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1