[RFC] Test clang-tidy --checks performance-move-const-arg

[fwyzard]

See the description at https://clang.llvm.org/extra/clang-tidy/checks/performance-move-const-arg.html .

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

ERROR: Build errors found during clang-tidy run.

DataFormats/Common/interface/Wrapper.h:92:80: error: no matching constructor for initialization of 'MkFitInputWrapper' [clang-diagnostic-error]
  Wrapper<T>::Wrapper(Emplace, Args&&... args) : WrapperBase(), present(true), obj(std::forward<Args>(args)...) {}
                                                                               ^
FWCore/Framework/interface/Event.h:448:43: note: in instantiation of function template specialization 'edm::Wrapper<MkFitInputWrapper>::Wrapper<MkFitHitIndexMap, std::vector<std::vector<mkfit::Hit, std::allocator<mkfit::Hit> >, std::allocator<std::vector<mkfit::Hit, std::allocator<mkfit::Hit> > > >, std::vector<mkfit::Track, std::allocator<mkfit::Track> >, mkfit::LayerNumberConverter &>' requested here
--
gmake: *** [config/SCRAM/GMake/Makefile.coderules:128: code-checks] Error 2
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2

[slava77]

+1
(no significant objections/concerns)

it looks like this better not be automated

[santocch]

+1

[pohsun]

+1

[alja]

+1

[mrodozov]

@fwyzard what we wanted to do with this, could you remind me

[fwyzard]

This should go in - it's mostly signed, and it actually helped find bugs in our code.

[jfernan2]

+1

[kpedro88]

+upgrade