-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DD4hep] Update DD4hep 2021 Scenario #30208
Conversation
@slomeo - FYI |
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30208/16062
|
A new Pull Request was created by @ianna (Ianna Osborne) for master. It involves the following packages: Geometry/CMSCommonData @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@ianna : no, it is't. I'm talking about a histo problem of the RPC Position (i.e please see chat on Skype 10/06/2020) |
please test |
The tests are being triggered in jenkins.
|
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
+upgrade |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2) |
The PR is outdated. This scenario is generated automatically from a dictionary as of #30214. The diff between the two is here just for the record: <<<<<<< dd4hep-scenario-sync-with-2021-v1
<Include ref="Geometry/VeryForwardData/data/pps/2021/v1/pps.xml"/>
<Include ref="Geometry/ForwardCommonData/data/forward/2021/v1/forward.xml"/>
<Include ref="Geometry/ForwardCommonData/data/totemt2/2021/v1/totemt2.xml"/>
=======
<Include ref='Geometry/MuonCommonData/data/muonNumbering/2021/v2/muonNumbering.xml'/>
<Include ref='Geometry/ForwardCommonData/data/forward/2021/v1/forward.xml'/>
<Include ref='Geometry/ForwardCommonData/data/totemt2/2021/v1/totemt2.xml'/>
>>>>>>> master
|
PR description:
PR validation:
if this PR is a backport please specify the original PR and why you need to backport that PR:
Before submitting your pull requests, make sure you followed this checklist: