Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DD4hep] Update DD4hep 2021 Scenario #30208

Closed
wants to merge 1 commit into from

Conversation

ianna
Copy link
Contributor

@ianna ianna commented Jun 12, 2020

PR description:

  • Updates to the scenario are taken from from the 2021 production scenario

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

Before submitting your pull requests, make sure you followed this checklist:

@cmsbuild cmsbuild added this to the CMSSW_11_2_X milestone Jun 12, 2020
@ianna
Copy link
Contributor Author

ianna commented Jun 12, 2020

@slomeo - FYI

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@slomeo
Copy link
Contributor

slomeo commented Jun 12, 2020

@ianna : is this PR related to the probelm with RPC chambers present in #30121 ?

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30208/16062

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ianna (Ianna Osborne) for master.

It involves the following packages:

Geometry/CMSCommonData

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks.
@fabiocos, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@ianna
Copy link
Contributor Author

ianna commented Jun 12, 2020

@ianna : is this PR related to the probelm with RPC chambers present in #30121 ?

@slomeo - what is the problem with RPCs? Comparison differences?

@slomeo
Copy link
Contributor

slomeo commented Jun 12, 2020

@ianna : no, it is't. I'm talking about a histo problem of the RPC Position (i.e please see chat on Skype 10/06/2020)

@ianna
Copy link
Contributor Author

ianna commented Jun 14, 2020

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 14, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+1
Tested at: 4c5115b
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8831a6/7041/summary.html
CMSSW: CMSSW_11_2_X_2020-06-13-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8831a6/7041/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2778811
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2778760
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 152 log files, 16 edm output root files, 36 DQM output files

@cvuosalo
Copy link
Contributor

+1

@kpedro88
Copy link
Contributor

kpedro88 commented Jun 16, 2020

+upgrade

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

@ianna this PR is in conflict with your #30214

@ianna
Copy link
Contributor Author

ianna commented Jun 17, 2020

The PR is outdated. This scenario is generated automatically from a dictionary as of #30214.

The diff between the two is here just for the record:

<<<<<<< dd4hep-scenario-sync-with-2021-v1
    <Include ref="Geometry/VeryForwardData/data/pps/2021/v1/pps.xml"/>
    <Include ref="Geometry/ForwardCommonData/data/forward/2021/v1/forward.xml"/>
    <Include ref="Geometry/ForwardCommonData/data/totemt2/2021/v1/totemt2.xml"/>
=======
    <Include ref='Geometry/MuonCommonData/data/muonNumbering/2021/v2/muonNumbering.xml'/>
    <Include ref='Geometry/ForwardCommonData/data/forward/2021/v1/forward.xml'/>
    <Include ref='Geometry/ForwardCommonData/data/totemt2/2021/v1/totemt2.xml'/>
>>>>>>> master

@ianna ianna closed this Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants