Update of the RPC migration to DD4hep

[slomeo]

PR description:

Update the RPC migration to DD4hep after @bsunanda PRs #29842 #29943 and @ianna PR #29954.

PR validation:

1. validation made by Geometry/RPCGeometryBuilder/test/python/validateRPCGeometry_cfg.py

2. validation by runTheMatrix.py -l 25202.1 :

25202.1_TTbar_13+TTbar_13+DIGIUP15APVSimu_PU25+RECOUP15_PU25+HARVESTUP15_PU25 Step0-PASSED Step1-PASSED Step2-PASSED Step3-PASSED - time date Fri May 29 17:36:47 2020-date Fri May 29 17:15:13 2020; exit: 0 0 0 0
1 1 1 1 tests passed, 0 0 0 0 failed

if this PR is a backport please specify the original PR and why you need to backport that PR:

nothing special

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30121/15891

• This PR adds an extra 28KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File DetectorDescription/DDCMS/data/cms-geometry-2021.xml modified in PR(s): [DD4hep] Tests Cleanup and 2021 Production Scenario Update #30093

[cmsbuild]

A new Pull Request was created by @slomeo (Sergio Lo Meo) for master.

It involves the following packages:

DetectorDescription/DDCMS
Geometry/MuonNumbering
Geometry/RPCGeometryBuilder
RecoLocalMuon/GEMRecHit

@perrotta, @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88, @slava77 can you please review it and eventually sign? Thanks.
@vargasa, @jhgoh, @jshlee, @bellan, @ptcox, @fabiocos this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

[perrotta]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6838/console Started: 2020/06/05 10:01

[cmsbuild]

+1
Tested at: c4a0628
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8ebff0/6838/summary.html
CMSSW: CMSSW_11_2_X_2020-06-04-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8ebff0/6838/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 7821 differences found in the comparisons
• DQMHistoTests: Total files compared: 36
• DQMHistoTests: Total histograms compared: 2783960
• DQMHistoTests: Total failures: 14600
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2769310
• DQMHistoTests: Total skipped: 50
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
• Checked 152 log files, 16 edm output root files, 36 DQM output files

[kpedro88]

The comparison shows a lot of changes that I don't think are expected.

[slomeo]

@kpedro88 7821 differences found in the comparisons?

[perrotta]

please abort

[perrotta]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6987/console Started: 2020/06/12 15:23

[cmsbuild]

+1
Tested at: f254610
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8ebff0/6987/summary.html
CMSSW: CMSSW_11_2_X_2020-06-12-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8ebff0/6987/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 36
• DQMHistoTests: Total histograms compared: 2778811
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2778760
• DQMHistoTests: Total skipped: 50
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
• Checked 152 log files, 16 edm output root files, 36 DQM output files

[cvuosalo]

+1

[perrotta]

+1

• Changes in reco files are technical and consequent to the updates in Geometry
• Jenkins tests pass

[slomeo]

@kpedro88 the comparison now is ok, do you see other problems in this PR?

[kpedro88]

+upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1