Update of the RPC migration to DD4hep #30047

slomeo · 2020-05-29T16:00:31Z

PR description:

Update the RPC migration to DD4hep after @bsunanda PRs #29842 #29943 and @ianna PR #29954.

PR validation:

validation made by Geometry/RPCGeometryBuilder/test/python/validateRPCGeometry_cfg.py
validation by runTheMatrix.py -l 25202.1

25202.1_TTbar_13+TTbar_13+DIGIUP15APVSimu_PU25+RECOUP15_PU25+HARVESTUP15_PU25 Step0-PASSED Step1-PASSED Step2-PASSED Step3-PASSED - time date Fri May 29 17:36:47 2020-date Fri May 29 17:15:13 2020; exit: 0 0 0 0
1 1 1 1 tests passed, 0 0 0 0 failed

if this PR is a backport please specify the original PR and why you need to backport that PR:

nothing special

cmsbuild · 2020-05-29T16:00:59Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-05-29T16:05:27Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30047/15752

This PR adds an extra 20KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30047/15752/code-format.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30047/15752/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2020-05-29T16:09:08Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-05-29T16:13:35Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30047/15753

This PR adds an extra 20KB to repository

cmsbuild · 2020-05-29T16:13:55Z

A new Pull Request was created by @slomeo (Sergio Lo Meo) for master.

It involves the following packages:

Geometry/RPCGeometryBuilder
RecoLocalMuon/GEMRecHit

@perrotta, @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88, @slava77 can you please review it and eventually sign? Thanks.
@jshlee, @bellan, @fabiocos, @jhgoh this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

kpedro88 · 2020-05-29T16:30:13Z

please test

cmsbuild · 2020-05-29T16:30:36Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6694/console Started: 2020/05/29 18:31

cmsbuild · 2020-05-29T17:43:41Z

+1
Tested at: c2b0d2d
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3104a3/6694/summary.html
CMSSW: CMSSW_11_2_X_2020-05-29-1100
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-05-29T17:43:44Z

Comparison job queued.

cmsbuild · 2020-06-04T07:48:46Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-06-04T07:54:04Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30047/15854

This PR adds an extra 72KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/Geometry/python/GeometryDD4hepExtended2021_cff.py modified in PR(s): [DD4hep] Tests Cleanup and 2021 Production Scenario Update #30093
- File DetectorDescription/DDCMS/data/cms-geometry-2021.xml modified in PR(s): [DD4hep] Tests Cleanup and 2021 Production Scenario Update #30093
- File Geometry/CMSCommonData/data/dd4hep/cmsExtendedGeometry2021.xml modified in PR(s): [DD4hep] Tests Cleanup and 2021 Production Scenario Update #30093

cmsbuild · 2020-06-04T07:54:32Z

Pull request #30047 was updated. @perrotta, @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88, @slava77 can you please check and sign again.

perrotta · 2020-06-04T09:29:32Z

please test

cmsbuild · 2020-06-04T09:30:03Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6802/console Started: 2020/06/04 11:32

cmsbuild · 2020-06-04T10:46:18Z

-1

Tested at: b2790b1

CMSSW: CMSSW_11_2_X_2020-06-03-2300
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3104a3/6802/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

Unit Tests:

I found errors in the following unit tests:

---> test testDD4hepFilteredView had ERRORS
---> test DetectorDescriptionDDCMSTestDriver had ERRORS

cmsbuild · 2020-06-04T10:46:21Z

Comparison job queued.

slomeo · 2020-06-04T10:59:28Z

@ianna @cvuosalo looking at https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3104a3/6802/summary.html it seems that there is a problem related to cms-geometry-2021.xml. I deleted this file so I think it is necessary to update some scripts. Am I correct? If I'm correct, can you please take care of it?

cmsbuild · 2020-06-04T13:45:30Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3104a3/6802/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 7462 differences found in the comparisons
DQMHistoTests: Total files compared: 36
DQMHistoTests: Total histograms compared: 2783946
DQMHistoTests: Total failures: 17033
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2766863
DQMHistoTests: Total skipped: 50
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
Checked 152 log files, 16 edm output root files, 36 DQM output files

ianna · 2020-06-04T16:34:14Z

@ianna @cvuosalo looking at https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3104a3/6802/summary.html it seems that there is a problem related to cms-geometry-2021.xml. I deleted this file so I think it is necessary to update some scripts. Am I correct? If I'm correct, can you please take care of it?

@slomeo - what I was asking is to remove your changes to Geometry/CMSCommonData/data/dd4hep/cmsExtendedGeometry2021.xml and Configuration/Geometry/python/GeometryDD4hepExtended2021_cff.py in this PR.

ianna · 2020-06-04T16:35:01Z

Configuration/Geometry/python/GeometryDD4hepExtended2021_cff.py

@@ -5,7 +5,7 @@
 #
 # Ideal geometry, needed for simulation
 DDDetectorESProducer = cms.ESSource("DDDetectorESProducer",
-                                    confGeomXMLFiles = cms.FileInPath('DetectorDescription/DDCMS/data/cms-geometry-2021.xml'),
+                                    confGeomXMLFiles = cms.FileInPath('Geometry/CMSCommonData/data/dd4hep/cmsExtendedGeometry2021.xml'),


please, remove modifications to this file from your PR

ianna · 2020-06-04T16:35:33Z

DetectorDescription/DDCMS/data/cms-geometry-2021.xml

@@ -1,308 +0,0 @@
-<?xml version="1.0"?>


please, do not delete it in this PR

ianna · 2020-06-04T16:36:13Z

Geometry/CMSCommonData/data/dd4hep/cmsExtendedGeometry2021.xml

@@ -4,286 +4,286 @@
  <close_geometry/>

  <IncludeSection>
-    <Include ref="Geometry/CMSCommonData/data/materials/2021/v1/materials.xml"/>


please, remove modifications to this file from this PR

slomeo · 2020-06-04T16:46:23Z

@ianna do you mean a "git restore"?

kpedro88 · 2020-06-04T16:55:39Z

@slomeo 'git restore' is not the right command. You should 'git revert' the commit in which you removed the file, additionally undo any changes you previously made to the files mentioned by @ianna, and then squash the commits in this PR to avoid churn in the history and blame.

slomeo · 2020-06-05T07:25:28Z

@ianna @kpedro88 I think it's better to re-start with a new PR in a clean IB. I'll close this PR and I'll make a new PR asap.

slomeo · 2020-06-05T07:37:50Z

I made a new PR, please look to #30121

slomeo added 3 commits May 29, 2020 16:45

Update RPC migration to DD4hep first step

47bff09

Update RPC migration to DD4hep final step

ce95aef

Update RPC Migration to DD4hep final step + new Builder Files

02cb9f8

cmsbuild added this to the CMSSW_11_2_X milestone May 29, 2020

cmsbuild added code-checks-pending comparison-pending geometry-pending orp-pending pending-signatures reconstruction-pending tests-pending upgrade-pending labels May 29, 2020

cmsbuild added code-checks-rejected and removed code-checks-pending labels May 29, 2020

code format performed

c2b0d2d

cmsbuild added code-checks-pending and removed code-checks-rejected labels May 29, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels May 29, 2020

cmsbuild added tests-started and removed tests-pending labels May 29, 2020

cmsbuild added code-checks-pending comparison-pending tests-pending and removed code-checks-approved comparison-available tests-approved labels Jun 4, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 4, 2020

cmsbuild added tests-started and removed tests-pending labels Jun 4, 2020

cmsbuild added tests-rejected and removed tests-started labels Jun 4, 2020

cmsbuild added comparison-available and removed comparison-pending labels Jun 4, 2020

ianna suggested changes Jun 4, 2020

View reviewed changes

slomeo closed this Jun 5, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update of the RPC migration to DD4hep #30047

Update of the RPC migration to DD4hep #30047

slomeo commented May 29, 2020 •

edited

Loading

cmsbuild commented May 29, 2020

cmsbuild commented May 29, 2020

cmsbuild commented May 29, 2020

cmsbuild commented May 29, 2020

cmsbuild commented May 29, 2020

kpedro88 commented May 29, 2020

cmsbuild commented May 29, 2020 •

edited

Loading

cmsbuild commented May 29, 2020

cmsbuild commented May 29, 2020

cmsbuild commented Jun 4, 2020

cmsbuild commented Jun 4, 2020

cmsbuild commented Jun 4, 2020

perrotta commented Jun 4, 2020

cmsbuild commented Jun 4, 2020 •

edited

Loading

cmsbuild commented Jun 4, 2020

cmsbuild commented Jun 4, 2020

slomeo commented Jun 4, 2020

cmsbuild commented Jun 4, 2020

ianna commented Jun 4, 2020

ianna Jun 4, 2020

ianna Jun 4, 2020

ianna Jun 4, 2020

slomeo commented Jun 4, 2020

kpedro88 commented Jun 4, 2020 •

edited

Loading

slomeo commented Jun 5, 2020

slomeo commented Jun 5, 2020

Update of the RPC migration to DD4hep #30047

Update of the RPC migration to DD4hep #30047

Conversation

slomeo commented May 29, 2020 • edited Loading

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented May 29, 2020

cmsbuild commented May 29, 2020

cmsbuild commented May 29, 2020

cmsbuild commented May 29, 2020

cmsbuild commented May 29, 2020

kpedro88 commented May 29, 2020

cmsbuild commented May 29, 2020 • edited Loading

cmsbuild commented May 29, 2020

cmsbuild commented May 29, 2020

cmsbuild commented Jun 4, 2020

cmsbuild commented Jun 4, 2020

cmsbuild commented Jun 4, 2020

perrotta commented Jun 4, 2020

cmsbuild commented Jun 4, 2020 • edited Loading

cmsbuild commented Jun 4, 2020

cmsbuild commented Jun 4, 2020

slomeo commented Jun 4, 2020

cmsbuild commented Jun 4, 2020

ianna commented Jun 4, 2020

ianna Jun 4, 2020

Choose a reason for hiding this comment

ianna Jun 4, 2020

Choose a reason for hiding this comment

ianna Jun 4, 2020

Choose a reason for hiding this comment

slomeo commented Jun 4, 2020

kpedro88 commented Jun 4, 2020 • edited Loading

slomeo commented Jun 5, 2020

slomeo commented Jun 5, 2020

slomeo commented May 29, 2020 •

edited

Loading

cmsbuild commented May 29, 2020 •

edited

Loading

cmsbuild commented Jun 4, 2020 •

edited

Loading

kpedro88 commented Jun 4, 2020 •

edited

Loading