initialize std::array data member in TICLCandidate

[slava77]

apparently arrays are not default-constructed and we get random values TICLCandidate::idProbabilities_ presently, in absence of settings by the current version of TICLCandidateFromTrackstersProducer.
I checked on wf 23234.0 that zeroes are now appearing instead of something random

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29616/14965

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @slava77 (Slava Krutelyov) for master.

It involves the following packages:

DataFormats/HGCalReco

@perrotta, @cmsbuild, @kpedro88, @slava77 can you please review it and eventually sign? Thanks.
@riga, @rovere this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5955/console Started: 2020/05/02 00:42

[cmsbuild]

+1
Tested at: eb621d2
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a0cc99/5955/summary.html
CMSSW: CMSSW_11_1_X_2020-05-01-1100
SCRAM_ARCH: slc7_amd64_gcc820

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• [LLVM10] Fixing compilation warnings for Reco2 #29572 @smuzaffar: [LLVM10] Fixing compilation warnings for Reco2
• BuildFile cleanup: removed unnecessary dependencies #29608 @smuzaffar: BuildFile cleanup: removed unnecessary dependencies
• [LLVM10] Fixing compilation warnings for SIM #29598 @smuzaffar: [LLVM10] Fixing compilation warnings for SIM

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a0cc99/5955/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a0cc99/5955/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a0cc99/5955/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2696239
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2695918
• DQMHistoTests: Total skipped: 319
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[slava77]

+1

for #29616 eb621d2

[slava77]

@kpedro88
please check and comment or sign some time soon.
Thank you.

[slava77]

random values (before this PR) can be seen in https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_11_1_X_2020-05-01-2300+dbde9f/36104/validateJR.html

[kpedro88]

+upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1