Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reco comparisons: TICL monitoring: tracksters with multiclusters, TICL and PF Candidates #1292

Merged
merged 1 commit into from
May 6, 2020

Conversation

slava77
Copy link
Contributor

@slava77 slava77 commented May 1, 2020

updates in validate.C used for reco comparisons. The main part is the addition of monitoring for TICL reconstruction, which is available in the default workflows since 11_1_0_pre6.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 1, 2020

A new Pull Request was created by @slava77 (Slava Krutelyov) for branch master.

@cmsbuild, @smuzaffar, @mrodozov, @tulamor can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

@slava77
Copy link
Contributor Author

slava77 commented May 1, 2020

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 1, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5956/console Started: 2020/05/02 02:23

@slava77
Copy link
Contributor Author

slava77 commented May 1, 2020

it may be better to merge this only after cms-sw/cmssw#29616 is merged to avoid random differences in comparisons

@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2020

+1
Tested at: a017b5b
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dbde9f/5956/summary.html
CMSSW: CMSSW_11_1_X_2020-05-01-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dbde9f/5956/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 24 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2696239
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2695912
  • DQMHistoTests: Total skipped: 319
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@slava77
Copy link
Contributor Author

slava77 commented May 5, 2020

@cmsbuild please test

after CMSSW_11_1_X_2020-05-04-2300 the differences in reco should go away

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6108/console Started: 2020/05/05 21:57

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2020

+1
Tested at: a017b5b
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dbde9f/6108/summary.html
CMSSW: CMSSW_11_1_X_2020-05-05-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 6, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dbde9f/6108/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2696239
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2695918
  • DQMHistoTests: Total skipped: 319
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@smuzaffar
Copy link
Contributor

@slava77 , is ready to go in now?

@slava77
Copy link
Contributor Author

slava77 commented May 6, 2020

@slava77 , is ready to go in now?

yes, it's ready.
Thanks for checking.

@smuzaffar
Copy link
Contributor

+externals

@cmsbuild
Copy link
Contributor

cmsbuild commented May 6, 2020

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants