Update eventcontent structure in RecoHI packages #29576

jeongeun · 2020-04-28T15:18:07Z

PR description:

Update event content definitions to explicitly have RECO to be a superset of AOD and for FEVT to be a superset of RECO. 5 files changed :

RecoHI/Configuration/python/RecoHI_EventContent_cff.py
RecoHI/HiCentralityAlgos/python/RecoHiCentrality_EventContent_cff.py
RecoHI/HiEvtPlaneAlgos/python/RecoHiEvtPlane_EventContent_cff.py
RecoHI/HiMuonAlgos/python/RecoHiMuon_EventContent_cff.py
RecoHI/HiTracking/python/RecoHiTracker_EventContent_cff.py

FYI, RecoHI/HiEgammaAlgos/python/RecoHiEgamma_EventContent_cff.py, RecoHI/HiJetAlgos/python/RecoHiJets_EventContent_cff.py files are work in progress and they will be updated in new PRs later (maybe separately).

(The previous tasks are PR#29025, PR#29158, PR#29225, PR#29299, PR#29470, PR#29517, PR#29535, and PR#29571 )

PR validation:

Event Content comparison check was also done and there is no change with these updates.
Tested in CMSSW_11_1_X, the basic test all passed in the CMSSW PR instructions.

cmsbuild · 2020-04-28T15:18:41Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-04-28T15:24:43Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29576/14888

This PR adds an extra 16KB to repository

cmsbuild · 2020-04-28T15:25:13Z

A new Pull Request was created by @jeongeun (JeongEun Lee) for master.

It involves the following packages:

RecoHI/Configuration
RecoHI/HiCentralityAlgos
RecoHI/HiEvtPlaneAlgos
RecoHI/HiMuonAlgos
RecoHI/HiTracking

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@MiheeJo, @jazzitup, @echapon, @yenjie, @kurtejung, @mandrenguyen, @dgulhan, @yetkinyilmaz this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

perrotta · 2020-04-28T15:32:21Z

please test

cmsbuild · 2020-04-28T15:32:48Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5890/console Started: 2020/04/28 17:33

cmsbuild · 2020-04-28T16:44:21Z

+1
Tested at: 6b9c94e
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-297ff9/5890/summary.html
CMSSW: CMSSW_11_1_X_2020-04-28-1100
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-04-28T16:44:24Z

Comparison job queued.

cmsbuild · 2020-04-28T18:11:26Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-297ff9/5890/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 2 differences found in the comparisons
DQMHistoTests: Total files compared: 34
DQMHistoTests: Total histograms compared: 2696435
DQMHistoTests: Total failures: 2
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2696114
DQMHistoTests: Total skipped: 319
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
Checked 147 log files, 16 edm output root files, 34 DQM output files

perrotta · 2020-04-29T14:08:35Z

RecoHI/HiMuonAlgos/python/RecoHiMuon_EventContent_cff.py

 #AOD content
 RecoHiMuonAOD = cms.PSet(
    outputCommands = cms.untracked.vstring()
    )
-
 #Add Isolation
 from RecoMuon.MuonIsolationProducers.muIsolation_EventContent_cff import *


Where are these RecoMuonIsolationXXX event contents used here, or in the calling configs?
If I am not wrong this import could even be removed here, if we want to clean up the config.
@mandrenguyen ?

Indeed, it looks like nothing from that import is actually used. If it's not doing anything, might as well remove it.

Okay, I will remove it.

cmsbuild · 2020-04-30T02:36:45Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-04-30T02:42:26Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29576/14927

This PR adds an extra 16KB to repository

cmsbuild · 2020-04-30T02:42:51Z

Pull request #29576 was updated. @perrotta, @cmsbuild, @slava77 can you please check and sign again.

perrotta · 2020-04-30T06:45:31Z

please test

cmsbuild · 2020-04-30T06:45:55Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5921/console Started: 2020/04/30 08:51

cmsbuild · 2020-04-30T08:02:25Z

+1
Tested at: b923b12
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-297ff9/5921/summary.html
CMSSW: CMSSW_11_1_X_2020-04-29-2300
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-04-30T08:02:28Z

Comparison job queued.

cmsbuild · 2020-04-30T09:29:13Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-297ff9/5921/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 34
DQMHistoTests: Total histograms compared: 2696435
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2696115
DQMHistoTests: Total skipped: 319
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
Checked 147 log files, 16 edm output root files, 34 DQM output files

perrotta · 2020-04-30T09:56:41Z

+1

Structure of the RecoHI event content packages updated according to the plan, with no effect expected on the actual products saved
Jenkins tests pass

cmsbuild · 2020-04-30T09:57:08Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

silviodonato · 2020-04-30T16:26:44Z

+1

update eventcontent structure in RecoHI packages

6b9c94e

cmsbuild added this to the CMSSW_11_1_X milestone Apr 28, 2020

cmsbuild added code-checks-pending comparison-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Apr 28, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Apr 28, 2020

cmsbuild added tests-started and removed tests-pending labels Apr 28, 2020

cmsbuild added tests-approved and removed tests-started labels Apr 28, 2020

cmsbuild added comparison-available and removed comparison-pending labels Apr 28, 2020

perrotta reviewed Apr 29, 2020

View reviewed changes

remove unused muIsolation

b923b12

cmsbuild added code-checks-pending and removed code-checks-approved comparison-available tests-approved labels Apr 30, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Apr 30, 2020

cmsbuild added tests-started and removed tests-pending labels Apr 30, 2020

cmsbuild added tests-approved and removed tests-started labels Apr 30, 2020

cmsbuild added comparison-available and removed comparison-pending labels Apr 30, 2020

cmsbuild added fully-signed reconstruction-approved and removed pending-signatures reconstruction-pending labels Apr 30, 2020

cmsbuild added orp-approved and removed orp-pending labels Apr 30, 2020

cmsbuild merged commit c2aa3d9 into cms-sw:master Apr 30, 2020

cmsbuild mentioned this pull request May 1, 2020

[LLVM10] Fixing compilation warnings for SIM #29598

Merged

This was referenced May 6, 2020

Update eventcontent structure for RecoHiEgamma #29746

Merged

Update eventcontent structure for RecoHiJets #29752

Merged

jeongeun deleted the eventcontentHI branch May 26, 2020 15:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update eventcontent structure in RecoHI packages #29576

Update eventcontent structure in RecoHI packages #29576

jeongeun commented Apr 28, 2020

cmsbuild commented Apr 28, 2020

cmsbuild commented Apr 28, 2020

cmsbuild commented Apr 28, 2020

perrotta commented Apr 28, 2020

cmsbuild commented Apr 28, 2020 •

edited

Loading

cmsbuild commented Apr 28, 2020

cmsbuild commented Apr 28, 2020

cmsbuild commented Apr 28, 2020

perrotta Apr 29, 2020

mandrenguyen Apr 29, 2020

jeongeun Apr 30, 2020

cmsbuild commented Apr 30, 2020

cmsbuild commented Apr 30, 2020

cmsbuild commented Apr 30, 2020

perrotta commented Apr 30, 2020

cmsbuild commented Apr 30, 2020 •

edited

Loading

cmsbuild commented Apr 30, 2020

cmsbuild commented Apr 30, 2020

cmsbuild commented Apr 30, 2020

perrotta commented Apr 30, 2020

cmsbuild commented Apr 30, 2020

silviodonato commented Apr 30, 2020

Update eventcontent structure in RecoHI packages #29576

Update eventcontent structure in RecoHI packages #29576

Conversation

jeongeun commented Apr 28, 2020

PR description:

PR validation:

cmsbuild commented Apr 28, 2020

cmsbuild commented Apr 28, 2020

cmsbuild commented Apr 28, 2020

perrotta commented Apr 28, 2020

cmsbuild commented Apr 28, 2020 • edited Loading

cmsbuild commented Apr 28, 2020

cmsbuild commented Apr 28, 2020

cmsbuild commented Apr 28, 2020

perrotta Apr 29, 2020

Choose a reason for hiding this comment

mandrenguyen Apr 29, 2020

Choose a reason for hiding this comment

jeongeun Apr 30, 2020

Choose a reason for hiding this comment

cmsbuild commented Apr 30, 2020

cmsbuild commented Apr 30, 2020

cmsbuild commented Apr 30, 2020

perrotta commented Apr 30, 2020

cmsbuild commented Apr 30, 2020 • edited Loading

cmsbuild commented Apr 30, 2020

cmsbuild commented Apr 30, 2020

cmsbuild commented Apr 30, 2020

perrotta commented Apr 30, 2020

cmsbuild commented Apr 30, 2020

silviodonato commented Apr 30, 2020

cmsbuild commented Apr 28, 2020 •

edited

Loading

cmsbuild commented Apr 30, 2020 •

edited

Loading