Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove drop and update the event content formats #29158

Merged
merged 3 commits into from
Mar 11, 2020

Conversation

jeongeun
Copy link
Contributor

PR description:

Update event content definitions to explicitly have RECO to be a superset of AOD and for FEVT to be a superset of RECO. (An extension of the task PR#29025).
5 files changed :
RecoLocalMuon_EventContent_cff.py
RecoLocalTracker_EventContent_cff.py
RecoTracker_EventContent_cff.py
TrackingTools_EventContent_cff.py
RecoMET_EventContent_cff .py

In the RecoMETAOD output commands, "drop recoHcalNoiseRBXs_*_*_*," removed.

PR validation:

Event Content comparison check was also done and there is no change with these updates.
Tested in CMSSW_11_1_X, the basic test all passed in the CMSSW PR instructions.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29158/14116

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @jeongeun (JeongEun Lee) for master.

It involves the following packages:

RecoLocalMuon/Configuration
RecoLocalTracker/Configuration
RecoMET/Configuration
RecoTracker/Configuration
TrackingTools/Configuration

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@echabert, @gouskos, @felicepantaleo, @yduhm, @robervalwalsh, @alesaggio, @threus, @mmusich, @seemasharmafnal, @mmarionncern, @makortel, @jhgoh, @jdolen, @pieterdavid, @abbiendi, @GiacomoSguazzoni, @rovere, @VinInn, @jdamgov, @bellan, @nhanvtran, @gkasieczka, @schoef, @mschrode, @ebrondol, @dgulhan, @clelange, @gbenelli, @ahinzmann, @lecriste, @gpetruc, @mariadalfonso this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 10, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5091/console Started: 2020/03/10 10:30

@cmsbuild
Copy link
Contributor

+1
Tested at: 495675d
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6f4979/5091/summary.html
CMSSW: CMSSW_11_1_X_2020-03-09-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6f4979/5091/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2680577
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2680255
  • DQMHistoTests: Total skipped: 319
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

'keep TrackingRecHitsOwned_cosmicDCTracks_*_*',
)
'keep *_generalTracks_MVAValues_*',
'keep *_generalTracks_MVAVals_*'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noticing that before this PR "generalTracks_MVAVals" was not kept in the FEVT format, while being there in the RECO/AOD ones: this PR also fixes that inconsistency

phase2_hgcal.toModify( TrackingToolsRECO,
outputCommands = TrackingToolsRECO.outputCommands + _phase2_hgcal_TrackingRECO_tokeep)
phase2_hgcal.toModify( TrackingToolsAOD,
outputCommands = TrackingToolsAOD.outputCommands + ['keep recoGsfTracks_electronGsfTracksFromMultiCl_*_*'])
TrackingToolsRECO.outputCommands.extend(TrackingToolsAOD.outputCommands)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this particular case nothing changes, but logically the EventContent should get extended before applying the modifier.
(It could matter in case someone decides to add a "drop" statement in the modifier)

@cmsbuild
Copy link
Contributor

+1
Tested at: 92bf289
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6f4979/5133/summary.html
CMSSW: CMSSW_11_1_X_2020-03-10-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6f4979/5133/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2680577
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2680257
  • DQMHistoTests: Total skipped: 319
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@perrotta
Copy link
Contributor

+1

  • Restructuring of the reco event content implemented as planned, with no change in the actual AOD/RECO/FEVT contents
  • Jenkins tests pass

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants