-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove drop and update the event content formats #29158
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29158/14116
|
A new Pull Request was created by @jeongeun (JeongEun Lee) for master. It involves the following packages: RecoLocalMuon/Configuration @perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
'keep TrackingRecHitsOwned_cosmicDCTracks_*_*', | ||
) | ||
'keep *_generalTracks_MVAValues_*', | ||
'keep *_generalTracks_MVAVals_*' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just noticing that before this PR "generalTracks_MVAVals" was not kept in the FEVT format, while being there in the RECO/AOD ones: this PR also fixes that inconsistency
phase2_hgcal.toModify( TrackingToolsRECO, | ||
outputCommands = TrackingToolsRECO.outputCommands + _phase2_hgcal_TrackingRECO_tokeep) | ||
phase2_hgcal.toModify( TrackingToolsAOD, | ||
outputCommands = TrackingToolsAOD.outputCommands + ['keep recoGsfTracks_electronGsfTracksFromMultiCl_*_*']) | ||
TrackingToolsRECO.outputCommands.extend(TrackingToolsAOD.outputCommands) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this particular case nothing changes, but logically the EventContent should get extended before applying the modifier.
(It could matter in case someone decides to add a "drop" statement in the modifier)
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Update event content definitions to explicitly have RECO to be a superset of AOD and for FEVT to be a superset of RECO. (An extension of the task PR#29025).
5 files changed :
RecoLocalMuon_EventContent_cff.py
RecoLocalTracker_EventContent_cff.py
RecoTracker_EventContent_cff.py
TrackingTools_EventContent_cff.py
RecoMET_EventContent_cff .py
In the RecoMETAOD output commands, "drop recoHcalNoiseRBXs_*_*_*," removed.
PR validation:
Event Content comparison check was also done and there is no change with these updates.
Tested in CMSSW_11_1_X, the basic test all passed in the CMSSW PR instructions.