Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update BasicGenValidation_cff.py #29350

Merged
merged 1 commit into from
Apr 1, 2020
Merged

Update BasicGenValidation_cff.py #29350

merged 1 commit into from
Apr 1, 2020

Conversation

menglu21
Copy link
Contributor

@menglu21 menglu21 commented Mar 31, 2020

PR description:

Backport from #29146

PR validation:

Procedure:
scram project CMSSW_10_6_9 & cmsenv
git cms-rebase-topic --old-base CMSSW_11_1_0_pre5 menglu21:master
git branch -m portFrom111XTo106X_genvalidation
then do the same things with original PR

if this PR is a backport please specify the original PR and why you need to backport that PR:

Original PR is #29146

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 31, 2020

A new Pull Request was created by @menglu21 (Meng_Lu) for CMSSW_10_6_X.

It involves the following packages:

Validation/EventGenerator

@SiewYan, @andrius-k, @mkirsano, @kmaeshima, @schneiml, @efeyazgan, @cmsbuild, @jfernan2, @agrohsje, @fioriNTU, @alberto-sanchez, @qliphy can you please review it and eventually sign? Thanks.
@silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@qliphy
Copy link
Contributor

qliphy commented Mar 31, 2020

@menglu21 Can you rename the title to make it more meaningful? For example the same as in master branch "Update BasicGenValidation_cff.py"

@menglu21 menglu21 changed the title backport Update BasicGenValidation_cff.py Mar 31, 2020
@jfernan2
Copy link
Contributor

backport of #29146

@jfernan2
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 31, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5462/console Started: 2020/03/31 17:03

@cmsbuild
Copy link
Contributor

+1
Tested at: 44a5e84
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6a7140/5462/summary.html
CMSSW: CMSSW_10_6_X_2020-03-31-1100
SCRAM_ARCH: slc7_amd64_gcc700

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6a7140/5462/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3212324
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3211989
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@jfernan2
Copy link
Contributor

+1

@qliphy
Copy link
Contributor

qliphy commented Apr 1, 2020

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 1, 2020

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 9aa8b22 into cms-sw:CMSSW_10_6_X Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants