-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update BasicGenValidation_cff.py #29350
Update BasicGenValidation_cff.py #29350
Conversation
A new Pull Request was created by @menglu21 (Meng_Lu) for CMSSW_10_6_X. It involves the following packages: Validation/EventGenerator @SiewYan, @andrius-k, @mkirsano, @kmaeshima, @schneiml, @efeyazgan, @cmsbuild, @jfernan2, @agrohsje, @fioriNTU, @alberto-sanchez, @qliphy can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
@menglu21 Can you rename the title to make it more meaningful? For example the same as in master branch "Update BasicGenValidation_cff.py" |
backport of #29146 |
please test |
The tests are being triggered in jenkins. |
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Backport from #29146
PR validation:
Procedure:
scram project CMSSW_10_6_9 & cmsenv
git cms-rebase-topic --old-base CMSSW_11_1_0_pre5 menglu21:master
git branch -m portFrom111XTo106X_genvalidation
then do the same things with original PR
if this PR is a backport please specify the original PR and why you need to backport that PR:
Original PR is #29146