-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update BasicGenValidation_cff.py #29146
Conversation
add sequence for higgs/ttbar separate validation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29146/14077
|
A new Pull Request was created by @menglu21 (Meng_Lu) for master. It involves the following packages: Validation/EventGenerator @SiewYan, @andrius-k, @mkirsano, @kmaeshima, @schneiml, @efeyazgan, @cmsbuild, @jfernan2, @agrohsje, @fioriNTU, @alberto-sanchez, @qliphy can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@menglu21 have you performed some test/validation over this change? If so, can you please post your results along with some description in the PR header as requested? Thanks |
Hi, i updated the PR header with the description, validation step and results, the log is not full but only with the important parts. |
please test |
The tests are being triggered in jenkins. |
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
yes, we provided @menglu21 with the list of relevant releases for production |
Hi all, |
add sequence for higgs/ttbar separate validation
PR description:
The changes made are for the sample validation using McM, people can now choose higgs/dy/top/w/qcd process to be validated. The top/higgs parts are added by imitating the existing dy/qcd... In the output rootfile, there will be additional branch for VALIDATIONS. The slides are https://indico.cern.ch/event/878706/contributions/3761830/attachments/1993587/3324981/GENvalidation.pdf
PR validation:
Validation done by following steps:
where aa is https://cms-pdmv.cern.ch/mcm/public/restapi/requests/get_test/SMP-RunIISummer15wmLHEGS-00378, the request is set to run 'higgs' content validation.
The output is:
`...
LHE,GEN,SIM,VALIDATION:genvalid_higgs
Step: LHE Spec:
Loading lhe fragment from Configuration.GenProduction.SMP-RunIISummer15wmLHEGS-00378-fragment
Step: GEN Spec:
Loading generator fragment from Configuration.GenProduction.SMP-RunIISummer15wmLHEGS-00378-fragment
Step: SIM Spec:
Step: VALIDATION Spec: ['genvalid_higgs']
genvalid_higgs in preparing validation
customising the process with addMonitoring from Configuration/DataProcessing/Utils
customising the process with customisePostLS1 from SLHCUpgradeSimulations/Configuration/postLS1Customs
customising the process with setCrossingFrameOn from SimGeneral/MixingModule/fullMixCustomize_cff
Config file SMP-RunIISummer15wmLHEGS-00378_1_cfg.py created
==> using COND/Services/RelationalAuthenticationService for auth, sys 1
==> using COND/Services/RelationalAuthenticationService for auth, sys 1
gridpack tarball path = /cvmfs/cms.cern.ch/phys_generator/gridpacks/slc6_amd64_gcc481/13TeV/madgraph/V5_2.2.2/dyellell012j_5f_NLO_FXFX_M100to200/v1/dyellell012j_5f_NLO_FXFX_M100to200_tarball.tar.xz
%MSG-MG5 number of events requested = 98
%MSG-MG5 random seed used for the run = 52
%MSG-MG5 thread count requested = 1
%MSG-MG5 residual/optional arguments =
...`
From the log, the genvalidation_higgs is compiled successfully, and a rootfile is obtained eventually.
if this PR is a backport please specify the original PR and why you need to backport that PR:
Before submitting your pull requests, make sure you followed this checklist: