Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outdated jercVars from JME custom NanoAOD for AK4 and AK8 jets #29249

Closed
wants to merge 1 commit into from
Closed

Conversation

peruzzim
Copy link
Contributor

PR description:

Temporarily remove the so-called JERC variables from the JME custom NanoAOD content, to fix the crash in the IB reported in #29245.
JME experts will then re-add updated variables as needed.

@lathomas @ahinzmann please forward this information to the developers

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@peruzzim
Copy link
Contributor Author

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29249/14288

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @peruzzim for master.

It involves the following packages:

PhysicsTools/NanoAOD

@cmsbuild, @santocch, @fgolf, @peruzzim can you please review it and eventually sign? Thanks.
@gpetruc this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@peruzzim
Copy link
Contributor Author

please test workflow 25202.01

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 20, 2020

The tests are being triggered in jenkins.
Test Parameters:

@cmsbuild
Copy link
Contributor

-1

Tested at: b101b89

CMSSW: CMSSW_11_1_X_2020-03-19-2300
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c4e0b7/5285/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

  • RelVals:

When I ran the RelVals I found an error in the following workflows:
25202.01 step5

runTheMatrix-results/25202.01_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25+NANOUP15MC_PU25_JME/step5_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25+NANOUP15MC_PU25_JME.log

@cmsbuild
Copy link
Contributor

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

@peruzzim
Copy link
Contributor Author

I'm afraid PhysicsTools/PatAlgos/python/tools/jetCollectionTools.py needs fixing too, it should be touched only by JME experts so I will close this PR and encourage them to propagate the changes there.

@peruzzim peruzzim closed this Mar 20, 2020
@nurfikri89
Copy link
Contributor

@peruzzim Should I use PR #29239 to include this fix?

@peruzzim
Copy link
Contributor Author

that would certainly work and will also be needed to test it successfully, thank you really much!

@nurfikri89
Copy link
Contributor

Will be fixed in PR #29257

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants