-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove outdated jercVars from JME custom NanoAOD for AK4 and AK8 jets #29249
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29249/14288
|
A new Pull Request was created by @peruzzim for master. It involves the following packages: PhysicsTools/NanoAOD @cmsbuild, @santocch, @fgolf, @peruzzim can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test workflow 25202.01 |
The tests are being triggered in jenkins.
|
-1 Tested at: b101b89 CMSSW: CMSSW_11_1_X_2020-03-19-2300 I found follow errors while testing this PR Failed tests: RelVals
When I ran the RelVals I found an error in the following workflows: runTheMatrix-results/25202.01_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25+NANOUP15MC_PU25_JME/step5_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25+NANOUP15MC_PU25_JME.log |
Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped) |
I'm afraid |
that would certainly work and will also be needed to test it successfully, thank you really much! |
Will be fixed in PR #29257 |
PR description:
Temporarily remove the so-called JERC variables from the JME custom NanoAOD content, to fix the crash in the IB reported in #29245.
JME experts will then re-add updated variables as needed.
@lathomas @ahinzmann please forward this information to the developers