Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add QGL input variables in JME Custom-NanoAODs #29239

Closed

Conversation

nurfikri89
Copy link
Contributor

This PR adds input jet variables needed for the quark vs gluon likelihood (QGL) in the JME Custom-NanoAODs. The variables are useful QGL developers when they need to train the likelihood for future new releases.

The input variables are already calculated together with the QGL discriminant in the main NanoAOD production. They are not saved in the main NanoAODs by default.

This PR needs to be backported to 10_6_X, once merged, for the ultra legacy campaigns.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@nurfikri89
Copy link
Contributor Author

FYI JMAR convenors @alefisico @camclean

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29239/14270

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @nurfikri89 (Nurfikri Norjoharuddeen) for master.

It involves the following packages:

PhysicsTools/NanoAOD

@cmsbuild, @santocch, @fgolf, @peruzzim can you please review it and eventually sign? Thanks.
@gpetruc this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

fwyzard and others added 5 commits March 19, 2020 16:53
Enable the ThroughputService to measure the throughput without relying on DQM:
  - compute and print the single-job throughput at the of the job;
  - optionally dump the information to compute a combined throughput
    across multiple jobs.

The production of DQM plots is enabled by default, but optional.
[HGCal] RecHits calibration using regional e/m factors
Clean residual dependency of SimG4Core/Forward on DetectorDescription
@cmsbuild
Copy link
Contributor

+1
Tested at: c661f9e
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7643f7/5294/summary.html
CMSSW: CMSSW_11_1_X_2020-03-20-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@nurfikri89
Copy link
Contributor Author

Closing this PR. Messed up the commit history. Will make a new one with fixes to jerc variables

@nurfikri89 nurfikri89 closed this Mar 20, 2020
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29239/14296

  • This PR adds an extra 24KB to repository

@cmsbuild
Copy link
Contributor

@nurfikri89
Copy link
Contributor Author

New PR for this addition is #29257.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7643f7/5294/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2692493
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2692172
  • DQMHistoTests: Total skipped: 319
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment