-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tracker alignment: Backport millepede submission to Condor to 10_6_X #29135
Conversation
A new Pull Request was created by @adewit for CMSSW_10_6_X. It involves the following packages: Alignment/MillePedeAlignmentAlgorithm @christopheralanwest, @tocheng, @cmsbuild, @franzoni, @tlampen, @pohsun can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This enables submission of the millepede alignment algorithm to Condor, as well as adding some improvements in file copying to/from eos which is needed for the different steps of the alignment algorithm, as well as failure reporting.
PR validation:
Has already been extensively used, also in CMSSW_10_6_X, to produce the ultra legacy alignment campaigns.
if this PR is a backport please specify the original PR and why you need to backport that PR:
Backport of #26774, #27144, and #27492. The condor submission is implemented in #27144, the other two take care of the improvements in file copying and error reporting. Needed to be able to run alignments on samples produced in CMSSW_10_6_X without having to cherry pick the commits every time someone wants to set up a new release area.
cc @vbotta @connorpa