Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TkAl: Improving job output copying + error reporting #26774

Merged
merged 2 commits into from
May 15, 2019

Conversation

adewit
Copy link
Contributor

@adewit adewit commented May 14, 2019

PR description:

This improves the mille step of the MillePede alignment algorithm. At the end of the job, the output is copied from the batch node to eos. Recently we have noticed more frequent failures in this procedure. The changes in this PR add a checksum check to the xrdcp command used to copy the files. In addition, in the job status accounting at the end, copy failures are now reported

PR validation:

Tested on around 300 jobs, works as expected. Only affects jobs run as part of millepede alignment - no other dependencies. Should not affect the output of standard tests

if this PR is a backport please specify the original PR:

Not a backport

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26774/9772

  • This PR adds an extra 24KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @adewit for master.

It involves the following packages:

Alignment/MillePedeAlignmentAlgorithm

@christopheralanwest, @tocheng, @cmsbuild, @franzoni, @tlampen, @pohsun can you please review it and eventually sign? Thanks.
@mschrode, @mmusich, @tocheng, @tlampen this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@tlampen
Copy link
Contributor

tlampen commented May 14, 2019

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 14, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/206/console Started: 2019/05/14 15:56

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1c6e16/206/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3212004
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3211669
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@fabiocos fabiocos added this to the CMSSW_11_0_X milestone May 15, 2019
@pohsun
Copy link

pohsun commented May 15, 2019

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants