-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TkAl: Improving job output copying + error reporting #26774
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26774/9772
|
A new Pull Request was created by @adewit for master. It involves the following packages: Alignment/MillePedeAlignmentAlgorithm @christopheralanwest, @tocheng, @cmsbuild, @franzoni, @tlampen, @pohsun can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This improves the mille step of the MillePede alignment algorithm. At the end of the job, the output is copied from the batch node to eos. Recently we have noticed more frequent failures in this procedure. The changes in this PR add a checksum check to the xrdcp command used to copy the files. In addition, in the job status accounting at the end, copy failures are now reported
PR validation:
Tested on around 300 jobs, works as expected. Only affects jobs run as part of millepede alignment - no other dependencies. Should not affect the output of standard tests
if this PR is a backport please specify the original PR:
Not a backport