-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace ConfigParser with configparser (Python3 compatibility) #28822
Conversation
The code-checks are being triggered in jenkins. |
please test |
please test for CMSSW_11_1_PY3_X |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28822/13541
|
The tests are being triggered in jenkins.
|
A new Pull Request was created by @silviodonato (Silvio Donato) for master. It involves the following packages: Alignment/APEEstimation @andrius-k, @lveldere, @slava77, @schneiml, @ianna, @fioriNTU, @tlampen, @pohsun, @perrotta, @civanch, @makortel, @cmsbuild, @Dr15Jones, @cvuosalo, @mdhildreth, @jfernan2, @tocheng, @sbein, @ggovi, @ssekmen, @kmaeshima, @christopheralanwest, @franzoni can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test for CMSSW_11_1_X |
-1 Tested at: 75aa422 CMSSW: CMSSW_11_1_X_2020-01-29-1100 I found follow errors while testing this PR Failed tests: Build Python3
I found compilation warning when building: See details on the summary page.
I found errors: *** Error compiling 'src/HLTriggerOffline/Btag/python/helper.py'... |
Comparison not run due to Build errors (RelVals and Igprof tests were also skipped) |
Comparison is ready Comparison Summary:
|
The tests are being triggered in jenkins.
|
+1 |
Comparison is ready Comparison Summary:
|
The tests are being triggered in jenkins. |
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
PR description:
This PR replaces "import ConfigParser" (compatible only with Python2.X) with "import configparser as ConfigParser" (compatible with both Python 2 and Python 3).
See https://python-future.org/compatible_idioms.html#configparser.
This PR will fix the unit test error of Alignment/OfflineValidation in Python 3
https://cmssdt.cern.ch/SDT/cgi-bin/logreader/slc7_amd64_gcc820/CMSSW_11_1_PY3_X_2020-01-28-2300/unitTestLogs/Alignment/OfflineValidation#/
The unit test was added with #28739.
PR validation:
Unit tests