Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce unit tests for Tracker Alignment all-in-one meta-validation tool #28739

Merged
merged 6 commits into from
Jan 19, 2020

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Jan 15, 2020

PR description:

Title says it all, additionally a few minor fixes are introduced:

  • configuration file for unit test in Alignment/MillePedeAlignmentAlgorithm/ which was leading to apparently uncaught exception in the tests;
  • update the example ini file to comply with current standard;
  • indentation in the validation script;
  • support again the dryRun mode which was removed in latest iteration.

PR validation:

Relies on existing unit tests and the one added in this PR.

if this PR is a backport please specify the original PR:

Not a backport.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28739/13367

  • This PR adds an extra 28KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

Alignment/MillePedeAlignmentAlgorithm
Alignment/OfflineValidation

@christopheralanwest, @tocheng, @cmsbuild, @franzoni, @tlampen, @pohsun can you please review it and eventually sign? Thanks.
@mschrode, @mmusich, @adewit, @tocheng, @tlampen this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@tocheng
Copy link
Contributor

tocheng commented Jan 15, 2020

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 15, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4228/console Started: 2020/01/15 12:26

@cmsbuild
Copy link
Contributor

+1
Tested at: cccecbc
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fa134e/4228/summary.html
CMSSW: CMSSW_11_1_X_2020-01-14-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fa134e/4228/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2711715
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2711368
  • DQMHistoTests: Total skipped: 346
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@pohsun
Copy link

pohsun commented Jan 19, 2020

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants