Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Photos createHistoryEntries (94X) #28817

Merged
merged 2 commits into from
Jan 30, 2020

Conversation

mseidel42
Copy link
Contributor

94X backport of #28785

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 29, 2020

A new Pull Request was created by @intrepid42 (Markus Seidel) for CMSSW_9_4_X.

It involves the following packages:

GeneratorInterface/PhotosInterface

@SiewYan, @efeyazgan, @mkirsano, @cmsbuild, @agrohsje, @alberto-sanchez, @qliphy can you please review it and eventually sign? Thanks.
@alberto-sanchez, @agrohsje, @mkirsano this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@silviodonato
Copy link
Contributor

backport of #28785

@silviodonato
Copy link
Contributor

@intrepid42 why do you need these backports in 94X and 71X? Our ultra-legacy release for Run-2 is 10_6_X

@mseidel42
Copy link
Contributor Author

Hi Silvio, we need it for W mass in 2016 (71X) and 2017 lowPU (94X) production.
At the moment it does not look like this will happen as UL but I will create a backport to 106 as well!

@qliphy
Copy link
Contributor

qliphy commented Jan 29, 2020

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 29, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4403/console Started: 2020/01/29 13:34

@cmsbuild
Copy link
Contributor

+1
Tested at: e53ba43
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1a03cd/4403/summary.html
CMSSW: CMSSW_9_4_X_2020-01-26-0000
SCRAM_ARCH: slc6_amd64_gcc630

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1a03cd/4403/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 27
  • DQMHistoTests: Total histograms compared: 2721493
  • DQMHistoTests: Total failures: 116
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2721215
  • DQMHistoTests: Total skipped: 162
  • DQMHistoTests: Total Missing objects: 0

@qliphy
Copy link
Contributor

qliphy commented Jan 29, 2020

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit bc701c0 into cms-sw:CMSSW_9_4_X Jan 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants