Photos createHistoryEntries

[mseidel42]

PR description:

Photos adjusts the momenta of resonance decay products to compensate for the photon emission. With the createHistoryEntries option also it stores copies of the original decay products, needed for Born-level studies. The status code is set to 746 (P-H-O) which does not interfere with Pythia status codes.

PR validation:

Z boson and its decay products:

 idx  |    ID -       Name |Stat|  Mo1  Mo2  Da1  Da2 |nMo nDa|    pt       eta     phi   |     px         py         pz        m     |
   46 |    23 -         Z0 | 62 |   15   15   59  220 |  1  5 |   6.117      6.611  2.654 |     -5.405      2.863   2273.266   91.033 |
altered by Photos:
   59 |    13 -        mu- |  1 |   46   46   -1   -1 |  1  0 |  45.616      3.950  1.162 |     18.124     41.861   1183.619    0.106 |
   60 |   -13 -        mu+ |  1 |   46   46   -1   -1 |  1  0 |  44.536      3.869 -2.114 |    -23.002    -38.136   1066.140    0.106 |
added by Photos:
  218 |    22 -      gamma |  1 |   46   46   -1   -1 |  1  0 |   1.011      3.840 -2.120 |     -0.527     -0.862     23.506   -0.000 |
  219 |    13 -        mu- | 746 |   46   46   -1   -1 |  1  0 |  45.617      3.950  1.162 |     18.124     41.862   1183.625    0.106 |
  220 |   -13 -        mu+ | 746 |   46   46   -1   -1 |  1  0 |  45.547      3.868 -2.114 |    -23.529    -38.998   1089.641    0.106 |

Note that the additional muon copies do not have status=1, so they will not be reconstructed.

@bendavid

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28785/13459

• This PR adds an extra 16KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28785/13459/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28785/13459/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28785/13460

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @intrepid42 (Markus Seidel) for master.

It involves the following packages:

GeneratorInterface/PhotosInterface

@SiewYan, @efeyazgan, @mkirsano, @cmsbuild, @agrohsje, @alberto-sanchez, @qliphy can you please review it and eventually sign? Thanks.
@alberto-sanchez, @agrohsje, @mkirsano this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[qliphy]

please test

[qliphy]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/4382/console Started: 2020/01/28 13:39

[cmsbuild]

+1
Tested at: b5d033d
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cbef1b/4382/summary.html
CMSSW: CMSSW_11_1_X_2020-01-28-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cbef1b/4382/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2697090
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2696743
• DQMHistoTests: Total skipped: 346
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[qliphy]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1