-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix alias in PreMixing configuration for APV simulation #28454
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28454/12880
|
A new Pull Request was created by @fabiocos (Fabio Cossutti) for master. It involves the following packages: SimGeneral/MixingModule @cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test workflow 250400.0,20634.99 |
The tests are being triggered in jenkins. |
-1 Tested at: 6598541 You can see the results of the tests here: I found follow errors while testing this PR Failed tests: RelVals
When I ran the RelVals I found an error in the following workflows: runTheMatrix-results/20634.99_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2026D41PU_GenSimHLBeamSpotFull14+SingleNuE10_cf_2026D41PU_PremixHLBeamSpotFull14PU_Premix+DigiFullTriggerPUPRMXCombined_2026D41PU+RecoFullGlobalPUPRMX_2026D41PU+HARVESTFullGlobalPU_2026D41PU/step3_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2026D41PU_GenSimHLBeamSpotFull14+SingleNuE10_cf_2026D41PU_PremixHLBeamSpotFull14PU_Premix+DigiFullTriggerPUPRMXCombined_2026D41PU+RecoFullGlobalPUPRMX_2026D41PU+HARVESTFullGlobalPU_2026D41PU.log |
Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped) |
failure of 20634.99 as expected, all the other tests look ok |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28454/12884
|
Pull request #28454 was updated. @cmsbuild, @civanch, @mdhildreth can you please check and sign again. |
please test workflow 250400.0,20634.99,20634.21 |
The tests are being triggered in jenkins. |
Thanks! |
Comparison job queued. |
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
+1 |
merge |
PR description:
The integration of #28355 has caused a massive relval failure in CMSSW_11_0_X_2019-11-21-2300 due to a problem in the configuration of alias for PreMixing. This PR suggests a fix, to ve confirmed and validated by experts @mmusich @makortel .
PR validation:
The failing configurations (250400.0) now run. This does not fix yet 20634.99 .