Remove EcalDeadChannelRecoveryNN

[perrotta]

PR description:

Following the issue reported in #27657, the following files were said to be removed after the merging of #27175 in the master:

• EcalDeadChannelRecoveryNN class
• All the content of the RecoLocalCalo/EcalDeadChannelRecoveryAlgos/test directory

Further:

• Removed unneeded dependency and includes of EcalRecHit, as pointed out by the unit tests

PR validation:

It builds

@nancymarinelli @taroni
@crovelli @argiro @zghiche @fcouderc

[cmsbuild]

The code-checks are being triggered in jenkins.

[perrotta]

@nancymarinelli @taroni I think that one should further update the config in
RecoLocalCalo/​EcalRecProducers/​python/​ecalTBSimRecHit_cfi.py
but I'd let you deal with it in a separate PR

[perrotta]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27986/11878

• This PR adds an extra 12KB to repository

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2507/console Started: 2019/09/13 14:42

[cmsbuild]

A new Pull Request was created by @perrotta for master.

It involves the following packages:

RecoLocalCalo/EcalDeadChannelRecoveryAlgos

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@apsallid, @argiro this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1
Tested at: c69c055
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bcdb68/2507/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• Support concurrent LuminosityBlocks in HLTrigReport #27961 @Dr15Jones: Support concurrent LuminosityBlocks in HLTrigReport
• Run3-hgx220 Convert DDHGCalTBModule algorithm for DD4Hep #27979 @bsunanda: Run3-hgx220 Convert DDHGCalTBModule algorithm for DD4Hep

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bcdb68/2507/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bcdb68/2507/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bcdb68/2507/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2957224
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2956882
• DQMHistoTests: Total skipped: 341
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 145 log files, 15 edm output root files, 34 DQM output files

[perrotta]

+1

• Unused code is removed from CMSSW, also following the suggestion of the responsibles of the package in remove EcalDeadChannelRecoveryNN and related from CMSSW code base #27657
• Jenkins tests pass

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1