-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove EcalDeadChannelRecoveryNN and related from CMSSW code base #27657
Comments
assign reconstruction |
A new Issue was created by @slava77 Slava Krutelyov. @davidlange6, @Dr15Jones, @smuzaffar, @fabiocos, @kpedro88 can you please review it and eventually sign/assign? Thanks. cms-bot commands are listed here |
Hi Slava,
you should trash also all what's in
/afs/cern.ch/work/n/nancy/private/testDeadChannelDev/CMSSW_11_0_X_2019-07-28-2300/src/RecoLocalCalo/EcalDeadChannelRecoveryAlgos/test
All that stuff is connected to NN. And we had to make it compile each time
Best,
Nancy
@crovelli @argiro @zghiche @fcouderc
@taroni
…On 31/07/19 17:45, Slava Krutelyov wrote:
This is a follow up to the developments coming with #27175.
EcalDeadChannelRecoveryNN was never deployed for production use.
A new solution is available now and it should replace the NN variant, it came with #27175 .
Given no plan for further use or support of the (old) NN variant, it can be removed safely after #27175 is integrated.
@crovelli @argiro @zghiche @fcouderc
@nancymarinelli @taroni
--
________________________________________
Nancy Marinelli
Research Associate Professor
University of Notre Dame, IN, US
CERN, Bdg 40/3-A01, 1211 Geneva
SWITZERLAND
Phone +41-22-76-70809
fax +41-22-76-78940
|
+1 done in #27986 |
cmsbuild
added
fully-signed
reconstruction-approved
and removed
pending-signatures
reconstruction-pending
labels
Sep 20, 2019
This issue is fully signed and ready to be closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This is a follow up to the developments coming with #27175.
EcalDeadChannelRecoveryNN was never deployed for production use.
A new solution is available now and it should replace the NN variant, it came with #27175 .
Given no plan for further use or support of the (old) NN variant, it can be removed safely after #27175 is integrated.
@crovelli @argiro @zghiche @fcouderc
@nancymarinelli @taroni
The text was updated successfully, but these errors were encountered: