Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed use of L1Trigger/GlobalMuonTrigger from test #27828

Merged

Conversation

Dr15Jones
Copy link
Contributor

PR description:

The test only needs the header so the lack of a shared library (since the package is plugin only) does not matter.

This gets rid of a 'non existent package' warning from scram.

PR validation:

The code compiles and the test run. No scram warnings anymore.

The test only needs the header so the lack of a shared library
(since the package is plugin only) does not matter.
@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27828/11554

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

L1Trigger/GlobalMuonTrigger

@cmsbuild, @rekovic, @benkrikler can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 22, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2121/console Started: 2019/08/22 18:57

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d6f230/2121/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2939508
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2939165
  • DQMHistoTests: Total skipped: 341
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 142 log files, 14 edm output root files, 34 DQM output files

@Dr15Jones
Copy link
Contributor Author

ping

@fabiocos
Copy link
Contributor

fabiocos commented Sep 3, 2019

@rekovic this PR looks technical and simple, please have a look, I will integrate it in next IB

@fabiocos
Copy link
Contributor

fabiocos commented Sep 3, 2019

+1

@fabiocos
Copy link
Contributor

fabiocos commented Sep 3, 2019

merge

@cmsbuild cmsbuild merged commit 23d7a0d into cms-sw:master Sep 3, 2019
@Dr15Jones Dr15Jones deleted the restructureL1TriggerGlobalMuonTrigger branch September 10, 2019 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants