-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed use of L1Trigger/GlobalMuonTrigger from test #27828
Removed use of L1Trigger/GlobalMuonTrigger from test #27828
Conversation
The test only needs the header so the lack of a shared library (since the package is plugin only) does not matter.
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27828/11554
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages: L1Trigger/GlobalMuonTrigger @cmsbuild, @rekovic, @benkrikler can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
ping |
@rekovic this PR looks technical and simple, please have a look, I will integrate it in next IB |
+1 |
merge |
PR description:
The test only needs the header so the lack of a shared library (since the package is plugin only) does not matter.
This gets rid of a 'non existent package' warning from scram.
PR validation:
The code compiles and the test run. No scram warnings anymore.