Improve L1MuGMTMatrix

[Dr15Jones]

PR description:

• Use just a single contiguous memory location instead of an array of arrays.
• Use std::unique_ptr<T[]> to manage the memory
• Initialize matrix elements in the constructor
• Added a unit test to prove no functional changes happened

Not initializing the matrix elements in the constructor was causing a complaint by UBSAN.

PR validation:

Code compiles and the new unit test passes.

This is a technical change and should have no impact on the results. It should take less memory and be faster.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27538/10915

• This PR adds an extra 24KB to repository

[Dr15Jones]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1495/console Started: 2019/07/16 23:18

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

L1Trigger/GlobalMuonTrigger

@cmsbuild, @rekovic, @benkrikler can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1
Tested at: f2a7db5
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-598931/1495/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-598931/1495/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 3081858
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3081535
• DQMHistoTests: Total skipped: 322
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 133 log files, 14 edm output root files, 32 DQM output files

[Dr15Jones]

ping @rekovic @benkrikler

[fabiocos]

@rekovic I would like to move forward with this PR. The code update looks ok to me, and the tests do not show any change. Please have a look asap, I plan to merge this PR in the coming IBs unless you have explicit objections.

[fabiocos]

+1

@rekovic please review this PR for possible future comments

[fabiocos]

merge

[davidlange6]

hi @Dr15Jones - unfortunately L1Trigger/GlobalMuonTrigger/src defines a plugin so you can't use it in the tests here (causing a warning in release builds now)

https://github.com/cms-sw/cmssw/pull/27538/files#diff-ad9585c8e3b32fba9922df3e129141f8R17

[Dr15Jones]

It would seem to me that the correct solution is to move the plugin out of /src and into a new /plugin directory (I'm on vacation today and for the next few days).

[Dr15Jones]

@davidlange6 see #27828