Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DQMServices for protobuf 3.6.1.2 and tensorflow interfaces for TF 1.13.1 (copy of 25889) #26689

Merged

Conversation

mrodozov
Copy link
Contributor

@mrodozov mrodozov commented May 8, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2019

A new Pull Request was created by @mrodozov (Mircho Rodozov) for CMSSW_10_6_DEVEL_X.

It involves the following packages:

DQMServices/Core
PhysicsTools/TensorFlow

@perrotta, @andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU, @slava77, @santocch can you please review it and eventually sign? Thanks.
@makortel, @barvic this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@mrodozov mrodozov changed the title Dqmservices protobuf update 3612 Update DQMServices for protobuf 3.6.1.2 and tensorflow interfaces for TF 1.13.1 (copy of 25889) May 8, 2019
@smuzaffar
Copy link
Contributor

thanks @mrodozov .
@fabiocos , I am merging this in DEVEL IBs to test tensorflow update.

@smuzaffar smuzaffar merged commit cc5729f into cms-sw:CMSSW_10_6_DEVEL_X May 8, 2019
@fabiocos
Copy link
Contributor

fabiocos commented May 8, 2019

As agreed at the ORP 2019/05/07

@mrodozov
Copy link
Contributor Author

@smuzaffar the cms pr from the last update

@jfernan2
Copy link
Contributor

jfernan2 commented Jun 4, 2020

+1
For the records

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2020

-1
Tested at: UNKNOWN
I was not able to find a release to test this PR. See the Jenkins logs for more details.

@jfernan2
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_DEVEL_X IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants