Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DQMServices for protobuf 3.6.1.2 and tensorflow interfaces for TF 1.13.1 #25889

Closed

Conversation

mrodozov
Copy link
Contributor

@mrodozov mrodozov commented Feb 8, 2019

Following instructions to update those file when updating protobuf in here:
https://github.com/cms-sw/cmsdist/blob/IB/CMSSW_10_5_X/gcc700/protobuf.spec

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 8, 2019

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 8, 2019

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25889/8357

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 8, 2019

A new Pull Request was created by @mrodozov (Mircho Rodozov) for master.

It involves the following packages:

DQMServices/Core

@cmsbuild, @kmaeshima, @andrius-k, @jfernan2, @schneiml can you please review it and eventually sign? Thanks.
@barvic this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@mrodozov
Copy link
Contributor Author

mrodozov commented Feb 8, 2019

please test with cms-sw/cmsdist#4684

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 8, 2019

The tests are being triggered in jenkins.
Using externals from cms-sw/cmsdist#4684
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33050/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 8, 2019

-1

Tested at: 4df864a

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25889/33050/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

  • Unit Tests:

I found errors in the following unit tests:

---> test testTheano had ERRORS
---> test testTFMetaGraphLoading had ERRORS
---> test testTFGraphLoading had ERRORS
---> test testImports had ERRORS

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 8, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 8, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25889/33050/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3097440
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3097242
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 133 log files, 14 edm output root files, 32 DQM output files

@smuzaffar
Copy link
Contributor

please test with cms-sw/cmsdist#4684

@mrodozov
Copy link
Contributor Author

mrodozov commented Apr 27, 2019

please test with cms-sw/cmsdist#4890

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 27, 2019

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmsdist#4890
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/34379/console

@cmsbuild
Copy link
Contributor

-1

Tested at: 43e84aa

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25889/34379/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests RelVals

  • Unit Tests:

I found errors in the following unit tests:

---> test testConditionDatabase_2 had ERRORS

  • RelVals:

The relvals timed out after 4 hours.

@cmsbuild
Copy link
Contributor

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

@slava77
Copy link
Contributor

slava77 commented May 9, 2019

@mrodozov please clarify on the status of this PR.
Thank you.
It looks like it is still not ready for review, a work in progress.

@mrodozov
Copy link
Contributor Author

mrodozov commented May 9, 2019

@slava77 we merged the changes from here into DEVEL to have an IB to work against.

@smuzaffar smuzaffar modified the milestones: CMSSW_10_6_X, CMSSW_11_0_X May 14, 2019
@slava77
Copy link
Contributor

slava77 commented May 16, 2019

@slava77 we merged the changes from here into DEVEL to have an IB to work against.

Please clarify on the status of making this PR applicable for the regular master version of CMSSW.
Thank you.

@davidlange6
Copy link
Contributor

davidlange6 commented May 16, 2019 via email

@slava77
Copy link
Contributor

slava77 commented Jun 10, 2019

@mrodozov
please clarify on the status of this PR.
Thank you.

@slava77
Copy link
Contributor

slava77 commented Jun 11, 2019

it needs to run without hanging first... Any review is certainly useful in the meanwhile.

is the origin of the hanging understood?

I noticed in 1.12 notes https://github.com/tensorflow/tensorflow/blob/master/RELEASE.md#bug-fixes-and-other-changes-2 that there was a change from jemalloc to the system malloc.
Could a mix of allocators lead to problems?

@slava77
Copy link
Contributor

slava77 commented Jun 17, 2019

@mrodozov
please clarify on the status of this PR.
Thank you.

ping

@mrodozov
Copy link
Contributor Author

I'll reopen it when we are ready

@mrodozov mrodozov closed this Jun 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants