-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update DQMServices for protobuf 3.6.1.2 and tensorflow interfaces for TF 1.13.1 #25889
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25889/8357
|
A new Pull Request was created by @mrodozov (Mircho Rodozov) for master. It involves the following packages: DQMServices/Core @cmsbuild, @kmaeshima, @andrius-k, @jfernan2, @schneiml can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test with cms-sw/cmsdist#4684 |
The tests are being triggered in jenkins. |
-1 Tested at: 4df864a You can see the results of the tests here: I found follow errors while testing this PR Failed tests: UnitTests
I found errors in the following unit tests: ---> test testTheano had ERRORS |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
please test with cms-sw/cmsdist#4684 |
please test with cms-sw/cmsdist#4890 |
The tests are being triggered in jenkins. |
-1 Tested at: 43e84aa You can see the results of the tests here: I found follow errors while testing this PR Failed tests: UnitTests RelVals
I found errors in the following unit tests: ---> test testConditionDatabase_2 had ERRORS
The relvals timed out after 4 hours. |
Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped) |
Relvals doesn't finish because of gdb hang on runtime error: In the first test, different relval crashed with the same reason: |
@mrodozov please clarify on the status of this PR. |
@slava77 we merged the changes from here into DEVEL to have an IB to work against. |
Please clarify on the status of making this PR applicable for the regular master version of CMSSW. |
it needs to run without hanging first... Any review is certainly useful in the meanwhile.
… On May 16, 2019, at 3:56 PM, Slava Krutelyov ***@***.***> wrote:
@slava77 we merged the changes from here into DEVEL to have an IB to work against.
Please clarify on the status of making this PR applicable for the regular master version of CMSSW.
Thank you.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
@mrodozov |
is the origin of the hanging understood? I noticed in 1.12 notes https://github.com/tensorflow/tensorflow/blob/master/RELEASE.md#bug-fixes-and-other-changes-2 that there was a change from jemalloc to the system malloc. |
ping |
I'll reopen it when we are ready |
Following instructions to update those file when updating protobuf in here:
https://github.com/cms-sw/cmsdist/blob/IB/CMSSW_10_5_X/gcc700/protobuf.spec