-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove CMS custom hacks for Oracle OCCI old C++ ABI compatibility #26083
Conversation
The code-checks are being triggered in jenkins. |
please test with cms-sw/cmsdist#4755 |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26083/8642
|
The tests are being triggered in jenkins. |
A new Pull Request was created by @cmsbuild for master. It involves the following packages: CaloOnlineTools/HcalOnlineDb @ggovi, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@ggovi I would like to converge on this before CMSSW_10_6_0_pre1 is built, unless you have objections |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
FYI @fabiocos . This is to move to new OCCI libs. |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
This appears to have caused a compilation failure in clang. |
backport of #25691
Removes custom oracle calls introduces in this commit
03499f0
and keeps the changes introduced in later commits.
Revert #22384 commit 03499f0