Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CMS custom hacks for Oracle OCCI old C++ ABI compatibility #26083

Merged
merged 2 commits into from
Mar 7, 2019

Conversation

cmsbuild
Copy link
Contributor

@cmsbuild cmsbuild commented Mar 6, 2019

backport of #25691

Removes custom oracle calls introduces in this commit
03499f0
and keeps the changes introduced in later commits.

Revert #22384 commit 03499f0

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Mar 6, 2019

The code-checks are being triggered in jenkins.

@mrodozov
Copy link
Contributor

mrodozov commented Mar 6, 2019

please test with cms-sw/cmsdist#4755

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Mar 6, 2019

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26083/8642

  • This PR adds an extra 8KB to repository

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Mar 6, 2019

The tests are being triggered in jenkins.
Using externals from cms-sw/cmsdist#4755
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33434/console

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Mar 6, 2019

A new Pull Request was created by @cmsbuild for master.

It involves the following packages:

CaloOnlineTools/HcalOnlineDb
OnlineDB/CSCCondDB
OnlineDB/EcalCondDB
OnlineDB/Oracle
OnlineDB/SiStripConfigDb

@ggovi, @cmsbuild can you please review it and eventually sign? Thanks.
@erikbutz, @mmusich, @argiro this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@fabiocos
Copy link
Contributor

fabiocos commented Mar 6, 2019

@ggovi I would like to converge on this before CMSSW_10_6_0_pre1 is built, unless you have objections

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Mar 6, 2019

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Mar 6, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Mar 6, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26083/33434/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 5 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3114826
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3114628
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 133 log files, 14 edm output root files, 32 DQM output files

@smuzaffar
Copy link
Contributor

FYI @fabiocos . This is to move to new OCCI libs.

@ggovi
Copy link
Contributor

ggovi commented Mar 7, 2019

+1

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Mar 7, 2019

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Mar 7, 2019

+1

@cmsbuild cmsbuild merged commit 4672572 into master Mar 7, 2019
@Dr15Jones
Copy link
Contributor

This appears to have caused a compilation failure in clang.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants